Page MenuHomePhabricator
Feed All Stories

Feb 13 2022

kalali committed rMITK6856411d1ec0: Clean view navigator widget and make it more readable (authored by kalali).
Clean view navigator widget and make it more readable
Feb 13 2022, 1:32 PM
kalali committed rMITKeefb7b900f4c: Correct view navigator item files (authored by kalali).
Correct view navigator item files
Feb 13 2022, 1:31 PM
kalali committed rMITK34849782db80: Clean view navigator view files (authored by kalali).
Clean view navigator view files
Feb 13 2022, 1:31 PM
kalali committed rMITK4340180d5ea8: Rename plugin activator files (authored by kalali).
Rename plugin activator files
Feb 13 2022, 1:31 PM

Feb 11 2022

wiesenfa added a comment to T28966: y-axis of blob plots always scaled to 5.

not sure whether this is a good idea. imagine a challenge with 18 algorithms. there will be only a 1 and an 18 and nothing in between, this may make it difficult to read. what do you think?

Feb 11 2022, 8:24 PM · challengeR
floca added a comment to T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem.

You can see how it feels and looks when the differential for the mentioned task is uploaded. However, I am not sure about point 1B and if we should rather create a first initial label when creating a new segmentation (node).

with this point I am also unsure. From first impulse I guess I would find it annoying, if I always have to explicitly generate the first label. So I would always add at least one new label.

Feb 11 2022, 5:46 PM · MITK (v2022.04), Cleared
aekavur added a comment to T28966: y-axis of blob plots always scaled to 5.

I have tried suggested codes but they did not fix the problem. Besides, there caused additional issues. :)

Feb 11 2022, 2:02 PM · challengeR
aekavur committed rCHALLENGER2011a8bdc2cc: Range of y-axis scaled to number of algorithms (authored by aekavur).
Range of y-axis scaled to number of algorithms
Feb 11 2022, 1:53 PM
wiesenfa added a comment to T28966: y-axis of blob plots always scaled to 5.

Could you try to replace "breaks" by "labels" in

Feb 11 2022, 11:52 AM · challengeR
eisenman added a comment to T28966: y-axis of blob plots always scaled to 5.

I have tested this with the provided data. The scaling of the y-axis seems to be correct now. But only the first rank is labeled on the y-axis. Can the other ranks be labeled as well?

Feb 11 2022, 11:26 AM · challengeR
kislinsk added a member for Repository Admins: ahmadqasim.
Feb 11 2022, 10:26 AM
kislinsk added a member for Repository Admins: t391x.
Feb 11 2022, 10:26 AM
amiiney added a comment to T28950: Send jobs to the GPU cluster.

Is it resolved?

Feb 11 2022, 9:55 AM · Restricted Project
amiiney added a comment to T28950: Send jobs to the GPU cluster.
Feb 11 2022, 9:54 AM · Restricted Project
holzwart added a comment to T28950: Send jobs to the GPU cluster.

Is it resolved?

Feb 11 2022, 8:52 AM · Restricted Project
holzwart moved T28950: Send jobs to the GPU cluster from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Feb 11 2022, 8:52 AM · Restricted Project

Feb 10 2022

kalali added a comment to T28256: [Segmentation] Auto-selection preference was hijacked for something else.

Has been resolved with D533.

However, there is a slightly different behavior now with the selection widgets:
The user cannot select segmentations of image B if image A is selected in the image selection widget (node predicates only allow child-nodes of the selected image node). That means:

Either I do not understand the change correctly, or I am against it.

I think node hirachy should not be a requirement to be selectable. Only the type of node and fitting geometry should. We e.g. have use cases where image and segmentation are on the same hirachy level. In this case it should still be possible to select both (if all other requirements are meet) and modify the segmentation.

Feb 10 2022, 5:00 PM · Breaking Change, Request for Discussion, MITK (v2022.04)
floca reopened T28256: [Segmentation] Auto-selection preference was hijacked for something else, a subtask of T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation, as Open.
Feb 10 2022, 4:58 PM · MITK (v2022.04), Breaking Change
floca reopened T28256: [Segmentation] Auto-selection preference was hijacked for something else as "Open".
Feb 10 2022, 4:58 PM · Breaking Change, Request for Discussion, MITK (v2022.04)
floca added a comment to T28256: [Segmentation] Auto-selection preference was hijacked for something else.

Has been resolved with D533.

However, there is a slightly different behavior now with the selection widgets:
The user cannot select segmentations of image B if image A is selected in the image selection widget (node predicates only allow child-nodes of the selected image node). That means:

Either I do not understand the change correctly, or I am against it.

Feb 10 2022, 4:56 PM · Breaking Change, Request for Discussion, MITK (v2022.04)
kalali closed T28256: [Segmentation] Auto-selection preference was hijacked for something else as Resolved.

Has been resolved with D533.

Feb 10 2022, 4:17 PM · Breaking Change, Request for Discussion, MITK (v2022.04)
kalali closed T28256: [Segmentation] Auto-selection preference was hijacked for something else, a subtask of T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation, as Resolved.
Feb 10 2022, 4:17 PM · MITK (v2022.04), Breaking Change
kalali edited projects for T28789: [Segmentation][Multilabel][Options] Auto-selection mode is unclear in checklist or broken, added: MITK (v2022.04); removed MITK.
Feb 10 2022, 3:56 PM · MITK (v2022.04), Checklist
neher committed rMITKDIFFa32d41634e6c: fixed stuck parcellation (authored by neher).
fixed stuck parcellation
Feb 10 2022, 3:48 PM
kalali added a project to T28493: Multilabel color map colors are not very nice: Request for Discussion.
Feb 10 2022, 3:47 PM · Checklist, Request for Discussion, MITK (v2022.04)
kalali raised the priority of T28493: Multilabel color map colors are not very nice from Low to Needs Triage.

I stumbled upon this since I want to automatically assign label colors to new labels. I use the Multilabel lookuptable (see https://phabricator.mitk.org/source/mitk/browse/develop/Modules/Core/src/DataManagement/mitkLookupTable.cpp$527) and the values are not working to distinguish neighboring labels / indices sufficiently.

Feb 10 2022, 3:47 PM · Checklist, Request for Discussion, MITK (v2022.04)
t543a closed T28962: Model selection for GetTaskModelOperator as Resolved.
Feb 10 2022, 10:21 AM · Kaapana (internal)
t543a triaged T28972: NnUnetOperator adding wrong suffix to names as Normal priority.
Feb 10 2022, 10:05 AM · Kaapana (internal)

Feb 9 2022

kalali added a comment to T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem.

I worked on this while working on T28142:

Feb 9 2022, 9:24 PM · MITK (v2022.04), Cleared
kalali claimed T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem.
Feb 9 2022, 12:28 PM · MITK (v2022.04), Cleared
kalali claimed T28256: [Segmentation] Auto-selection preference was hijacked for something else.
Feb 9 2022, 12:28 PM · Breaking Change, Request for Discussion, MITK (v2022.04)
kalali claimed T28640: [Segmentation] Add tool checks for dynamic plugin view.
Feb 9 2022, 12:27 PM · MITK (v2022.04)
kompan claimed T28294: [Documentation] std multiwidget does show a blank page on F1.
Feb 9 2022, 12:26 PM · Restricted Project, MITK (v2022.04), Missing Info
floca moved T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification from Tests/Checklists to Cycle on the MITK (v2022.04) board.
Feb 9 2022, 12:13 PM · MITK (v2024.06)
floca moved T28481: [Checklist] [Test data] Define publicly available user test data from Tests/Checklists to Cycle on the MITK (v2022.04) board.
Feb 9 2022, 12:00 PM · MITK, Next Milestone
kislinsk moved T27437: Migrate MITK to use ITK 5.x from Backlog to Cycle on the MITK (v2022.04) board.
Feb 9 2022, 11:51 AM · MITK-ProjectTemplate, MITK (v2022.04)
floca edited projects for T25804: [Selection concept] Set 'selected' property when using the new selection concept, added: MITK, Next Milestone; removed MITK (v2022.04).
Feb 9 2022, 11:48 AM · MITK (v2024.06), Request for Discussion
kalali claimed T28617: Inconsistent view initialization in rendering manager.
Feb 9 2022, 11:43 AM · Breaking Change, MITK (v2022.04)
kompan placed T27608: [MITKDoc] Documentation Refurbish - Developer Manual up for grabs.
Feb 9 2022, 11:28 AM · MITK (v2024.06), Cleared
kompan closed T27666: Concentration curve converter view- missing echo time unit as Resolved.
Feb 9 2022, 11:27 AM · MITK (v2022.04), Cleared
kalali added a subtask for T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation: T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem.
Feb 9 2022, 11:27 AM · MITK (v2022.04), Breaking Change
kalali removed a subtask for T27807: [MultiLabel Segmentation] Inspection of module and plugin: T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem.
Feb 9 2022, 11:27 AM · MITK (v2024.06)
kalali edited parent tasks for T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem, added: T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation; removed: T27807: [MultiLabel Segmentation] Inspection of module and plugin.
Feb 9 2022, 11:27 AM · MITK (v2022.04), Cleared
kalali moved T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem from Segmentation to Cycle on the MITK (v2022.04) board.
Feb 9 2022, 11:26 AM · MITK (v2022.04), Cleared
floca moved T28464: [Segmentation] New Add/Remove tool from Segmentation to Cycle on the MITK (v2022.04) board.
Feb 9 2022, 11:26 AM · MITK (v2022.10)
kalali moved T28640: [Segmentation] Add tool checks for dynamic plugin view from Segmentation to Cycle on the MITK (v2022.04) board.
Feb 9 2022, 11:25 AM · MITK (v2022.04)
kalali moved T26972: Dialog and plugin layout seems to be not shown correctly on laptops from Backlog to Segmentation on the MITK (v2022.04) board.
Feb 9 2022, 11:24 AM · MITK (v2024.06), Missing Info
kalali added a parent task for T28256: [Segmentation] Auto-selection preference was hijacked for something else: T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation.
Feb 9 2022, 11:23 AM · Breaking Change, Request for Discussion, MITK (v2022.04)
kalali added a subtask for T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation: T28256: [Segmentation] Auto-selection preference was hijacked for something else.
Feb 9 2022, 11:23 AM · MITK (v2022.04), Breaking Change
kalali moved T28256: [Segmentation] Auto-selection preference was hijacked for something else from Backlog to Cycle on the MITK (v2022.04) board.
Feb 9 2022, 11:23 AM · Breaking Change, Request for Discussion, MITK (v2022.04)
kalali moved T28557: Cannot load segmentations from KITS challenge due to unknown pixel type from Backlog to Segmentation on the MITK (v2022.04) board.
Feb 9 2022, 11:22 AM · MITK, Request for Discussion
kalali moved T28246: Create UI test for LevelWindow QtWidgets from Backlog to Tests/Checklists on the MITK (v2022.04) board.
Feb 9 2022, 11:21 AM · MITK (v2024.06)
kalali lowered the priority of T28246: Create UI test for LevelWindow QtWidgets from High to Low.
Feb 9 2022, 11:21 AM · MITK (v2024.06)
kalali moved T28819: [View Navigator] View Names don't become bold when opened from Backlog to Cycle on the MITK (v2022.04) board.
Feb 9 2022, 9:34 AM · MITK (v2022.04), Checklist
kalali edited projects for T28819: [View Navigator] View Names don't become bold when opened, added: MITK (v2022.04); removed MITK.
Feb 9 2022, 9:34 AM · MITK (v2022.04), Checklist
kalali placed T28181: [Segmentation] Should warning messages be passed on to the UI? up for grabs.
Feb 9 2022, 9:32 AM · MITK (v2024.06)
kalali moved T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation from Segmentation to Cycle on the MITK (v2022.04) board.
Feb 9 2022, 9:31 AM · MITK (v2022.04), Breaking Change

Feb 8 2022

kalali added a parent task for T26396: [Segmentation] Refactor functions to create new (empty) segmentations: T27807: [MultiLabel Segmentation] Inspection of module and plugin.
Feb 8 2022, 3:21 PM · Next Milestone, Request for Discussion
kalali added a subtask for T27807: [MultiLabel Segmentation] Inspection of module and plugin: T26396: [Segmentation] Refactor functions to create new (empty) segmentations.
Feb 8 2022, 3:21 PM · MITK (v2024.06)
kalali reopened T26396: [Segmentation] Refactor functions to create new (empty) segmentations as "Open".
Feb 8 2022, 3:20 PM · Next Milestone, Request for Discussion
kalali added a subtask for T27807: [MultiLabel Segmentation] Inspection of module and plugin: T28493: Multilabel color map colors are not very nice.
Feb 8 2022, 3:16 PM · MITK (v2024.06)
kalali added a parent task for T28493: Multilabel color map colors are not very nice: T27807: [MultiLabel Segmentation] Inspection of module and plugin.
Feb 8 2022, 3:16 PM · Checklist, Request for Discussion, MITK (v2022.04)
kalali moved T28493: Multilabel color map colors are not very nice from Backlog to Segmentation on the MITK (v2022.04) board.
Feb 8 2022, 3:16 PM · Checklist, Request for Discussion, MITK (v2022.04)
kalali edited projects for T28493: Multilabel color map colors are not very nice, added: MITK (v2022.04); removed MITK.
Feb 8 2022, 3:15 PM · Checklist, Request for Discussion, MITK (v2022.04)
aekavur added a comment to T28746: [dash] NaN values cause error.

The problem is almost fixed by giving na.treat parameter in both as.challenge and ranking methods (except rankThenAggregate). Now we can generate reports for all ranking methods.

Feb 8 2022, 2:15 PM · challengeR, webChallengeR

Feb 7 2022

neher committed rMITKDIFFf433cb5ca332: restructured cdmapps (authored by neher).
restructured cdmapps
Feb 7 2022, 3:57 PM
aekavur updated subscribers of T28966: y-axis of blob plots always scaled to 5.
Feb 7 2022, 3:00 PM · challengeR
aekavur added a comment to T28966: y-axis of blob plots always scaled to 5.

scale_y_continuous functions inside ./R/Stability.R file were modified. The problem seems solved. You can test it feature/T28966-YaxisOfBlobPlotsAlwaysScaledTo5 branch via the file at the attachment. (You can run it root folder of the challengeR code)

Feb 7 2022, 2:57 PM · challengeR
aekavur committed rCHALLENGER4c7dd2389fde: Range of y-axis is set by number of algorithms. (authored by aekavur).
Range of y-axis is set by number of algorithms.
Feb 7 2022, 2:47 PM
aekavur committed rCHALLENGERf77364e45843: .gitignore file updated. (authored by aekavur).
.gitignore file updated.
Feb 7 2022, 2:47 PM
aekavur updated the task description for T28966: y-axis of blob plots always scaled to 5.
Feb 7 2022, 1:23 PM · challengeR
aekavur triaged T28966: y-axis of blob plots always scaled to 5 as Normal priority.
Feb 7 2022, 1:22 PM · challengeR
wiesenfa added a comment to T28746: [dash] NaN values cause error.

I guess na.treat it is only needed for the line plot for comparing to other ranking methods?
In this case, a message could be thrown when compiling the report saying something like "line plot comparing ranking methods omitted since na.treat is not specified. Specify na.treat in as.challenge() if inclusion of line plot is desired" and allow compilation of the report (excluding line plot).
(Note that you can define na.treat both in as.challenge() as well as in the ranking functions).

Feb 7 2022, 12:02 PM · challengeR, webChallengeR
kalali added a subtask for T28479: [Segmentation] Rethink / reevaluate our existing segmentation tools / algorithms: T16026: Distinct tool names for 2d and 3d segmentation tools.
Feb 7 2022, 10:28 AM · MITK (v2024.06)
kalali added a parent task for T16026: Distinct tool names for 2d and 3d segmentation tools: T28479: [Segmentation] Rethink / reevaluate our existing segmentation tools / algorithms.
Feb 7 2022, 10:28 AM · MITK, Bugzilla

Feb 4 2022

neher committed rMITKDIFF3596f107e46d: num parcels parameter (authored by neher).
num parcels parameter
Feb 4 2022, 1:34 PM
neher committed rMITKDIFF67e23c7bac14: code for comparing tractometry approaches (authored by neher).
code for comparing tractometry approaches
Feb 4 2022, 12:41 PM
neher committed rMITKDIFF7c8673c42913: move tractometry out of view (authored by neher).
move tractometry out of view
Feb 4 2022, 12:41 PM
kahl added a revision to T28959: [Segmentation] LiveWire Closing Contour improvements: Unknown Object (Differential Revision).
Feb 4 2022, 10:41 AM · MITK

Feb 3 2022

neher committed rMITKDIFFb5b19e94e1bf: Interpolating image values (authored by neher).
Interpolating image values
Feb 3 2022, 2:42 PM
neher committed rMITKDIFFfff7dd9d37ca: Visualizing parcdellation statistics (authored by neher).
Visualizing parcdellation statistics
Feb 3 2022, 2:42 PM
t543a triaged T28962: Model selection for GetTaskModelOperator as Wishlist priority.
Feb 3 2022, 10:00 AM · Kaapana (internal)

Feb 2 2022

neher committed rMITKDIFF32917714164b: refactor color lookuptables. auto select number of segments. (authored by neher).
refactor color lookuptables. auto select number of segments.
Feb 2 2022, 11:32 AM
kahl added a comment to T28959: [Segmentation] LiveWire Closing Contour improvements.

Pushed new branch to rMITK MITK: feature/T28959-livewire-closure-improvements.

Feb 2 2022, 8:51 AM · MITK

Feb 1 2022

kahl triaged T28959: [Segmentation] LiveWire Closing Contour improvements as Normal priority.
Feb 1 2022, 4:12 PM · MITK
m813r added a member for MIC: r948e.
Feb 1 2022, 3:24 PM
kompan added a project to T27904: Feature request: Colorbars to interpret data in MITK: Request for Discussion.
Feb 1 2022, 11:46 AM · Request for Discussion, MITK

Jan 31 2022

kislinsk set the color for SDS-Meta to Green.
Jan 31 2022, 1:38 PM
kislinsk created SDS-Meta.
Jan 31 2022, 1:37 PM
neher committed rMITKDIFF7c2304981c16: added tract parcellation cmdapp (authored by neher).
added tract parcellation cmdapp
Jan 31 2022, 12:08 PM
neher committed rMITKDIFFeedf6efa5a6a: Created dedicated tract parcellation filter (authored by neher).
Created dedicated tract parcellation filter
Jan 31 2022, 12:08 PM

Jan 28 2022

eisenman updated subscribers of T28746: [dash] NaN values cause error.

Thank you for investigating this! In challengeR it is covered in the way that a message is emitted saying "na.treat obligatory if report is intended to be compiled". In order to solve the mentioned issue 2, a strategy for the preferred way to handle it in VISSART should be defined. Should the user be guided to specify the NaN handling strategy? Should the user be able to generate a report but without the plots that require numeric values?

Jan 28 2022, 12:25 PM · challengeR, webChallengeR
aekavur added a comment to T28746: [dash] NaN values cause error.

Current status of the issue:

Jan 28 2022, 11:33 AM · challengeR, webChallengeR
kislinsk closed T28941: Some 2D and 3D tools for segmentation are not available as Invalid.
Jan 28 2022, 9:10 AM · MITK
Unknown Object (User) added a comment to T28946: MITK Flow - Save Segmentation - Error/Exception Handling.
Jan 28 2022, 6:50 AM · Kaapana (internal), MITK
Unknown Object (User) added a comment to T28946: MITK Flow - Save Segmentation - Error/Exception Handling.
Jan 28 2022, 6:49 AM · Kaapana (internal), MITK
Unknown Object (User) added a comment to T28946: MITK Flow - Save Segmentation - Error/Exception Handling.
Jan 28 2022, 6:48 AM · Kaapana (internal), MITK
Unknown Object (User) added a comment to T28946: MITK Flow - Save Segmentation - Error/Exception Handling.
Jan 28 2022, 6:47 AM · Kaapana (internal), MITK

Jan 27 2022

fedorov added a comment to T28946: MITK Flow - Save Segmentation - Error/Exception Handling.

Since in the input image a required tag is missing, MITK cannot provide a fix, allowing a success in dcmqi

Jan 27 2022, 5:46 PM · Kaapana (internal), MITK
neher committed rMITKDIFF7b0842815a80: tract parcellation (authored by neher).
tract parcellation
Jan 27 2022, 4:35 PM