Page MenuHomePhabricator
Feed All Stories

Jan 18 2021

floca added a comment to T28127: Reopen segmentation in MITK.

1e-5 should still be conservative enough for the purpose of geometries.

Is your statement also valid for 5e-5? Beause 1e-5 would not be enough in that case.

Jan 18 2021, 11:31 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)
s669m created T28169: TFDA MVP v1 powered by Kaapana.
Jan 18 2021, 10:50 AM · Kaapana (internal)
s669m triaged T28168: TFDA Code Repo Creation as Normal priority.
Jan 18 2021, 10:46 AM · Kaapana (internal)
s669m created T28167: System set up: Multi Provider Site Version.
Jan 18 2021, 10:25 AM · Restricted Project
s669m triaged T28166: Executor Separation as High priority.
Jan 18 2021, 10:23 AM · Restricted Project
s669m created T28165: TFDA Repo Creation.
Jan 18 2021, 10:20 AM · Restricted Project
kislinsk closed T28164: Update date in copyright as Resolved.
Jan 18 2021, 6:39 AM · MITK (v2021.02)
kislinsk added a comment to T28164: Update date in copyright.

Deleted branch bugfix/T28164-CopyrightDate.

Jan 18 2021, 6:39 AM · MITK (v2021.02)
kislinsk committed rMITK7609ba5f5be8: Merge branch 'bugfix/T28164-CopyrightDate' into develop (authored by kislinsk).
Merge branch 'bugfix/T28164-CopyrightDate' into develop
Jan 18 2021, 6:38 AM
kislinsk committed rMITKe1f7ba295014: Adjust date range (authored by kislinsk).
Adjust date range
Jan 18 2021, 6:38 AM
kislinsk added a comment to T28164: Update date in copyright.

Pushed new branch bugfix/T28164-CopyrightDate.

Jan 18 2021, 6:38 AM · MITK (v2021.02)
kislinsk triaged T28164: Update date in copyright as Low priority.
Jan 18 2021, 6:33 AM · MITK (v2021.02)
kislinsk added a comment to T28127: Reopen segmentation in MITK.

Thanks for looking into this issue as well. :-) I think 1e-5 is okay. We/you already introduced NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION not long ago since we had similar issues and 1e-5 should still be conservative enough for the purpose of geometries.

Jan 18 2021, 5:01 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)

Jan 17 2021

floca claimed T28127: Reopen segmentation in MITK.

The problem seems to be that DCMQI rounds the the orientation matrix values at the 5th decimal place when storing to DCM Seg.

Jan 17 2021, 8:41 PM · MITK (v2021.02), Restricted Project, Kaapana (internal)
floca added a revision to T28148: Fix/Refactor ContourElement: Restricted Differential Revision.
Jan 17 2021, 1:50 PM · MITK (v2021.02)
floca added a comment to T28118: Refactoring of SegTool2D.

Pushed new branch feature/T28118-Refactor_SegTool2D_and_derived_classes.

Jan 17 2021, 1:45 PM · MITK (v2021.02)

Jan 16 2021

floca added a revision to T28148: Fix/Refactor ContourElement: Unknown Object (Differential Revision).
Jan 16 2021, 8:48 PM · MITK (v2021.02)

Jan 15 2021

kislinsk added a comment to T28159: Officially support MITK using system Qt.

I understand. :-) Just wanted to give you more options to think about as it is probably only a temporal solution. Sooner or later (currently read "later"), our minimum version requirements won't match again with the OS-provided Qt version. So we cannot run away from it forever I guess. :D

Jan 15 2021, 12:40 PM · Auto-closed, CI, Request for Discussion, MITK
gaoh added a comment to T28159: Officially support MITK using system Qt.

yes exactly, the problem with the scripted version, ist still, that it is necessary to provide credentials. That was fine, as long we were the only ones creating the containers.
The version of @nolden downloading the packages in ubuntu allows others to just build the container, without having to provide credentials at all.

Jan 15 2021, 12:35 PM · Auto-closed, CI, Request for Discussion, MITK
nolden added a comment to T28159: Officially support MITK using system Qt.

Thank. New command-line interface looks nice, but the challenge is where to put the credentials, especially if you want to put the script open source like in the Kaapana dockerfiles.

Jan 15 2021, 12:14 PM · Auto-closed, CI, Request for Discussion, MITK
kislinsk renamed T27693: Packaging Python does not work/is not implemented from Cannot start nightly workbench on a clean Ubuntu 18/20 to Packaging Python does not work/is not implemented.
Jan 15 2021, 12:09 PM · MITK
kislinsk merged T27894: Linux nightly installer doesn't start on Fedora into T27693: Packaging Python does not work/is not implemented.
Jan 15 2021, 12:09 PM · MITK
kislinsk merged task T27894: Linux nightly installer doesn't start on Fedora into T27693: Packaging Python does not work/is not implemented.
Jan 15 2021, 12:09 PM · MITK (v2021.02)
kislinsk edited projects for T27196: Rewrite packaging of MITK, added: Next Milestone, MITK; removed MITK (v2021.02).
Jan 15 2021, 12:07 PM · MITK (v2024.06), Cleared

Jan 14 2021

kislinsk triaged T28159: Officially support MITK using system Qt as Normal priority.

As it already works (?) and we will stay at least another year with Qt 5 we can do this. But in general, do you know of the new Qt Installer Framework with command-line interface? It's much easier now to install Qt with a single command and there are a few possibilities to provide credentials if that's an issue. See here for examples: https://phabricator.mitk.org/T27960#214043

Jan 14 2021, 5:22 PM · Auto-closed, CI, Request for Discussion, MITK
neher added a comment to T28017: Update to vtk 9.

Fiber mapper issue: https://vtk.org/doc/nightly/html/classvtkOpenGLPolyDataMapper.html#a80cc4bf99b408c63cad0a59c0388ffae

Jan 14 2021, 4:47 PM · MITK Diffusion
neher committed rMITKDIFF79272f527e51: Merge branch 'T28017-VTK9-CodeIssues' (authored by neher).
Merge branch 'T28017-VTK9-CodeIssues'
Jan 14 2021, 4:42 PM
neher committed rMITKDIFFdd4062dbe8b6: Solved tinyxml update issues (authored by neher).
Solved tinyxml update issues
Jan 14 2021, 4:42 PM
nolden added a project to T28159: Officially support MITK using system Qt: CI.
Jan 14 2021, 3:51 PM · Auto-closed, CI, Request for Discussion, MITK
nolden updated the task description for T28159: Officially support MITK using system Qt.
Jan 14 2021, 3:50 PM · Auto-closed, CI, Request for Discussion, MITK
nolden created T28159: Officially support MITK using system Qt.
Jan 14 2021, 3:46 PM · Auto-closed, CI, Request for Discussion, MITK
kislinsk closed T28155: Make Qt log messages optional as Resolved.
Jan 14 2021, 11:09 AM · MITK (v2021.02)
kislinsk added a comment to T28155: Make Qt log messages optional.

Deleted branch feature/T28155-MakeQtLogMessagesOptional.

Jan 14 2021, 11:08 AM · MITK (v2021.02)
kislinsk committed rMITK8aeabe996f16: Make Qt log messages optional (authored by kislinsk).
Make Qt log messages optional
Jan 14 2021, 11:08 AM
kislinsk committed rMITK46eee069a4bf: Merge branch 'feature/T28155-MakeQtLogMessagesOptional' into develop (authored by kislinsk).
Merge branch 'feature/T28155-MakeQtLogMessagesOptional' into develop
Jan 14 2021, 11:08 AM
kislinsk added a comment to T28155: Make Qt log messages optional.

Pushed new branch feature/T28155-MakeQtLogMessagesOptional.

Jan 14 2021, 11:07 AM · MITK (v2021.02)
p212r removed a watcher for Kaapana (internal): p212r.
Jan 14 2021, 10:02 AM
p212r added a watcher for Kaapana (internal): p212r.
Jan 14 2021, 10:02 AM
gaoh added a member for Kaapana (internal): e249r.
Jan 14 2021, 9:39 AM
schererj added a member for Kaapana (internal): p212r.
Jan 14 2021, 9:39 AM

Jan 13 2021

kalali triaged T28156: [Segmentation] Fix timestep / timepoint types as Normal priority.
Jan 13 2021, 3:43 PM · MITK (v2024.06)
kislinsk added a revision to T28155: Make Qt log messages optional: Unknown Object (Differential Revision).
Jan 13 2021, 3:33 PM · MITK (v2021.02)
kislinsk triaged T28155: Make Qt log messages optional as Normal priority.
Jan 13 2021, 3:26 PM · MITK (v2021.02)
kislinsk updated subscribers of T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12.
Jan 13 2021, 2:53 PM · Noteworthy, MITK (v2021.02)
kislinsk closed T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12 as Resolved.

Since we need to patch VTK anyway, I took the opportunity to upgrade from VTK 9.0.0 to 9.0.1.

Jan 13 2021, 2:52 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12.

Deleted branch bugfix/T28151-FixVTKOnMacOSXCode12.

Jan 13 2021, 2:51 PM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITKc0ad4f1441a1: Exclude unistd.h from Windows builds (authored by kislinsk).
Exclude unistd.h from Windows builds
Jan 13 2021, 2:47 PM
kislinsk committed rMITKda3e2af67311: Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop (authored by kislinsk).
Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop
Jan 13 2021, 2:47 PM
kislinsk committed rMITK6617af527acd: Patch (and upgrade) VTK (authored by kislinsk).
Patch (and upgrade) VTK
Jan 13 2021, 2:16 PM
kislinsk committed rMITKca75fe9867c2: Fix compiler errors with XCode 12 (authored by kislinsk).
Fix compiler errors with XCode 12
Jan 13 2021, 2:16 PM
kislinsk committed rMITKbce1eaddb837: Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop (authored by kislinsk).
Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop
Jan 13 2021, 2:16 PM
gaoh added a comment to T28127: Reopen segmentation in MITK.

Oh I forgot to mention: the segmentation is saved as dicom-seg.

Jan 13 2021, 10:09 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)
gaoh raised the priority of T28127: Reopen segmentation in MITK from High to Unbreak Now!.
Jan 13 2021, 10:06 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)
kislinsk added a comment to T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12.

Pushed new branch bugfix/T28151-FixVTKOnMacOSXCode12.

Jan 13 2021, 9:45 AM · Noteworthy, MITK (v2021.02)

Jan 12 2021

gtbuzz updated the task description for T28152: Question about source code and executable example app.
Jan 12 2021, 5:17 PM
gtbuzz created T28152: Question about source code and executable example app.
Jan 12 2021, 5:16 PM

Jan 11 2021

kislinsk triaged T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12 as Unbreak Now! priority.
Jan 11 2021, 11:18 PM · Noteworthy, MITK (v2021.02)
kislinsk closed T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start , a subtask of T27196: Rewrite packaging of MITK, as Resolved.
Jan 11 2021, 11:12 PM · MITK (v2024.06), Cleared
kislinsk closed T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start as Resolved.
Jan 11 2021, 11:12 PM · MITK (v2021.02)
kislinsk added a comment to T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .

Deleted branch bugfix/T27717-FixMacOSInstallerOpenApp.

Jan 11 2021, 11:12 PM · MITK (v2021.02)
kislinsk committed rMITKff9ca2f439c0: Fix num of chars in strncmp() (authored by kislinsk).
Fix num of chars in strncmp()
Jan 11 2021, 11:12 PM
kislinsk committed rMITK35cc4be67bda: Merge branch 'bugfix/T27717-FixMacOSInstallerOpenApp' into develop (authored by kislinsk).
Merge branch 'bugfix/T27717-FixMacOSInstallerOpenApp' into develop
Jan 11 2021, 11:12 PM
kislinsk added a comment to T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .

Pushed new branch bugfix/T27717-FixMacOSInstallerOpenApp.

Jan 11 2021, 11:11 PM · MITK (v2021.02)
kislinsk added a comment to T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .

It works when any argument is passed to the workbench via the open command, e.g., open MitkWorkbench.app --args --BlueBerry.newInstance. My first guess that the additions in rMITKf54a83e2 cannot handle 0 arguments when the implicit -psn argument is sneaked into argv by macOS.

Jan 11 2021, 9:25 PM · MITK (v2021.02)
kislinsk claimed T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .
Jan 11 2021, 8:56 PM · MITK (v2021.02)
floca triaged T28150: [RT] Refactor RT Dose reader as Normal priority.
Jan 11 2021, 7:19 PM · MITK
floca added a comment to T27689: RTDose image can not be serialized and workbench crashes upon loading.

Ok. Found the problem. Should now be fixed with the new diff. At least it works on my PC now with the test files.

Jan 11 2021, 7:12 PM · Request for Discussion, MITK
kislinsk closed T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore as Resolved.

Was removed in rMITK66bb0d67 and forgotten to get restored in rMITK02a46548.

Jan 11 2021, 3:58 PM · MITK (v2021.02)
kislinsk added a comment to T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Deleted branch bugfix/T28137-FixMissingContextMenuEntries.

Jan 11 2021, 3:57 PM · MITK (v2021.02)
kislinsk committed rMITK1aa2efd2c474: Add missing context menu extension point line (authored by kislinsk).
Add missing context menu extension point line
Jan 11 2021, 3:57 PM
kislinsk committed rMITK2e864760744f: Merge branch 'bugfix/T28137-FixMissingContextMenuEntries' into develop (authored by kislinsk).
Merge branch 'bugfix/T28137-FixMissingContextMenuEntries' into develop
Jan 11 2021, 3:57 PM
kislinsk added a comment to T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Pushed new branch bugfix/T28137-FixMissingContextMenuEntries.

Jan 11 2021, 3:55 PM · MITK (v2021.02)
kislinsk added a comment to T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Thanks @kalali, nice find and hint. A sneaky line is missing in DataManager's plugin.xml: <extension-point id="contextMenuActions" name="Context menu actions"/>.

Jan 11 2021, 3:51 PM · MITK (v2021.02)
kislinsk claimed T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.
Jan 11 2021, 3:39 PM · MITK (v2021.02)
kislinsk raised the priority of T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore from High to Unbreak Now!.
Jan 11 2021, 12:08 PM · MITK (v2021.02)
kompan lowered the priority of T27153: Fit CRMO2-model to mean value of ROI from Normal to Low.
Jan 11 2021, 10:10 AM · Restricted Project

Jan 9 2021

floca triaged T28148: Fix/Refactor ContourElement as Unbreak Now! priority.
Jan 9 2021, 4:52 PM · MITK (v2021.02)
floca added a revision to T26975: 2D Fast Marching for 4D data intermediate state displays segmentation in other timesteps: Unknown Object (Differential Revision).
Jan 9 2021, 1:27 PM · Missing Info, MITK (v2021.02)

Jan 5 2021

floca triaged T28146: Rework how SegTool2D should add contour markers as Low priority.
Jan 5 2021, 5:06 PM · MITK (v2024.06)
floca triaged T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures. as Normal priority.
Jan 5 2021, 4:56 PM · MITK (v2022.10)
floca created T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures..
Jan 5 2021, 4:55 PM · MITK (v2022.10)
floca triaged T28144: CorrectorTool does not properly handle unlocked lables of LabelSet Images as Normal priority.
Jan 5 2021, 4:41 PM · Request for Discussion, MITK (v2021.10)
floca added a comment to T26975: 2D Fast Marching for 4D data intermediate state displays segmentation in other timesteps.

Will be fixed (is fixed already) by the rework done in T28118.

Jan 5 2021, 4:30 PM · Missing Info, MITK (v2021.02)
floca added a revision to T27800: [Segmentation] Live Wire crashes with 4D image and static segmentation: Restricted Differential Revision.
Jan 5 2021, 11:01 AM · MITK (v2021.02)
floca added a revision to T28128: ContourModels are not correctly rendered on time steps > 0: Restricted Differential Revision.
Jan 5 2021, 11:01 AM · MITK
floca added a revision to T28129: Contour interactor do not handle time steps > 0 correctly and do not support time geometries correctly: Restricted Differential Revision.
Jan 5 2021, 11:01 AM · MITK

Jan 4 2021

schellem closed T28143: PAI Absorption spectra correction as Resolved.
Jan 4 2021, 9:59 PM · Photoacoustics, IMSY
schellem added a comment to T28143: PAI Absorption spectra correction.

Pushed new branch T28143-AbsSpectraCorrection.

Jan 4 2021, 9:57 PM · Photoacoustics, IMSY
schellem triaged T28143: PAI Absorption spectra correction as Normal priority.
Jan 4 2021, 9:51 PM · Photoacoustics, IMSY
thomass added a comment to T27689: RTDose image can not be serialized and workbench crashes upon loading.

The scene is created successfully if following (deprecated) properties are disabled in mitkDICOMImageBlockDescriptor.cpp:

Jan 4 2021, 5:10 PM · Request for Discussion, MITK
kalali triaged T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation as Normal priority.
Jan 4 2021, 12:29 PM · MITK (v2022.04), Breaking Change
kalali renamed T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem from [Segmentation] Multilable label name dialoge on label creation is a UX problem to [Segmentation] Multilabel label name dialoge on label creation is a UX problem.
Jan 4 2021, 12:21 PM · MITK (v2022.04), Cleared
kalali added a comment to T28118: Refactoring of SegTool2D.

Regarding the selection, I think you are rigt and there should ultimatly be no difference. But for the current strive for getting things cleaned up and in shape, it is of lower priority. I am happy, if we get through with the fundamental rework and time consistency stuff for this release.

Jan 4 2021, 12:07 PM · MITK (v2021.02)
floca added a comment to T28118: Refactoring of SegTool2D.

Looking through the checklists I found that the 2D tools of the segmentation view are different than the 2D tools of the Multilabel segmentation (one more: Fast Marching is missing).

What do you mean with different. Different in there behavior or a different selection of tools.

Jan 4 2021, 11:45 AM · MITK (v2021.02)

Jan 3 2021

kalali triaged T28140: [MultiLabel Segmentation] Default parameter (unsigned int layer = 0) is unnecessary and causes problems as Normal priority.
Jan 3 2021, 4:04 PM · MITK (v2024.06)
kalali triaged T28139: [LabelSetImage] Ambigious meaning of "layer" in LabelSetImage as Normal priority.
Jan 3 2021, 3:27 PM · MITK (v2023.12), Request for Discussion

Jan 2 2021

kalali renamed T28138: [MultiLabel Segmentation] Add tests for the LabelSetImage from [MultiLabel Segmentation] Add tests for the Label Set Image to [MultiLabel Segmentation] Add tests for the LabelSetImage.
Jan 2 2021, 9:19 PM · MITK (v2022.10)
kalali triaged T28138: [MultiLabel Segmentation] Add tests for the LabelSetImage as Normal priority.
Jan 2 2021, 5:48 PM · MITK (v2022.10)
kalali placed T28132: Extend "Checkliste MultiLabel Segmentierung – Interpolation" up for grabs.
Jan 2 2021, 4:31 PM · MITK (v2022.04)
kalali added a comment to T28136: Extend "Checkliste MultiLabel Segmentierung – Optionen".

There are some issues / open questions regarding the MultiLabel Segmentation options:
T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary", T27712: Preference "Show as volume rendering" does not display segmentation volume in 4-window view, T27498#216892, T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Jan 2 2021, 4:27 PM · MITK (v2022.04)