Is your statement also valid for 5e-5? Beause 1e-5 would not be enough in that case.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 18 2021
Deleted branch bugfix/T28164-CopyrightDate.
Pushed new branch bugfix/T28164-CopyrightDate.
Thanks for looking into this issue as well. :-) I think 1e-5 is okay. We/you already introduced NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION not long ago since we had similar issues and 1e-5 should still be conservative enough for the purpose of geometries.
Jan 17 2021
The problem seems to be that DCMQI rounds the the orientation matrix values at the 5th decimal place when storing to DCM Seg.
Pushed new branch feature/T28118-Refactor_SegTool2D_and_derived_classes.
Jan 16 2021
Jan 15 2021
I understand. :-) Just wanted to give you more options to think about as it is probably only a temporal solution. Sooner or later (currently read "later"), our minimum version requirements won't match again with the OS-provided Qt version. So we cannot run away from it forever I guess. :D
yes exactly, the problem with the scripted version, ist still, that it is necessary to provide credentials. That was fine, as long we were the only ones creating the containers.
The version of @nolden downloading the packages in ubuntu allows others to just build the container, without having to provide credentials at all.
Thank. New command-line interface looks nice, but the challenge is where to put the credentials, especially if you want to put the script open source like in the Kaapana dockerfiles.
Jan 14 2021
As it already works (?) and we will stay at least another year with Qt 5 we can do this. But in general, do you know of the new Qt Installer Framework with command-line interface? It's much easier now to install Qt with a single command and there are a few possibilities to provide credentials if that's an issue. See here for examples: https://phabricator.mitk.org/T27960#214043
Deleted branch feature/T28155-MakeQtLogMessagesOptional.
Pushed new branch feature/T28155-MakeQtLogMessagesOptional.
Jan 13 2021
Since we need to patch VTK anyway, I took the opportunity to upgrade from VTK 9.0.0 to 9.0.1.
Deleted branch bugfix/T28151-FixVTKOnMacOSXCode12.
Oh I forgot to mention: the segmentation is saved as dicom-seg.
Pushed new branch bugfix/T28151-FixVTKOnMacOSXCode12.
Jan 12 2021
Jan 11 2021
Deleted branch bugfix/T27717-FixMacOSInstallerOpenApp.
Pushed new branch bugfix/T27717-FixMacOSInstallerOpenApp.
It works when any argument is passed to the workbench via the open command, e.g., open MitkWorkbench.app --args --BlueBerry.newInstance. My first guess that the additions in rMITKf54a83e2 cannot handle 0 arguments when the implicit -psn argument is sneaked into argv by macOS.
Ok. Found the problem. Should now be fixed with the new diff. At least it works on my PC now with the test files.
Was removed in rMITK66bb0d67 and forgotten to get restored in rMITK02a46548.
Deleted branch bugfix/T28137-FixMissingContextMenuEntries.
Pushed new branch bugfix/T28137-FixMissingContextMenuEntries.
Thanks @kalali, nice find and hint. A sneaky line is missing in DataManager's plugin.xml: <extension-point id="contextMenuActions" name="Context menu actions"/>.
Jan 9 2021
Jan 5 2021
Will be fixed (is fixed already) by the rework done in T28118.
Jan 4 2021
Pushed new branch T28143-AbsSpectraCorrection.
The scene is created successfully if following (deprecated) properties are disabled in mitkDICOMImageBlockDescriptor.cpp:
In T28118#216941, @floca wrote:Regarding the selection, I think you are rigt and there should ultimatly be no difference. But for the current strive for getting things cleaned up and in shape, it is of lower priority. I am happy, if we get through with the fundamental rework and time consistency stuff for this release.
In T28118#216794, @kalali wrote:Looking through the checklists I found that the 2D tools of the segmentation view are different than the 2D tools of the Multilabel segmentation (one more: Fast Marching is missing).
What do you mean with different. Different in there behavior or a different selection of tools.
Jan 3 2021
Jan 2 2021
There are some issues / open questions regarding the MultiLabel Segmentation options:
T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary", T27712: Preference "Show as volume rendering" does not display segmentation volume in 4-window view, T27498#216892, T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.