there is a DerivePointerAlignment option which basically unifies it on a file by file basis, in case there is no agreement. But I agree to Ralf with using the "left" style and put it next to the type

That is a first shorted list. Other apps and plugins are already ruled out (e.g. due to Vigra dependency). We no shuold assess which of those can really stay in the main mitk repo.

It's a feature.

One way of documenting the applied fitting pipeline in agreement with the lexicon is to export an XML file which describes the pipeline as suggested int the lexicon publication ("A community-endorsed open-source lexicon for contrast-agent based perfusion MRI (CAPLEX): A consensus guidelines report from the ISMRM Open Science Initiative for Perfusion Imaging (OSIPI)".)
In this task it is first collected if all relevant information of the fitting configuration can be extracted in order to build such an XML file.

Didn't find any "critical" style issues. It is a single commit, right? rMITKc8283d2c7c3f: Smaller Bugfixes
You may want to search and replace "[Bb]oarder" with "[Bb]order", though, as I guess you intended to refer to "Rand" instead of "Untermieter". :)

@gaoh gave green light in Slack to delete the branch during a housekeeping effort.

Deleted branch from rMITK MITK: feature/T27189-RestApiForDataStorage.

Deleted branch from rMITK MITK: bugfix/T28544-difference-RT-data-loading.

I reeopened because I would like to llok into the feature branch at least and see what might be of interest:

Hi there! 🙂

Hi there! 🙂

Hi there! 🙂

Hi there! 🙂

@floca wants to resolve these crashes differently. Handing over...

Request for Discussion:

• Notify tools about selected label changes or label property changes like color?
• Show preview as active or inactive label (with or without border)?

grow cut (as all preview tools) does not generate any undo point right now. What you witness is the undo of your seed painting up front.

I am not sure I would put it a member function. This can be done without the need of accessing any internals.

We should discuss if it is still worth it to get it back online after all this time and with the new tools.

We should discuss if we realy try to get region growing back online with all the other tools ...

I pushed my local branch to remote for others to continue working on it. The related differential {D594} has been updated and will remain open.

Pushed new branch to rMITK MITK: feature/T26959-Show-outline-of-labelsetimage.

Not sure if we need a CMake option for it, as long as it works in all scenarios. :)

Checked to add

It was discussed and agreed upon, that it does not make sense to adapt this behavior in the Data Manager. If we want a clean implementation of the "set focus on planar figure"-feature, it should belong in the corresponding view (i.e. Measurement) instead of the Data Manager.
As this is not currently a specifically requested feature, this task will be closed.

@a178n will close this task and create a new dedicated task.

It was discussed that the old reader information is not of any value and shouldn't be written into the files.

if I not mistaken this is something different, because scene serialization uses as different mechanism (it always stores all props of data and nodes; no matter what). Property persistence service is only relevant for reading or writing data to "directly" to files.

In T29504#246386, @kalali wrote:

This is not solved with {D795}, right? I can still see slicer->GetRenderer() in line 926, so the render window is still retrieved from the slice navigation controller, which requires the getter to be available in the slice navigation controller.

This is not solved with {D795}, right? I can still see slicer->GetRenderer() in line 926, so the render window is still retrieved from the slice navigation controller, which requires the getter to be available in the slice navigation controller.

Wait, maybe we are talking about the same thing. In mitkSegmentationTaskListIO.cpp:181-184 the written properties are used in case everything is read from a scene file. Then, the original input location is read as search path for relative data that isn't contained within the scene file. Which I know is not a perfect situation in the first place but better than nothing in particular for users using the save button to checkpoint their progress.

You're right. I already suspected it to be different things but better safe than sorry. :D

In T29521#246322, @kislinsk wrote:

Input location is used by the SegmentationTaskList and SegmentationTaskListIO.

Input location is used by the SegmentationTaskList and SegmentationTaskListIO.

After looking at the checklist again, I don't think there is a need to change anything. The checklist specifically only speaks of selecting the line-node once. When following the checklist instructions, everything should work as described.

This context and code artifacts referred in this issue seems obsolete or changes. The issue needs to be rephrased if not closed.

theoretically yes, but I guess it is not relevant. Since we now use the tasklist feature. And before that, I used the described workaround. So this is not needed anymore.

Still does not work for Del. For a sequence like CTRL+L CTRL+D it works.

@gaoh is this still an open issue?

is the discussion realy over now? I think this is also more an meta task, concrete actions like removing binary tag and such should be sub tasks.
@kislinsk Could you make sub tasks out of your discussion points. Thanks.

Updated task description since the class has been refactored. However, the issue still exists, but now it is - as far as I can see - only abut getting the visibility etc. which can easily be refactored.

A pop up appears with whatever error message was thrown from OtsuTool3D::DoUpdatePreview.

I uploaded a fix in D783. Let's see if this will solve the issue also for Ubuntu.

I tested this on Windows with 4974a335ada8a85d7fba8d313e2efc20acc84b48, which was the latest develop I had, since I recently merged something into develop and couldn't reproduce the error.
Used StdMultiWidget, no other plugins open, no data loaded, only the widget planes available in the data storage.
I tested this with the commit given in the task description and couldn't reproduce the error there as well.

After meeting it is decided that:

1. Label names/classes & their pixel values that are hardcoded in the python codebase will be parsed directly and shown in MITK for 2023.04 release (Ref: https://github.com/wasserth/TotalSegmentator/blob/master/totalsegmentator/map_to_binary.py)
2. Certain subtasks which need multiple nifti file agglomeration (eg. "Body") will not be included in the 2023.04 release.