Closing these tasks because of inactivity and completely changed way of building MITK.

Closing these tasks because of inactivity and completely changed way of building MITK.

Closing these tasks because of inactivity and completely changed way of building MITK.

Was never merged into master, what shall we do, @franza ?

Close as resolved because of last activity was three years ago.

Yeah, we did... to be honest, I don't know if it is merged yet. @kausch can you please check this?

@kausch @kleina you resolved this task, right?
If not done already, please merge to the master.

GCC compiles also fine

Why are there now 2 actions? Did we miss some side effects with the base renderer?

Okay, so, basically not the 2018.04 branch.

For illustration:

I just looked into this again and provided a merge request (https://github.com/MITK/MITK/pull/233). This also merges into the current release/2018-xx branch

It affects every branch that containes the ModelFit module and tries to build it with VS 2017 >=15.9.11

all functions implemented, just need to test compiling with GCC

Pushed new branch T25832-migrateModelFit2019-05.2.

Pushed new branch T25927-fix-uid-generation.

Pushed new branch [[/source/mitk/browse/T25831-_new_image_statistics_plugin%255D_improve_documentation/ | T25831-_new_image_statistics_plugin]_improve_documentation]].

I'm totally in for Boost 1.69+. The interesting question for me is, does this issue affect the 2018.04 branch as well or only the master branch?

At least the statistics table should not show the old values but instead show maybe no values and display a warning for wrong placed mask.

the checklist may be of help. It's here: E130-Data/Release\Checklisten\MITK Workbench Release/Checkliste NEW Image Statistics.docx

Pushed new branch T23624-ConnectionToEpiphanFrameGrabberViaOpenCVIsBuggy.

Result of the discussion:
At the current state we voted against moving to core.

Result of the discussion:

Pushed new branch T26334-Include_distortion_correction_filter.

I guess we could reasonably choose the selected/active 2d window but that might be sometimes different to the users working plane as it is simply defined by the window that was clicked the last time.

Pushed new branch T25522-MasterIntegrationBranch-13-05-2019.

Pushed new branch T25832-migrateModelFit2019-05.

Pushed new branch T26324-optimizeZoomingOption.

Pushed new branch T25871-fix-unsigned-int-comparison-warning.

Pushed new branch T19683-ShowOnlySelectedNodesCrosshairVisibilty-baseRenderer.

I think it would be nice but is no show stopper, because we could, as a work arround, use a chartline that only contains the highlited point(s).

T26323 is needed to highlight the current point

Feedback from @floca:

1. Der Titel der X-Achse und die Achsenbeschriftungen liegen über einander und sind deshalb nicht zu lesen.
   • is already fixed with T26274, but not yet in this branch
2. Fixed Scaling (für X und Y) funktioniert nicht richtig.
   • true
3. In der Methode OnFullPlotClicked ist ein Task (T26222) referenziert, den es gar nicht gibt. Vielleicht ist das aber jetzt auch schon durch meinen Fix erledigt.
   • code was deleted, works fine
4. Kritische Regression gegenüber dem alten Widget: Im Moment flackert es immer sobald man die Achsen anpasst oder (noch schlimmer) wenn man einen neuen Punkt ansteuert. Dass ist insbesondere beim explorieren von Daten nicht gut, da es leicht laggt und sehr irritiert.
   • opened T26320
5. Kritische Regression gegenüber dem alten Widget: Im Moment aktualisiert sich der Plot erst wenn man die Maus wieder loslässt (wenn man im SliceNavigator oder direkt im Bild neue Punkte anfährt). Früher wurde automatisch immer gleich mit aktualisiert, es wäre sehr gut, wenn das wieder so wäre. Entsprechend müsste der Chart neugemalt werden, jedesmal wenn die Positionsänderung propagiert wird. Im Moment sieht es so aus, als würde gewartet, bis der Main-Thread idelt.
   • can't reproduce. The update takes a while (probably because of new painting of the widget), but has nothing to do with mouse click release. @floca we should look again if T26320 is fixed.

Pushed new branch T25871-chartTypePie.

This would be favorable. However, if we deprecate the QmitkPlotDialog/QmitkPlotWidget/QtHistogram classes, this leads to warnings (and errors because of warnings-as-errors).
@kislinsk do you see a possibility?

@hentsch Is the one time step segmentation applied to all time steps? What is the expected behavior?

This task is not valid anymore.

1. The level window slider has an option to modify the level window of a (list of) selected node(s) (see T25483)
2. The BlackSwan project uses the PACS mode where the level window can be changed via mouse buttons
3. The render window manager now uses the concept of data storage inspectors and thus behaves differently than here

Pushed new branch T26060-AddBandpass.

@hentsch / @kislinsk : Shouldn't we already set QmitkPlotDialog/QmitkPlotWidget/QtHistogram to deprecated then. To give us sooner then later the posibilite to realy remove the code from the codebase. If I see it correctly, that would also gives us the possibility to reomive Qwt as a third party package from MITK. What do you think?

Pushed new branch T26311-temporaryFix.

Reopened to revert the latest changed due to errors.

It can be integrated and used in a plugin when the frmgrab.dll and frmgrab.lib files were in the same folder (\Epiphan\epiphan_sdk-3.30.3.0007\epiphan\frmgrab\lib\win\x64)

Would be good to leave the baseRenderer as an argument so that you can set the visibility of a specific node in a predefined base renderer (e.g. by using the RenderWindowManager). This is useful when using the new MultiWidget(Editor).

Pushed new branch T19683-ShowOnlySelectedNodesCrosshairVisibility.

I have concerns with the latest commit. See comments there. You can come by and ask if you have any questions.

No longer relevant

Solution: GetStatisticsForTimeStep method now returns an empty StatisticsObject if no mask is provided for this time step. Thus, histogram and table are empty for those time steps.
Discussion: 1. 4D image + 3D segmentation

2. 4D image (5 time steps) + 4D segmentation (1 time step)

@hentsch Is the one time step segmentation applied to all time steps? What is the expected behavior?

Pushed new branch T26029-4DImageAnd4DSegmentation.

@kislinsk Stefan, you said you reworked this pragma for MITK? Does it implie any changes for 3rd party projects?