Page MenuHomePhabricator
Feed All Stories

Mar 2 2021

kislinsk closed T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services, a subtask of T27196: Rewrite packaging of MITK, as Resolved.
Mar 2 2021, 11:10 AM · MITK (v2024.06), Cleared
kislinsk closed T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services, a subtask of T23301: XNAT improvements, as Resolved.
Mar 2 2021, 11:10 AM · Auto-closed, MITK
kislinsk closed T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services as Resolved.
Mar 2 2021, 11:10 AM · Restricted Project, CSI-HD, MITK
kislinsk added a revision to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..): Restricted Differential Revision.
Mar 2 2021, 10:57 AM · MITK
thomass added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

Since you also mentioned different editors: Not sure if this is also related but one of the terminal outputs of the testers was:

Mar 2 2021, 9:51 AM · MITK
kalali committed rMITK7014777eedae: Preserve color selection (authored by kalali).
Preserve color selection
Mar 2 2021, 9:11 AM
kalali committed rMITK372746b5a2ae: Initialize color member with red (authored by kalali).
Initialize color member with red
Mar 2 2021, 9:11 AM
kalali committed rMITK93758e9b6fe4: Correctly initialize the color selection dialog (authored by kalali).
Correctly initialize the color selection dialog
Mar 2 2021, 9:11 AM
kislinsk added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

I will go through the source tree and as a rule of thumb I will just add nullptr checks if the render window part is only used for rendering updates and add the OPEN strategy if more is done with the reference and there is not already a nullptr check.

Mar 2 2021, 8:49 AM · MITK
kislinsk claimed T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).
Mar 2 2021, 8:45 AM · MITK

Mar 1 2021

kislinsk renamed T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..) from [Docu] Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..) to Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).
Mar 1 2021, 8:57 PM · MITK
kislinsk added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

I tested it in debug mode and the fix is pretty simple. The crashes occurs in lines like GetRenderWindowPart()->RequestUpdate() when GetRenderWindowPart() returns a nullptr. I guess there are quite a few unchecked lines like this in MITK.

Mar 1 2021, 8:57 PM · MITK
thomass updated the task description for T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).
Mar 1 2021, 5:38 PM · MITK
p212r added a member for MIC: m813r.
Mar 1 2021, 5:04 PM
s434n added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

I got the same result as kislinsk, the crash only occurs when the documentation is open and not in the background

Mar 1 2021, 4:07 PM · MITK
kislinsk added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

When I reproduced the issue with MatchPoint, it didn't happen when the documentation was in the background (i.e. the documentation is not the active editor). I guess this is a good starting point for debugging.

Mar 1 2021, 3:16 PM · MITK
thomass added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

With the modelfit inspector it most often crashed, if the user clicked on a datanode in the datastorage

Mar 1 2021, 3:07 PM · MITK
thomass updated the task description for T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).
Mar 1 2021, 3:02 PM · MITK
thomass renamed T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..) from [Docu] Crashes when using plugin with documentation opened to [Docu] Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).
Mar 1 2021, 2:49 PM · MITK
thomass triaged T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..) as High priority.
Mar 1 2021, 2:48 PM · MITK
holzwart added a member for Photoacoustics: p253n.
Mar 1 2021, 10:58 AM
holzwart added a member for IMSY: p253n.
Mar 1 2021, 10:57 AM
kislinsk edited the content of Code Guarantees.
Mar 1 2021, 10:39 AM
kislinsk edited the content of Code Guarantees.
Mar 1 2021, 10:29 AM
kislinsk renamed Code Guarantees from Code guarantees to Code Guarantees.
Mar 1 2021, 10:19 AM
kislinsk published a new version of Git Branching Model.
Mar 1 2021, 9:43 AM · MITK

Feb 26 2021

floca committed rOBSHYPPOPY7e2b0026d800: Extracted mpi4py into an optional_requirements.txt for now, (authored by floca).
Extracted mpi4py into an optional_requirements.txt for now,
Feb 26 2021, 2:38 PM
floca committed rOBSHYPPOPY8fcdb9d07f73: Made MPI an extra in the requirement specification because (authored by floca).
Made MPI an extra in the requirement specification because
Feb 26 2021, 12:27 PM
floca committed rOBSHYPPOPY3636699c3c1e: Removed unneeded dependency to MPIBlackboxFunction (authored by floca).
Removed unneeded dependency to MPIBlackboxFunction
Feb 26 2021, 12:27 PM

Feb 25 2021

k656s moved T28335: Landing Page container automatically get killed in every minute from Discussion to Resolved on the Kaapana (internal) board.
Feb 25 2021, 2:59 PM · Request for Discussion, Kaapana (internal)
k656s closed T28335: Landing Page container automatically get killed in every minute as Resolved.

Resolved, error was in the docker container

Feb 25 2021, 2:59 PM · Request for Discussion, Kaapana (internal)
schererj moved T28229: build getting failed after integration of tfda module from kaapana to Kaapana - Internal from In Progress to Resolved on the Kaapana (internal) board.
Feb 25 2021, 11:53 AM · Kaapana (internal)
s669m added a comment to T28335: Landing Page container automatically get killed in every minute .

Issue in landing page tfda, base pods .

Feb 25 2021, 10:15 AM · Request for Discussion, Kaapana (internal)
k656s added a comment to T28335: Landing Page container automatically get killed in every minute .

Sounds strange to me.
Is the error still there, if yes can you send me the instance, where this is happening? :)

Feb 25 2021, 10:09 AM · Request for Discussion, Kaapana (internal)
s669m raised the priority of T28335: Landing Page container automatically get killed in every minute from Normal to High.
Feb 25 2021, 9:32 AM · Request for Discussion, Kaapana (internal)

Feb 24 2021

norajitr added a comment to T28232: Shapemodels.

I like the idea of open sourcing the code and making models available as well. If we can roughly clarify how the workload/hurdles would look like in reality, I can also imagine to back the process. Licensing and publication of trained models arises more often lately, thus any solution here can probably also be fruitful for similar endeavors.

Feb 24 2021, 4:11 PM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
gaoh added a comment to T27968: CTP gets stuck on large import.

I cannot reproduce the error. When sending the data to an instance the data gets imported. When debugging CTP locally there also seems to be no problem. For me also it looks like the problem is not directly in the CTP but in the java library (dcm4che). Did the files got triggered/send to airflow? Did they get stuck in a quarantine folder of the CTP, and if so in which?

Feb 24 2021, 2:09 PM · Kaapana (internal)
floca committed rOBSHYPPOPY7961f8745789: Fixed usage of potentially wrong MPI communicator (was still hard coded) (authored by floca).
Fixed usage of potentially wrong MPI communicator (was still hard coded)
Feb 24 2021, 12:41 PM
gaoh added a comment to T27968: CTP gets stuck on large import.

This is one of my model DICOMs (not 100% sure if this will reproduce it).
If not I can try to make bigger parts.

Download-link from my instance

Just a remark: The download link does not work for me. I get forbidden access. This is also the case, even if I am logged into the platform. But since there is only one folder in minio I also found it without the link:)

Feb 24 2021, 12:26 PM · Kaapana (internal)
floca committed rOBSHYPPOPYd6ec11f65d51: Fleshed out the draft a bit more. (authored by floca).
Fleshed out the draft a bit more.
Feb 24 2021, 12:18 PM
s669m triaged T28335: Landing Page container automatically get killed in every minute as Normal priority.
Feb 24 2021, 12:17 PM · Request for Discussion, Kaapana (internal)
kislinsk moved T26399: Workbench crash on simple tree model update from MITK Meeting to Backlog on the Request for Discussion board.
Feb 24 2021, 11:26 AM · MITK, Request for Discussion
kislinsk lowered the priority of T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary" from Normal to Low.

We are going to rewrite the 2-d LabelSetImage mapper and write a 3-d LabelSetImage mapper this year, where this will be addressed. We should at least clean up the duality of the contour properties (binary vs. labelset.contour). We should probably allow to show the contour without any filling and we should clean up the coupling between contours and active label.

Feb 24 2021, 11:18 AM · MITK (v2024.06), Checklist, Request for Discussion
schererj added a comment to T27968: CTP gets stuck on large import.

This is one of my model DICOMs (not 100% sure if this will reproduce it).
If not I can try to make bigger parts.

Feb 24 2021, 10:21 AM · Kaapana (internal)
gaoh added a comment to T27968: CTP gets stuck on large import.

Can you send me a dataset to reproduce it? I could try to debug CTP, but it looks like it is not even a problem in CTP but in org.dcm4chri

Feb 24 2021, 9:47 AM · Kaapana (internal)
kalali moved T27713: [Segmentation] Disable "New" button when no image is selected from Backlog to MITK Meeting on the Request for Discussion board.
Feb 24 2021, 9:42 AM · MITK (v2021.10), Request for Discussion
kalali added a project to T27713: [Segmentation] Disable "New" button when no image is selected: Request for Discussion.
Feb 24 2021, 9:42 AM · MITK (v2021.10), Request for Discussion
kalali moved T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary" from Backlog to MITK Meeting on the Request for Discussion board.
Feb 24 2021, 9:42 AM · MITK (v2024.06), Checklist, Request for Discussion
floca reopened T28333: Allow auto wrapping of blackbox for MPI as "Open".
Feb 24 2021, 12:04 AM · Hyppopy
floca added a comment to T28333: Allow auto wrapping of blackbox for MPI.

@kleina can ou review the branch somewhen if the change is OK?

Feb 24 2021, 12:03 AM · Hyppopy
floca closed T28333: Allow auto wrapping of blackbox for MPI as Resolved by committing rOBSHYPPOPY75cdf9ddd63f: Fixed T28333.
Feb 24 2021, 12:03 AM · Hyppopy
floca committed rOBSHYPPOPY75cdf9ddd63f: Fixed T28333 (authored by floca).
Fixed T28333
Feb 24 2021, 12:03 AM
floca committed rOBSHYPPOPY28d5ce61eb54: First draft (not functioning) of how the cascaded support could look like. (authored by floca).
First draft (not functioning) of how the cascaded support could look like.
Feb 24 2021, 12:03 AM

Feb 23 2021

floca triaged T28333: Allow auto wrapping of blackbox for MPI as Normal priority.
Feb 23 2021, 11:48 PM · Hyppopy
floca triaged T28332: Support cascaded MPI processing as Normal priority.
Feb 23 2021, 11:41 PM · Hyppopy
floca added a comment to rOBSHYPPOPYba147fa770ad: Add possibility to pass comm to MPI classes..

I just saw that the default option is already implemented. Then I would just remove it in the playground or explain that both ways are possible. Because otherwise people might think that they always have to do it.

Feb 23 2021, 11:39 PM
floca raised a concern with rOBSHYPPOPYba147fa770ad: Add possibility to pass comm to MPI classes..
Feb 23 2021, 9:30 PM
floca added a comment to rOBSHYPPOPYba147fa770ad: Add possibility to pass comm to MPI classes..

@kleina Please check my comments and if nothing stands against it: 1) spawn a task to cover it. 2) cover it 😉 .

Feb 23 2021, 9:30 PM
schererj added a comment to T27968: CTP gets stuck on large import.

Another issue I have regularly:

Feb 23 2021, 4:21 PM · Kaapana (internal)
gaoh placed T28207: MITK DicomBrowser q/r Retrieve part crash up for grabs.
Feb 23 2021, 2:33 PM · MITK, Checklist
k656s added a member for Kaapana (internal): t543a.
Feb 23 2021, 2:30 PM
schererj added a comment to T27968: CTP gets stuck on large import.

This could be an option.
We should still try to solve the multiple issues with CTP.
I'm not sure if there is a single source of failure - but I have a lot of trouble with it.

Feb 23 2021, 2:10 PM · Kaapana (internal)
gaoh added a comment to T28207: MITK DicomBrowser q/r Retrieve part crash.

Get an Openstack instance (e.g. Ubuntu 20.04 DKFZ image,...)

Feb 23 2021, 11:16 AM · MITK, Checklist
kislinsk merged task T28327: Upgrading ITK version 4.13.3 to latest version of ITK 5.1.2 into T27437: Migrate MITK to use ITK 5.x .
Feb 23 2021, 10:59 AM · MITK
kislinsk merged T28327: Upgrading ITK version 4.13.3 to latest version of ITK 5.1.2 into T27437: Migrate MITK to use ITK 5.x .
Feb 23 2021, 10:59 AM · MITK-ProjectTemplate, MITK (v2022.04)
al-sabr triaged T28327: Upgrading ITK version 4.13.3 to latest version of ITK 5.1.2 as High priority.
Feb 23 2021, 8:25 AM · MITK

Feb 22 2021

floca added a revision to T28225: [Segmentation] SegTool2D::WritePreviewOnWorkingImage does not work correctly: Unknown Object (Differential Revision).
Feb 22 2021, 7:50 PM · MITK
floca reopened T28225: [Segmentation] SegTool2D::WritePreviewOnWorkingImage does not work correctly as "Open".

It was by accident auto closed by a typo in the task ID of commit mentioned above. rMITK9d7992a7815d does fix T28255.

Feb 22 2021, 6:07 PM · MITK
floca committed rRTTB8b772501fd3f: Fixed install rules after build system rework (authored by floca).
Fixed install rules after build system rework
Feb 22 2021, 3:54 PM
gaoh added a comment to T27968: CTP gets stuck on large import.

Can you reproduce the error? If so, we can do something like: https://stackoverflow.com/questions/12096403/java-shutting-down-on-out-of-memory-error

Feb 22 2021, 12:27 PM · Kaapana (internal)

Feb 20 2021

floca placed T28206: [Image Statistics] Renaming segmentation or planar figure based ROI nodes breaks histogram up for grabs.
Feb 20 2021, 2:03 PM · MITK (v2024.06)
floca committed rRTTBfa5f31edf40a: Fixed new building system for applications (authored by floca).
Fixed new building system for applications
Feb 20 2021, 1:56 PM
floca committed rRTTB288c6747a0da: Adapted helax io for new build system (authored by floca).
Adapted helax io for new build system
Feb 20 2021, 1:56 PM
floca committed rRTTB09fa00a93b72: Fixed exporting of symbols (now all tests also compile with shared libs) (authored by floca).
Fixed exporting of symbols (now all tests also compile with shared libs)
Feb 20 2021, 1:56 PM
floca committed rRTTB5fa06497b4e3: Removed deprecated test (indicie tests have moved to own test module) (authored by floca).
Removed deprecated test (indicie tests have moved to own test module)
Feb 20 2021, 1:56 PM
floca committed rRTTB9b95831375bf: Finished rework of build system for modules and tests (authored by floca).
Finished rework of build system for modules and tests
Feb 20 2021, 1:56 PM

Feb 19 2021

nolden triaged T28323: Workbench aborts if passed an invalid command line option as Low priority.
Feb 19 2021, 5:50 PM · Auto-closed, MITK
nolden added a comment to T28282: Workbench does not start when building with Qt 5.15 on Linux.

Interesting catch. There is no call to regex_match in our code. If I understand it correctly the stack object is just created to check if an exception happens during construction, but maybe this is just another variant of the issue described for the library. A possible workaround could be to explicitly create and destroy the regex objects in our code, with explicit exception catching and re-throwing.

Feb 19 2021, 5:13 PM · MITK
s434n triaged T28322: [Screenshot Maker] 3D Multiplanar screenshot does not return view to initial position as Low priority.
Feb 19 2021, 1:59 PM · MITK
s434n triaged T28321: [Measurement] Control points can not be moved twice without moving the mouse away as Low priority.
Feb 19 2021, 1:44 PM · Auto-closed, MITK
gaoh closed Restricted Maniphest Task, a subtask of T28302: MITK CI jobs for Kaapana, as Resolved.
Feb 19 2021, 11:53 AM · CI, MITK
s669m added a member for MIC: o776l.
Feb 19 2021, 11:52 AM
schererj added a comment to T28302: MITK CI jobs for Kaapana.

Okay, nice. Last question: You currently have both a PhenotypingRelease and a ClassificationCmdApps configuration. The apps of the latter one are also included in the former configuration. Is it fine to just go for PhenotypingRelease then at the cost of a little larger tarball as also the workbench application is included? @schererj

Feb 19 2021, 10:46 AM · CI, MITK
nolden added a comment to T28232: Shapemodels.

@norajitr maybe a bit more background on the ticket for you:

Feb 19 2021, 10:39 AM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
s434n triaged T28320: [Segmentation] Region growing does not work if seed point is already inside a segmentation as Normal priority.
Feb 19 2021, 10:39 AM · MITK (v2022.04), Missing Info, Request for Discussion
floca added a comment to T28232: Shapemodels.

I think the points are wrong ordered. First we should clarify (management decission) that it should go into a release/open-source and if tobi has the time to backing the process.
If this is cleare, the technical assesement of what has to be done to have it in master and under CI/testing can be evaluated/quantified.

Feb 19 2021, 9:58 AM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
kislinsk added a comment to T28282: Workbench does not start when building with Qt 5.15 on Linux.

I didn't really look into this but it reminds me of something I stumbled over a few weeks ago. There's a bug in C++ 14 regex regarding temporary strings: https://cplusplus.github.io/LWG/issue2329

Feb 19 2021, 9:40 AM · MITK

Feb 18 2021

kislinsk closed T28314: Text not showed in Python console using Theme Light as Wontfix.

Thanks for reporting. We recently rewrote the Python integration in MITK. Its status is at ~80% and it will get merged as soon as we figured out the packaging for Python in MITK (branch feature/T27923-python-dev). The QtPython module was removed as we do not longer depend on CTK/PythonQt for the Python integration.

Feb 18 2021, 9:42 PM · MITK
kislinsk triaged T28311: MitkFlowBench Naming Issue as Normal priority.
Feb 18 2021, 9:36 PM · Auto-closed, MITK
kislinsk triaged T28282: Workbench does not start when building with Qt 5.15 on Linux as High priority.
Feb 18 2021, 9:35 PM · MITK
kislinsk triaged T28281: Review C++ warnings configuration as Normal priority.
Feb 18 2021, 9:33 PM · Auto-closed, Request for Discussion, MITK
kislinsk triaged T28279: [Interaction] Improve image cropper cross hair interaction as Normal priority.
Feb 18 2021, 9:33 PM · Auto-closed, MITK
kislinsk triaged T28232: Shapemodels as Wishlist priority.
Feb 18 2021, 9:32 PM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
kislinsk closed T28302: MITK CI jobs for Kaapana as Resolved.
Feb 18 2021, 9:29 PM · CI, MITK
kislinsk added a comment to T28302: MITK CI jobs for Kaapana.

I gave @schererj and @gaoh rights to start the Kaapana MITK build jobs and to read the configurations: https://ci.mitk.org/job/MITK/job/Kaapana/

Feb 18 2021, 9:28 PM · CI, MITK
kislinsk added a member for MITK: s434n.
Feb 18 2021, 6:34 PM
kalali edited projects for T27713: [Segmentation] Disable "New" button when no image is selected, added: MITK; removed MITK (v2021.02).

I looked into it and I have the impression that there is a lot of unnecessary complexity created in order to generate a valid UI state. The problem, as far as I can see, lies in the overuse of if-statements and having functions that have way to many responsibilities. This is a typical "clean code" task and I suggest to go through the whole QmitkSegmentationView.cpp file and apply some best practices of writing clean code.
But since it is not clear how much effort we want to put into it (thinking of T28142), it might be wise to not work on this right now but to use a general refactoring task (parent task) to fix the mentioned bug.
I advise also to have a look https://phabricator.mitk.org/file/data/7bghshzurxwupnipv3dl/PHID-FILE-n2hwm6xv2mil3ola47sq/QtStateMachineFramework.pdf.

Feb 18 2021, 4:18 PM · MITK (v2021.10), Request for Discussion
thomass added a member for MIC: s434n.
Feb 18 2021, 3:38 PM
isensee added a member for Deep Learning: l374d.
Feb 18 2021, 3:06 PM
kislinsk added a comment to T28302: MITK CI jobs for Kaapana.
Feb 18 2021, 2:34 PM · CI, MITK