Page MenuHomePhabricator
Feed All Stories

Mar 10 2021

kislinsk closed T25042: How to handle update informations in heterogeneous time geometries and out of bound situations as Wontfix.

Hi there! 🙂

Mar 10 2021, 9:01 AM · Moved to git.dkfz.de, MITK
kislinsk closed T25574: Remove ImageStatisticsCalculator::SetSecondaryMask as Wontfix.

Hi there! 🙂

Mar 10 2021, 9:01 AM · Auto-closed, Restricted Project, MITK
kislinsk closed T25574: Remove ImageStatisticsCalculator::SetSecondaryMask, a subtask of T25512: Restructure image statistics calculator, as Wontfix.
Mar 10 2021, 9:01 AM · Auto-closed, MITK
kislinsk closed T25416: How to create a new MITK Plugin - start confusing as Wontfix.

Hi there! 🙂

Mar 10 2021, 9:01 AM · Auto-closed, MITK
kislinsk closed T25421: Documentation build fails on Ubuntu 18.04 and 16.04 (different errors) as Wontfix.

Hi there! 🙂

Mar 10 2021, 9:01 AM · Auto-closed, MITK
kislinsk closed T25676: Add new icons to the tutorial as Wontfix.

Hi there! 🙂

Mar 10 2021, 9:01 AM · Auto-closed, MITK
kislinsk closed T25790: MaskGenerator should be abstract class as Wontfix.

Hi there! 🙂

Mar 10 2021, 9:01 AM · Auto-closed, MITK
kislinsk closed T25742: Python wrapping might find inconsistent versions for lib and interpreter as Wontfix.

Hi there! 🙂

Mar 10 2021, 9:01 AM · Auto-closed, MITK
kislinsk closed T25584: Workbench randomly crashes when applying colormaps as Wontfix.

Hi there! 🙂

Mar 10 2021, 9:01 AM · Auto-closed, Restricted Project, MITK
kislinsk closed T25811: Add unit test for AccessTwoImagesFixedDimensionByItk_n macro as Wontfix.

Hi there! 🙂

Mar 10 2021, 9:01 AM · Auto-closed, MITK
kislinsk closed T25898: [imageStatisticsCalculator] Statistics of Masked images are computed inefficiently, a subtask of T25512: Restructure image statistics calculator, as Wontfix.
Mar 10 2021, 9:01 AM · Auto-closed, MITK
kislinsk closed T25898: [imageStatisticsCalculator] Statistics of Masked images are computed inefficiently as Wontfix.

Hi there! 🙂

Mar 10 2021, 9:01 AM · Auto-closed, MITK
kislinsk closed T25974: add SetChartTypeForAllDataAndReload functionality as Wontfix.

Hi there! 🙂

Mar 10 2021, 9:01 AM · Auto-closed, MITK
kislinsk closed T25974: add SetChartTypeForAllDataAndReload functionality, a subtask of T25683: Chart Example Plugin, as Wontfix.
Mar 10 2021, 9:01 AM · MITK
a178n triaged T28354: Update MITK documentation on CMAKE build for plugins as Low priority.
Mar 10 2021, 8:19 AM · Next Milestone, MITK (v2021.10)

Mar 9 2021

kislinsk edited the content of Development.
Mar 9 2021, 10:08 PM · MITK

Mar 8 2021

floca committed rOBSHYPPOPY254adacd6164: Merge branch 'feature/T28333-MPI_blackbox_auto_wrapping' (authored by floca).
Merge branch 'feature/T28333-MPI_blackbox_auto_wrapping'
Mar 8 2021, 2:30 PM
s669m added a subtask for T28175: TFDA MVP v1: T28351: Trial Run with Kata Isolated Container.
Mar 8 2021, 10:46 AM · Restricted Project
s669m added a parent task for T28351: Trial Run with Kata Isolated Container: T28175: TFDA MVP v1.
Mar 8 2021, 10:46 AM · Restricted Project
s669m created T28351: Trial Run with Kata Isolated Container.
Mar 8 2021, 10:46 AM · Restricted Project
s669m updated the task description for T28350: Trial Run with Isolated Sandbox Container gVisor.
Mar 8 2021, 10:43 AM · Restricted Project
s669m added a subtask for T28175: TFDA MVP v1: T28350: Trial Run with Isolated Sandbox Container gVisor.
Mar 8 2021, 10:38 AM · Restricted Project
s669m added a parent task for T28350: Trial Run with Isolated Sandbox Container gVisor: T28175: TFDA MVP v1.
Mar 8 2021, 10:38 AM · Restricted Project
s669m triaged T28350: Trial Run with Isolated Sandbox Container gVisor as Normal priority.
Mar 8 2021, 10:37 AM · Restricted Project
kislinsk edited the content of 2020 Week 25 (Late June).
Mar 8 2021, 9:20 AM
kleina moved T25982: add all hp space modalities loguniform, ... from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26086: Fix hard coded paths from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26146: restructure gridsearch to be memory safe from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26227: Own documentation section for hyper parameter aspects from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26226: Different style for frequency definition in the parameter space definition (for grid search and alike) from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26096: Add groups to hyperparameter dict structure from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26241: VirtualFunction should get better name from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26240: File headers are "strange" from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:05 AM · Hyppopy
kleina moved T26242: Solvers exceptions due to missing hyper parameter configs should be more telling. from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:04 AM · Hyppopy
kleina moved T26243: Missing number of iterations is not handled if there is an incomplete config section from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:04 AM · Hyppopy
kleina moved T26325: Add code coverage for hyppopy from Backlog to Done on the Hyppopy board.
Mar 8 2021, 9:04 AM · Hyppopy

Mar 5 2021

kleina accepted rOBSHYPPOPY75cdf9ddd63f: Fixed T28333.

The auto wrapping functionality for MPISolverWrapper looks correct and straightforward to me. A check for function type is already included in the HyppopySolver.

Mar 5 2021, 1:41 PM
kleina added a comment to rOBSHYPPOPYba147fa770ad: Add possibility to pass comm to MPI classes..

I agree. As we already said, we have to work on the mpiplayground anyways and convert it into a propper mpi_example. I will spawn a task for that and include your suggestion there.

Mar 5 2021, 1:36 PM

Mar 4 2021

p212r added a member for Kaapana (internal): m813r.
Mar 4 2021, 5:36 PM
gaoh moved T27968: CTP gets stuck on large import from Discussion to In Progress on the Kaapana (internal) board.
Mar 4 2021, 9:35 AM · Kaapana (internal)
gaoh added a member for Kaapana (internal): d587s.
Mar 4 2021, 9:11 AM

Mar 3 2021

eisenman added a comment to T28346: Package version mismatch during upgrade.

In this case we solved it by upgrading BiocManager. Probably the previous version did not know about the later version of "graph".

Mar 3 2021, 8:17 PM · challengeR
wiesenfa added a comment to T28346: Package version mismatch during upgrade.

graph had only been used for networks, I guess version 1.62 is sufficient

Mar 3 2021, 7:45 PM · challengeR
eisenman added a comment to T28346: Package version mismatch during upgrade.

The package "graph" was moved from CRAN to Bioconductor:
https://cran.r-project.org/web/packages/graph/index.html

Mar 3 2021, 2:10 PM · challengeR
eisenman triaged T28346: Package version mismatch during upgrade as High priority.
Mar 3 2021, 2:06 PM · challengeR
kalali edited projects for T26485: [Segmentation] PACS mode is active while segmentation is drawn, added: Request for Discussion, Next Milestone; removed Restricted Project.

Also when changing the interaction mode (PACS <-> MITK) while the segmentation tool (e.g. Add) is active, the changed interaction mode will overwrite the segmentation interaction and the render window changes again while drawing the segmentation.

Mar 3 2021, 11:53 AM · MITK (v2021.10)

Mar 2 2021

kislinsk closed T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..) as Resolved.
Mar 2 2021, 11:12 PM · MITK
kislinsk committed rMITKbc70fcca1f66: Make use of GetRenderWindowPart() more robust (authored by kislinsk).
Make use of GetRenderWindowPart() more robust
Mar 2 2021, 11:12 PM
kislinsk committed rMITK288ecbcf8528: Make use of GetRenderWindowPart() more robust (authored by kislinsk).
Make use of GetRenderWindowPart() more robust
Mar 2 2021, 11:12 PM
kislinsk lowered the priority of T27196: Rewrite packaging of MITK from High to Normal.
Mar 2 2021, 11:10 AM · Moved to git.dkfz.de, MITK, Cleared
kislinsk closed T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services, a subtask of T27196: Rewrite packaging of MITK, as Resolved.
Mar 2 2021, 11:10 AM · Moved to git.dkfz.de, MITK, Cleared
kislinsk closed T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services, a subtask of T23301: XNAT improvements, as Resolved.
Mar 2 2021, 11:10 AM · Auto-closed, MITK
kislinsk closed T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services as Resolved.
Mar 2 2021, 11:10 AM · Restricted Project, CSI-HD, MITK
kislinsk added a revision to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..): Unknown Object (Differential Revision).
Mar 2 2021, 10:57 AM · MITK
thomass added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

Since you also mentioned different editors: Not sure if this is also related but one of the terminal outputs of the testers was:

Mar 2 2021, 9:51 AM · MITK
kalali committed rMITK7014777eedae: Preserve color selection (authored by kalali).
Preserve color selection
Mar 2 2021, 9:11 AM
kalali committed rMITK372746b5a2ae: Initialize color member with red (authored by kalali).
Initialize color member with red
Mar 2 2021, 9:11 AM
kalali committed rMITK93758e9b6fe4: Correctly initialize the color selection dialog (authored by kalali).
Correctly initialize the color selection dialog
Mar 2 2021, 9:11 AM
kislinsk added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

I will go through the source tree and as a rule of thumb I will just add nullptr checks if the render window part is only used for rendering updates and add the OPEN strategy if more is done with the reference and there is not already a nullptr check.

Mar 2 2021, 8:49 AM · MITK
kislinsk claimed T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).
Mar 2 2021, 8:45 AM · MITK

Mar 1 2021

kislinsk renamed T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..) from [Docu] Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..) to Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).
Mar 1 2021, 8:57 PM · MITK
kislinsk added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

I tested it in debug mode and the fix is pretty simple. The crashes occurs in lines like GetRenderWindowPart()->RequestUpdate() when GetRenderWindowPart() returns a nullptr. I guess there are quite a few unchecked lines like this in MITK.

Mar 1 2021, 8:57 PM · MITK
thomass updated the task description for T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).
Mar 1 2021, 5:38 PM · MITK
p212r added a member for MIC: m813r.
Mar 1 2021, 5:04 PM
s434n added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

I got the same result as kislinsk, the crash only occurs when the documentation is open and not in the background

Mar 1 2021, 4:07 PM · MITK
kislinsk added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

When I reproduced the issue with MatchPoint, it didn't happen when the documentation was in the background (i.e. the documentation is not the active editor). I guess this is a good starting point for debugging.

Mar 1 2021, 3:16 PM · MITK
thomass added a comment to T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).

With the modelfit inspector it most often crashed, if the user clicked on a datanode in the datastorage

Mar 1 2021, 3:07 PM · MITK
thomass updated the task description for T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).
Mar 1 2021, 3:02 PM · MITK
thomass renamed T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..) from [Docu] Crashes when using plugin with documentation opened to [Docu] Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..).
Mar 1 2021, 2:49 PM · MITK
thomass triaged T28341: Crashes when using plugin with documentation opened (in MatchPoint,Modelfit,..) as High priority.
Mar 1 2021, 2:48 PM · MITK
holzwart added a member for Photoacoustics: p253n.
Mar 1 2021, 10:58 AM
holzwart added a member for IMSY: p253n.
Mar 1 2021, 10:57 AM
kislinsk edited the content of Code Guarantees.
Mar 1 2021, 10:39 AM
kislinsk edited the content of Code Guarantees.
Mar 1 2021, 10:29 AM
kislinsk renamed Code Guarantees from Code guarantees to Code Guarantees.
Mar 1 2021, 10:19 AM
kislinsk published a new version of Git Branching Model.
Mar 1 2021, 9:43 AM · MITK

Feb 26 2021

floca committed rOBSHYPPOPY7e2b0026d800: Extracted mpi4py into an optional_requirements.txt for now, (authored by floca).
Extracted mpi4py into an optional_requirements.txt for now,
Feb 26 2021, 2:38 PM
floca committed rOBSHYPPOPY8fcdb9d07f73: Made MPI an extra in the requirement specification because (authored by floca).
Made MPI an extra in the requirement specification because
Feb 26 2021, 12:27 PM
floca committed rOBSHYPPOPY3636699c3c1e: Removed unneeded dependency to MPIBlackboxFunction (authored by floca).
Removed unneeded dependency to MPIBlackboxFunction
Feb 26 2021, 12:27 PM

Feb 25 2021

k656s moved T28335: Landing Page container automatically get killed in every minute from Discussion to Resolved on the Kaapana (internal) board.
Feb 25 2021, 2:59 PM · Request for Discussion, Kaapana (internal)
k656s closed T28335: Landing Page container automatically get killed in every minute as Resolved.

Resolved, error was in the docker container

Feb 25 2021, 2:59 PM · Request for Discussion, Kaapana (internal)
schererj moved T28229: build getting failed after integration of tfda module from kaapana to Kaapana - Internal from In Progress to Resolved on the Kaapana (internal) board.
Feb 25 2021, 11:53 AM · Kaapana (internal)
s669m added a comment to T28335: Landing Page container automatically get killed in every minute .

Issue in landing page tfda, base pods .

Feb 25 2021, 10:15 AM · Request for Discussion, Kaapana (internal)
k656s added a comment to T28335: Landing Page container automatically get killed in every minute .

Sounds strange to me.
Is the error still there, if yes can you send me the instance, where this is happening? :)

Feb 25 2021, 10:09 AM · Request for Discussion, Kaapana (internal)
s669m raised the priority of T28335: Landing Page container automatically get killed in every minute from Normal to High.
Feb 25 2021, 9:32 AM · Request for Discussion, Kaapana (internal)

Feb 24 2021

norajitr added a comment to T28232: Shapemodels.

I like the idea of open sourcing the code and making models available as well. If we can roughly clarify how the workload/hurdles would look like in reality, I can also imagine to back the process. Licensing and publication of trained models arises more often lately, thus any solution here can probably also be fruitful for similar endeavors.

Feb 24 2021, 4:11 PM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
gaoh added a comment to T27968: CTP gets stuck on large import.

I cannot reproduce the error. When sending the data to an instance the data gets imported. When debugging CTP locally there also seems to be no problem. For me also it looks like the problem is not directly in the CTP but in the java library (dcm4che). Did the files got triggered/send to airflow? Did they get stuck in a quarantine folder of the CTP, and if so in which?

Feb 24 2021, 2:09 PM · Kaapana (internal)
floca committed rOBSHYPPOPY7961f8745789: Fixed usage of potentially wrong MPI communicator (was still hard coded) (authored by floca).
Fixed usage of potentially wrong MPI communicator (was still hard coded)
Feb 24 2021, 12:41 PM
gaoh added a comment to T27968: CTP gets stuck on large import.

This is one of my model DICOMs (not 100% sure if this will reproduce it).
If not I can try to make bigger parts.

Download-link from my instance

Just a remark: The download link does not work for me. I get forbidden access. This is also the case, even if I am logged into the platform. But since there is only one folder in minio I also found it without the link:)

Feb 24 2021, 12:26 PM · Kaapana (internal)
floca committed rOBSHYPPOPYd6ec11f65d51: Fleshed out the draft a bit more. (authored by floca).
Fleshed out the draft a bit more.
Feb 24 2021, 12:18 PM
s669m triaged T28335: Landing Page container automatically get killed in every minute as Normal priority.
Feb 24 2021, 12:17 PM · Request for Discussion, Kaapana (internal)
kislinsk moved T26399: Workbench crash on simple tree model update from MITK Meeting to Backlog on the Request for Discussion board.
Feb 24 2021, 11:26 AM · Moved to git.dkfz.de, MITK, Request for Discussion
kislinsk lowered the priority of T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary" from Normal to Low.

We are going to rewrite the 2-d LabelSetImage mapper and write a 3-d LabelSetImage mapper this year, where this will be addressed. We should at least clean up the duality of the contour properties (binary vs. labelset.contour). We should probably allow to show the contour without any filling and we should clean up the coupling between contours and active label.

Feb 24 2021, 11:18 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist, Request for Discussion
schererj added a comment to T27968: CTP gets stuck on large import.

This is one of my model DICOMs (not 100% sure if this will reproduce it).
If not I can try to make bigger parts.

Feb 24 2021, 10:21 AM · Kaapana (internal)
gaoh added a comment to T27968: CTP gets stuck on large import.

Can you send me a dataset to reproduce it? I could try to debug CTP, but it looks like it is not even a problem in CTP but in org.dcm4chri

Feb 24 2021, 9:47 AM · Kaapana (internal)
kalali moved T27713: [Segmentation] Disable "New" button when no image is selected from Backlog to MITK Meeting on the Request for Discussion board.
Feb 24 2021, 9:42 AM · MITK (v2021.10), Request for Discussion
kalali added a project to T27713: [Segmentation] Disable "New" button when no image is selected: Request for Discussion.
Feb 24 2021, 9:42 AM · MITK (v2021.10), Request for Discussion
kalali moved T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary" from Backlog to MITK Meeting on the Request for Discussion board.
Feb 24 2021, 9:42 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist, Request for Discussion
floca reopened T28333: Allow auto wrapping of blackbox for MPI as "Open".
Feb 24 2021, 12:04 AM · Hyppopy
floca added a comment to T28333: Allow auto wrapping of blackbox for MPI.

@kleina can ou review the branch somewhen if the change is OK?

Feb 24 2021, 12:03 AM · Hyppopy