Page MenuHomePhabricator
Feed All Stories

Feb 24 2021

floca closed T28333: Allow auto wrapping of blackbox for MPI as Resolved by committing rOBSHYPPOPY75cdf9ddd63f: Fixed T28333.
Feb 24 2021, 12:03 AM · Hyppopy
floca committed rOBSHYPPOPY75cdf9ddd63f: Fixed T28333 (authored by floca).
Fixed T28333
Feb 24 2021, 12:03 AM
floca committed rOBSHYPPOPY28d5ce61eb54: First draft (not functioning) of how the cascaded support could look like. (authored by floca).
First draft (not functioning) of how the cascaded support could look like.
Feb 24 2021, 12:03 AM

Feb 23 2021

floca triaged T28333: Allow auto wrapping of blackbox for MPI as Normal priority.
Feb 23 2021, 11:48 PM · Hyppopy
floca triaged T28332: Support cascaded MPI processing as Normal priority.
Feb 23 2021, 11:41 PM · Hyppopy
floca added a comment to rOBSHYPPOPYba147fa770ad: Add possibility to pass comm to MPI classes..

I just saw that the default option is already implemented. Then I would just remove it in the playground or explain that both ways are possible. Because otherwise people might think that they always have to do it.

Feb 23 2021, 11:39 PM
floca raised a concern with rOBSHYPPOPYba147fa770ad: Add possibility to pass comm to MPI classes..
Feb 23 2021, 9:30 PM
floca added a comment to rOBSHYPPOPYba147fa770ad: Add possibility to pass comm to MPI classes..

@kleina Please check my comments and if nothing stands against it: 1) spawn a task to cover it. 2) cover it 😉 .

Feb 23 2021, 9:30 PM
schererj added a comment to T27968: CTP gets stuck on large import.

Another issue I have regularly:

Feb 23 2021, 4:21 PM · Kaapana (internal)
gaoh placed T28207: MITK DicomBrowser q/r Retrieve part crash up for grabs.
Feb 23 2021, 2:33 PM · MITK, Checklist
k656s added a member for Kaapana (internal): t543a.
Feb 23 2021, 2:30 PM
schererj added a comment to T27968: CTP gets stuck on large import.

This could be an option.
We should still try to solve the multiple issues with CTP.
I'm not sure if there is a single source of failure - but I have a lot of trouble with it.

Feb 23 2021, 2:10 PM · Kaapana (internal)
gaoh added a comment to T28207: MITK DicomBrowser q/r Retrieve part crash.

Get an Openstack instance (e.g. Ubuntu 20.04 DKFZ image,...)

Feb 23 2021, 11:16 AM · MITK, Checklist
kislinsk merged task T28327: Upgrading ITK version 4.13.3 to latest version of ITK 5.1.2 into T27437: Migrate MITK to use ITK 5.x .
Feb 23 2021, 10:59 AM · MITK
kislinsk merged T28327: Upgrading ITK version 4.13.3 to latest version of ITK 5.1.2 into T27437: Migrate MITK to use ITK 5.x .
Feb 23 2021, 10:59 AM · MITK-ProjectTemplate, MITK (v2022.04)
al-sabr triaged T28327: Upgrading ITK version 4.13.3 to latest version of ITK 5.1.2 as High priority.
Feb 23 2021, 8:25 AM · MITK

Feb 22 2021

floca added a revision to T28225: [Segmentation] SegTool2D::WritePreviewOnWorkingImage does not work correctly: Unknown Object (Differential Revision).
Feb 22 2021, 7:50 PM · MITK
floca reopened T28225: [Segmentation] SegTool2D::WritePreviewOnWorkingImage does not work correctly as "Open".

It was by accident auto closed by a typo in the task ID of commit mentioned above. rMITK9d7992a7815d does fix T28255.

Feb 22 2021, 6:07 PM · MITK
floca committed rRTTB8b772501fd3f: Fixed install rules after build system rework (authored by floca).
Fixed install rules after build system rework
Feb 22 2021, 3:54 PM
gaoh added a comment to T27968: CTP gets stuck on large import.

Can you reproduce the error? If so, we can do something like: https://stackoverflow.com/questions/12096403/java-shutting-down-on-out-of-memory-error

Feb 22 2021, 12:27 PM · Kaapana (internal)

Feb 20 2021

floca placed T28206: [Image Statistics] Renaming segmentation or planar figure based ROI nodes breaks histogram up for grabs.
Feb 20 2021, 2:03 PM · MITK (v2024.12)
floca committed rRTTBfa5f31edf40a: Fixed new building system for applications (authored by floca).
Fixed new building system for applications
Feb 20 2021, 1:56 PM
floca committed rRTTB288c6747a0da: Adapted helax io for new build system (authored by floca).
Adapted helax io for new build system
Feb 20 2021, 1:56 PM
floca committed rRTTB09fa00a93b72: Fixed exporting of symbols (now all tests also compile with shared libs) (authored by floca).
Fixed exporting of symbols (now all tests also compile with shared libs)
Feb 20 2021, 1:56 PM
floca committed rRTTB5fa06497b4e3: Removed deprecated test (indicie tests have moved to own test module) (authored by floca).
Removed deprecated test (indicie tests have moved to own test module)
Feb 20 2021, 1:56 PM
floca committed rRTTB9b95831375bf: Finished rework of build system for modules and tests (authored by floca).
Finished rework of build system for modules and tests
Feb 20 2021, 1:56 PM

Feb 19 2021

nolden triaged T28323: Workbench aborts if passed an invalid command line option as Low priority.
Feb 19 2021, 5:50 PM · Auto-closed, MITK
nolden added a comment to T28282: Workbench does not start when building with Qt 5.15 on Linux.

Interesting catch. There is no call to regex_match in our code. If I understand it correctly the stack object is just created to check if an exception happens during construction, but maybe this is just another variant of the issue described for the library. A possible workaround could be to explicitly create and destroy the regex objects in our code, with explicit exception catching and re-throwing.

Feb 19 2021, 5:13 PM · Auto-closed, MITK
s434n triaged T28322: [Screenshot Maker] 3D Multiplanar screenshot does not return view to initial position as Low priority.
Feb 19 2021, 1:59 PM · MITK
s434n triaged T28321: [Measurement] Control points can not be moved twice without moving the mouse away as Low priority.
Feb 19 2021, 1:44 PM · Auto-closed, MITK
gaoh closed Restricted Maniphest Task, a subtask of T28302: MITK CI jobs for Kaapana, as Resolved.
Feb 19 2021, 11:53 AM · CI, MITK
s669m added a member for MIC: o776l.
Feb 19 2021, 11:52 AM
schererj added a comment to T28302: MITK CI jobs for Kaapana.

Okay, nice. Last question: You currently have both a PhenotypingRelease and a ClassificationCmdApps configuration. The apps of the latter one are also included in the former configuration. Is it fine to just go for PhenotypingRelease then at the cost of a little larger tarball as also the workbench application is included? @schererj

Feb 19 2021, 10:46 AM · CI, MITK
nolden added a comment to T28232: Shapemodels.

@norajitr maybe a bit more background on the ticket for you:

Feb 19 2021, 10:39 AM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
s434n triaged T28320: [Segmentation] Region growing does not work if seed point is already inside a segmentation as Normal priority.
Feb 19 2021, 10:39 AM · MITK (v2022.04), Missing Info, Request for Discussion
floca added a comment to T28232: Shapemodels.

I think the points are wrong ordered. First we should clarify (management decission) that it should go into a release/open-source and if tobi has the time to backing the process.
If this is cleare, the technical assesement of what has to be done to have it in master and under CI/testing can be evaluated/quantified.

Feb 19 2021, 9:58 AM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
kislinsk added a comment to T28282: Workbench does not start when building with Qt 5.15 on Linux.

I didn't really look into this but it reminds me of something I stumbled over a few weeks ago. There's a bug in C++ 14 regex regarding temporary strings: https://cplusplus.github.io/LWG/issue2329

Feb 19 2021, 9:40 AM · Auto-closed, MITK

Feb 18 2021

kislinsk closed T28314: Text not showed in Python console using Theme Light as Wontfix.

Thanks for reporting. We recently rewrote the Python integration in MITK. Its status is at ~80% and it will get merged as soon as we figured out the packaging for Python in MITK (branch feature/T27923-python-dev). The QtPython module was removed as we do not longer depend on CTK/PythonQt for the Python integration.

Feb 18 2021, 9:42 PM · MITK
kislinsk triaged T28311: MitkFlowBench Naming Issue as Normal priority.
Feb 18 2021, 9:36 PM · Auto-closed, MITK
kislinsk triaged T28282: Workbench does not start when building with Qt 5.15 on Linux as High priority.
Feb 18 2021, 9:35 PM · Auto-closed, MITK
kislinsk triaged T28281: Review C++ warnings configuration as Normal priority.
Feb 18 2021, 9:33 PM · Auto-closed, Request for Discussion, MITK
kislinsk triaged T28279: [Interaction] Improve image cropper cross hair interaction as Normal priority.
Feb 18 2021, 9:33 PM · Auto-closed, MITK
kislinsk triaged T28232: Shapemodels as Wishlist priority.
Feb 18 2021, 9:32 PM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
kislinsk closed T28302: MITK CI jobs for Kaapana as Resolved.
Feb 18 2021, 9:29 PM · CI, MITK
kislinsk added a comment to T28302: MITK CI jobs for Kaapana.

I gave @schererj and @gaoh rights to start the Kaapana MITK build jobs and to read the configurations: https://ci.mitk.org/job/MITK/job/Kaapana/

Feb 18 2021, 9:28 PM · CI, MITK
kislinsk added a member for MITK: s434n.
Feb 18 2021, 6:34 PM
kalali edited projects for T27713: [Segmentation] Disable "New" button when no image is selected, added: MITK; removed MITK (v2021.02).

I looked into it and I have the impression that there is a lot of unnecessary complexity created in order to generate a valid UI state. The problem, as far as I can see, lies in the overuse of if-statements and having functions that have way to many responsibilities. This is a typical "clean code" task and I suggest to go through the whole QmitkSegmentationView.cpp file and apply some best practices of writing clean code.
But since it is not clear how much effort we want to put into it (thinking of T28142), it might be wise to not work on this right now but to use a general refactoring task (parent task) to fix the mentioned bug.
I advise also to have a look https://phabricator.mitk.org/file/data/7bghshzurxwupnipv3dl/PHID-FILE-n2hwm6xv2mil3ola47sq/QtStateMachineFramework.pdf.

Feb 18 2021, 4:18 PM · MITK (v2021.10), Request for Discussion
thomass added a member for MIC: s434n.
Feb 18 2021, 3:38 PM
isensee added a member for Deep Learning: l374d.
Feb 18 2021, 3:06 PM
kislinsk added a comment to T28302: MITK CI jobs for Kaapana.
Feb 18 2021, 2:34 PM · CI, MITK
kislinsk added a comment to T28302: MITK CI jobs for Kaapana.

Okay, nice. Last question: You currently have both a PhenotypingRelease and a ClassificationCmdApps configuration. The apps of the latter one are also included in the former configuration. Is it fine to just go for PhenotypingRelease then at the cost of a little larger tarball as also the workbench application is included? @schererj

Feb 18 2021, 2:33 PM · CI, MITK
floca added a comment to T28302: MITK CI jobs for Kaapana.
In T28302#220479, @gaoh wrote:

The normal WorkbenchRelease configuration should be even better suited for the future...

+1

Feb 18 2021, 1:33 PM · CI, MITK
gaoh added a comment to T28302: MITK CI jobs for Kaapana.

@gaoh

I noticed that the only plugins enabled in the "MitkVolume" configuration are the segmentation plugins. Do you explicitly want to have this "slim" version or is the official WorkbenchRelease configuration more sufficient?

Feb 18 2021, 12:58 PM · CI, MITK
kislinsk added a comment to T28302: MITK CI jobs for Kaapana.

Okay. Currently running the first test with the PhenotypingRelease configuration and tag set to v2021.02. So the file name will be automatically versioned and will appear at https://www.mitk.org/download/kaapana/phenotyping/ once the build succeeds.

Feb 18 2021, 11:53 AM · CI, MITK
nolden added a comment to T28302: MITK CI jobs for Kaapana.

I would like to have files versioned / with different names. If it's necessary to have a download link that doesn't change I can help with a script to create a "latest" link, had that for MITK nightlies back in the days

Feb 18 2021, 11:45 AM · CI, MITK
kislinsk added a comment to T28302: MITK CI jobs for Kaapana.

To all: Do you want to version files or do you want to simply override existing old installers when generating new ones (which happens with custom set revisions descriptions as done in a few docker files above)?

Feb 18 2021, 11:40 AM · CI, MITK
kislinsk added a comment to T28302: MITK CI jobs for Kaapana.

I noticed that the only plugins enabled in the "MitkVolume" configuration are the segmentation plugins. Do you explicitly want to have this "slim" version or is the official WorkbenchRelease configuration more sufficient?

Feb 18 2021, 11:38 AM · CI, MITK

Feb 17 2021

gaoh added a comment to T28302: MITK CI jobs for Kaapana.

And MITK volume (aka the normal workbench) uses the Release build with segmentation=ON

Maybe we should then just label it MITK Workbenches to avoid confusion and reduce (redundant) artefacts.

Feb 17 2021, 11:01 AM · CI, MITK
floca added a comment to T28311: MitkFlowBench Naming Issue.
In T28311#220415, @gaoh wrote:

would be to give it the name of the Instance UID.

Understood, but thats not that easy yet, as the Instance UID is currently generated by DCMQI in the writing process. But that is something we should alter somewhen anyways, as we already need this UID within MITK.
So I guess we take one of the other choices as mitigation strategy.

Feb 17 2021, 9:27 AM · Auto-closed, MITK
gaoh added a comment to T28311: MitkFlowBench Naming Issue.

In case of kaapana, the name is currently irrelevant: directly in the next operator, the dcm files are send to the PACs anyway and then the file is deleted.
What would make sense, regading the naming in the PACs and when downloading files, would be to give it the name of the Instance UID.

Feb 17 2021, 9:13 AM · Auto-closed, MITK

Feb 16 2021

floca added a comment to T28311: MitkFlowBench Naming Issue.

It is the "\" in the node name.

Feb 16 2021, 10:28 PM · Auto-closed, MITK
kislinsk closed T28000: MITK v2021.02 as Resolved.

Nvidia AIAA WorkbenchRelease binaries are building or were already deployed.

Feb 16 2021, 10:02 PM · MITK-ProjectTemplate, MITK (v2021.02)
kalali edited projects for T26969: [Segmentation] New segmentation dialog: Change color twice and aborting the second time chages color to red, added: MITK; removed MITK (v2021.02).
Feb 16 2021, 8:47 PM · MITK
kalali added a revision to T26969: [Segmentation] New segmentation dialog: Change color twice and aborting the second time chages color to red: Unknown Object (Differential Revision).
Feb 16 2021, 7:18 PM · MITK
kalali claimed T26969: [Segmentation] New segmentation dialog: Change color twice and aborting the second time chages color to red.
Feb 16 2021, 7:14 PM · MITK
kalali edited projects for T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary", added: Request for Discussion, MITK; removed MITK (v2021.02).

It seems as if datanode->GetBoolProperty("binary", binary, renderer) inside mitkImageVtkMapper2D always results in binary being false. This might be true for our LabelSet images, but the properties view still shows the property binary as true, e.g. for segmentations created with the classic segmentation view.

Feb 16 2021, 6:07 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist, Request for Discussion
floca committed rRTTBdffbb9433fb8: Started rework of RTTB build system to introduce private dependencies. (authored by floca).
Started rework of RTTB build system to introduce private dependencies.
Feb 16 2021, 5:23 PM
kalali triaged T28315: [Selection concept] Provide preference page option to show / hide helper nodes as Normal priority.
Feb 16 2021, 5:01 PM · Request for Discussion, MITK (v2021.10)
jmcuadra created T28314: Text not showed in Python console using Theme Light.
Feb 16 2021, 4:43 PM · MITK
gaoh added a comment to T28311: MitkFlowBench Naming Issue.

so maybe a Regex is needed, or just a default file name..

Feb 16 2021, 11:00 AM · Auto-closed, MITK
gaoh created T28311: MitkFlowBench Naming Issue.
Feb 16 2021, 10:58 AM · Auto-closed, MITK
schererj moved T28109: Check correct association of Segs with origin DICOM from Backlog to Resolved on the Kaapana (internal) board.
Feb 16 2021, 10:05 AM · Kaapana (internal)
schererj moved T28053: DICOM Seg not associated with source DICOM from Backlog to Resolved on the Kaapana (internal) board.
Feb 16 2021, 10:05 AM · Kaapana (internal)
neher added a comment to T28109: Check correct association of Segs with origin DICOM.

Missing tags in the Seg, so it is an error in the file.

Feb 16 2021, 6:56 AM · Kaapana (internal)
neher closed T28109: Check correct association of Segs with origin DICOM as Resolved.

This should be resolved.

Feb 16 2021, 6:55 AM · Kaapana (internal)
neher closed T28053: DICOM Seg not associated with source DICOM as Resolved.

This should be resolved.

Feb 16 2021, 6:55 AM · Kaapana (internal)

Feb 15 2021

schererj closed T28196: [Docs] Update Dev-Guide for 0.1.1-dev as Resolved.
Feb 15 2021, 3:54 PM · Kaapana (internal)
schererj closed T28273: configmap for kibana and elasticsearch throws an error as Resolved.
Feb 15 2021, 3:52 PM · Kaapana (internal)
schererj moved T28127: Reopen segmentation in MITK from Backlog to Resolved on the Kaapana (internal) board.
Feb 15 2021, 3:51 PM · MITK (v2021.02), Restricted Project, Kaapana (internal)
schererj moved T28049: DataUpload fails with Firefox from Backlog to Resolved on the Kaapana (internal) board.
Feb 15 2021, 3:51 PM · Kaapana (internal)
schererj moved T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics) from Backlog to Resolved on the Kaapana (internal) board.
Feb 15 2021, 3:51 PM · HiGHmed, Kaapana (internal), MITK
schererj added a comment to T28109: Check correct association of Segs with origin DICOM.

@neher is there a connection to T28053 ?

Feb 15 2021, 3:50 PM · Kaapana (internal)
schererj closed T28049: DataUpload fails with Firefox as Invalid.

Duplicate of T28291

Feb 15 2021, 3:45 PM · Kaapana (internal)
schererj added a comment to T28053: DICOM Seg not associated with source DICOM.

@neher is this still an issue? I think we have all the SEGs working now, or?

Feb 15 2021, 3:43 PM · Kaapana (internal)
schererj removed a project from T28232: Shapemodels: Kaapana (internal).
Feb 15 2021, 3:39 PM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
kislinsk added a comment to T28000: MITK v2021.02.

Deleted branch from rMPT MITK-ProjectTemplate: release/T28000-v2021.02.

Feb 15 2021, 3:18 PM · MITK-ProjectTemplate, MITK (v2021.02)
kislinsk committed rMPTa6977910a7c0: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Feb 15 2021, 3:18 PM
kislinsk committed rMPTaaf7bd9d1cdf: Migrate to MITK's new selection widget (authored by kislinsk).
Migrate to MITK's new selection widget
Feb 15 2021, 3:18 PM
kislinsk committed rMPTe3c0aee19f6e: Merge branch 'release/T28000-v2021.02' (authored by kislinsk).
Merge branch 'release/T28000-v2021.02'
Feb 15 2021, 3:17 PM
kislinsk added a comment to T28000: MITK v2021.02.

Pushed new branch to rMPT MITK-ProjectTemplate: release/T28000-v2021.02.

Feb 15 2021, 3:14 PM · MITK-ProjectTemplate, MITK (v2021.02)
kislinsk added a comment to T28000: MITK v2021.02.

Deleted branch from rMPT MITK-ProjectTemplate: release/T28000-v2021.01.

Feb 15 2021, 3:13 PM · MITK-ProjectTemplate, MITK (v2021.02)
kislinsk added a comment to T28000: MITK v2021.02.

Deleted branch from rMITK MITK: bugfix/T28000-BumpDevelVersion.

Feb 15 2021, 3:11 PM · MITK-ProjectTemplate, MITK (v2021.02)
kislinsk committed rMITK7984ffeed3be: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Feb 15 2021, 3:11 PM
kislinsk committed rMITK02b8c091029b: Bump MITK development version (authored by kislinsk).
Bump MITK development version
Feb 15 2021, 3:11 PM
kislinsk committed rMITKb9f34b51cab7: Merge branch 'bugfix/T28000-BumpDevelVersion' into develop (authored by kislinsk).
Merge branch 'bugfix/T28000-BumpDevelVersion' into develop
Feb 15 2021, 3:10 PM
kislinsk added a comment to T28000: MITK v2021.02.

Pushed new branch to rMITK MITK: bugfix/T28000-BumpDevelVersion.

Feb 15 2021, 3:10 PM · MITK-ProjectTemplate, MITK (v2021.02)
kislinsk added a comment to T28000: MITK v2021.02.

Deleted branch from rMITK MITK: bugfix/T28000-BumpDevelVersion.

Feb 15 2021, 3:09 PM · MITK-ProjectTemplate, MITK (v2021.02)
kislinsk added a comment to T28000: MITK v2021.02.

Deleted branch from rMITK MITK: release/T28000-v2021.02.

Feb 15 2021, 3:07 PM · MITK-ProjectTemplate, MITK (v2021.02)
kislinsk added a comment to T28000: MITK v2021.02.

Pushed new branch to rMITK MITK: bugfix/T28000-BumpDevelVersion.

Feb 15 2021, 3:05 PM · MITK-ProjectTemplate, MITK (v2021.02)
schererj assigned T27968: CTP gets stuck on large import to gaoh.
Feb 15 2021, 2:07 PM · Kaapana (internal)