Page MenuHomePhabricator
Feed Advanced Search

Nov 6 2022

kislinsk claimed T29025: Preference service (access) based on cpp microservices.

I stumbled upon this while working on T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module. I would like to tackle this issue and already started looking into this. Do you already have an idea how to approach it or do we want to discuss it next week?

Nov 6 2022, 2:25 PM · MITK (v2023.04), Breaking Change

Nov 4 2022

kalali added a project to T29027: Move NodeSelectionWidgets to QtWidgets module: Next Milestone.
Nov 4 2022, 6:07 PM · MITK (v2023.04)
kalali added a comment to T29027: Move NodeSelectionWidgets to QtWidgets module.

Required for T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module / T27133: [Segmentation] Is QmitkDataSelectionWidget needed anymore?.

Nov 4 2022, 6:07 PM · MITK (v2023.04)
kalali added a comment to T29025: Preference service (access) based on cpp microservices.

I stumbled upon this while working on T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module. I would like to tackle this issue and already started looking into this. Do you already have an idea how to approach it or do we want to discuss it next week?

Nov 4 2022, 6:06 PM · MITK (v2023.04), Breaking Change

Nov 2 2022

s434n added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

Deleted branch from rMITK MITK: feature/T28578-MxN-development.

Nov 2 2022, 10:56 AM · Moved to git.dkfz.de, MITK

Oct 31 2022

a178n added a comment to T29379: MONAI Label REST Response JSON issues, allegedly.
  1. The relevance of the labels list outside models? Perhaps, this entry can be used to describe all labels and their label ids used in the host app. And, models can then refer to label ids in their respective labels entries.
Oct 31 2022, 9:38 AM · Moved to git.dkfz.de, MITK
a178n added a comment to T29379: MONAI Label REST Response JSON issues, allegedly.
  1. Lack of consistency in models->labels entries. For some models eg. deepedit there are label ids along with names, effectively assuming a Map datatype and for others, eg. deepgrow_2d it's a list. of label names. This creates unnecessary corner cases while parsing using strongly typed languages, like C++.
Oct 31 2022, 9:31 AM · Moved to git.dkfz.de, MITK
a178n added a comment to T29379: MONAI Label REST Response JSON issues, allegedly.
  1. There is no indication in the JSON on which models are interactive click guided, scribble guided or automatic. Eg. Deepedit can be interactive click-guided or automatic, GMM+GraphCut is scribble guided, Segmentation Spleen is purely automatic. Hence, the JSON parameter type can be made more consistent for easy grouping.
Oct 31 2022, 9:26 AM · Moved to git.dkfz.de, MITK
a178n updated the task description for T29379: MONAI Label REST Response JSON issues, allegedly.
Oct 31 2022, 9:25 AM · Moved to git.dkfz.de, MITK
a178n triaged T29379: MONAI Label REST Response JSON issues, allegedly as Normal priority.
Oct 31 2022, 9:21 AM · Moved to git.dkfz.de, MITK

Oct 29 2022

kislinsk edited the content of Changelog.
Oct 29 2022, 10:14 AM · MITK
kislinsk renamed T29375: Cursor offset in 2D tools with Qt 5.15 on macOS from Cursor offset in 2D tools with Qt 5.12 on macOS to Cursor offset in 2D tools with Qt 5.15 on macOS.
Oct 29 2022, 12:21 AM · MITK (v2023.04)

Oct 28 2022

kislinsk closed T29377: 2022 Week 43 (Late October) as Resolved.
Oct 28 2022, 5:23 PM · MITK
kislinsk added a comment to T29377: 2022 Week 43 (Late October).

Deleted branch from rMITK MITK: release/T29377-2022-Week-43.

Oct 28 2022, 5:22 PM · MITK
kislinsk edited the content of Changelog.
Oct 28 2022, 5:17 PM · MITK
kislinsk closed T29324: Create view for pixel information as Resolved.
Oct 28 2022, 5:14 PM · MITK
kislinsk closed T29324: Create view for pixel information, a subtask of T25042: How to handle update informations in heterogeneous time geometries and out of bound situations , as Resolved.
Oct 28 2022, 5:14 PM · Moved to git.dkfz.de, MITK
kislinsk added a revision to T29324: Create view for pixel information: Restricted Differential Revision.
Oct 28 2022, 5:14 PM · MITK
kislinsk added a comment to T29377: 2022 Week 43 (Late October).

Pushed new branch to rMITK MITK: release/T29377-2022-Week-43.

Oct 28 2022, 10:07 AM · MITK
kislinsk triaged T29377: 2022 Week 43 (Late October) as Normal priority.
Oct 28 2022, 10:05 AM · MITK

Oct 26 2022

kislinsk renamed T29375: Cursor offset in 2D tools with Qt 5.15 on macOS from [Segmentation] Cursor offset in 2D tools with Qt 5.12 on macOS to Cursor offset in 2D tools with Qt 5.12 on macOS.
Oct 26 2022, 6:28 PM · MITK (v2023.04)
floca updated the task description for T29374: [SEG] Instant visual response to inverted state of tools (add, substract, paint, wipe).
Oct 26 2022, 10:37 AM · Moved to git.dkfz.de, MITK (v2024.12)
floca triaged T29374: [SEG] Instant visual response to inverted state of tools (add, substract, paint, wipe) as Normal priority.
Oct 26 2022, 9:22 AM · Moved to git.dkfz.de, MITK (v2024.12)

Oct 25 2022

kislinsk added a comment to T29371: [Registration] Improve view icons.

Hm, I disagree. :-)

Oct 25 2022, 5:24 PM · MITK
kislinsk edited projects for T29371: [Registration] Improve view icons, added: MITK; removed MITK (v2022.10).
Oct 25 2022, 2:47 PM · MITK

Oct 24 2022

kislinsk added a comment to T29370: How to use external packages for dependencies?.

These variables need to point to the location where CMake's find_package() will find the packages. For example, for ITK it would need to point to the equivalent of the MITK-superbuild/ep/lib/cmake/ITK-5.2 folder, where the ITKConfig.cmake and ITKConfigVersion.cmake files are located.

Oct 24 2022, 12:04 PM · MITK
yurivict added a comment to T29370: How to use external packages for dependencies?.

With -DEXTERNAL_ITK_DIR=/usr/local it still downloads and builds ITK.

Oct 24 2022, 5:14 AM · MITK
kislinsk closed T29370: How to use external packages for dependencies? as Resolved.

The superbuild has advanced variables for that:

  • EXTERNAL_ITK_DIR
  • EXTERNAL_HDF5_DIR
  • EXTERNAL_BOOST_ROOT
Oct 24 2022, 4:58 AM · MITK

Oct 23 2022

yurivict created T29370: How to use external packages for dependencies?.
Oct 23 2022, 11:14 PM · MITK

Oct 21 2022

kislinsk closed T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, a subtask of T28176: [Segmentation] Inspection of module and plugin, as Resolved.
Oct 21 2022, 6:00 AM · Moved to git.dkfz.de, MITK (v2024.12)

Oct 20 2022

kalali added a revision to T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty: Restricted Differential Revision.
Oct 20 2022, 6:40 PM · MITK (v2023.12), Request for Discussion
kalali added a comment to T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty.

If D744 is landed, we can close this task. The issue will be addressed here: T29369: [Segmentation Utilities] Handle / select different labels independently.

Oct 20 2022, 6:40 PM · MITK (v2023.12), Request for Discussion
kalali triaged T29369: [Segmentation Utilities] Handle / select different labels independently as Normal priority.
Oct 20 2022, 6:38 PM · MITK (v2024.06)
kalali added a comment to T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty.

With {D744} we only have a single Segmentation Utilities view. Labels operation should be added to this and then the issue of this task needs to be considered.

Oct 20 2022, 12:37 PM · MITK (v2023.12), Request for Discussion
kalali renamed T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty from [Multilabel Segmentation] "Labels" tabs in operations of Utilities view is empty to [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty.
Oct 20 2022, 12:36 PM · MITK (v2023.12), Request for Discussion

Oct 17 2022

kalali renamed T29333: [mxn multi widget] Measurements / planar figure not working from [mxn multi widet] Measurements / planar figure not working to [mxn multi widget] Measurements / planar figure not working.
Oct 17 2022, 4:44 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali renamed T29365: [mxn multi widget] Pointset interaction not working from [mxn multi widet] Pointset interaction not working to [mxn multi widget] Pointset interaction not working.
Oct 17 2022, 4:44 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali edited projects for T29333: [mxn multi widget] Measurements / planar figure not working, added: MITK, Next Milestone; removed MITK (v2022.10).
Oct 17 2022, 4:39 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali triaged T29365: [mxn multi widget] Pointset interaction not working as Normal priority.
Oct 17 2022, 4:39 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali added a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29364: [mxn multi widget] Image navigator cannot be used.
Oct 17 2022, 4:37 PM · Moved to git.dkfz.de, MITK
kalali added a parent task for T29364: [mxn multi widget] Image navigator cannot be used: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Oct 17 2022, 4:37 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali triaged T29364: [mxn multi widget] Image navigator cannot be used as Normal priority.
Oct 17 2022, 4:29 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali updated the task description for T29303: IGT classes do not work correctly with the new mxn multi widget.
Oct 17 2022, 3:17 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali closed T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor), a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 17 2022, 3:16 PM · Moved to git.dkfz.de, MITK
kalali closed T26376: Segmentation plugin does not work correctly with the new mxn multi widget, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 17 2022, 2:42 PM · Moved to git.dkfz.de, MITK
kalali added a project to T29335: [Segmentation] Show interactive warning for uninitialized render window geometry: Next Milestone.
Oct 17 2022, 2:42 PM · MITK (v2023.04)
kalali edited projects for T29240: [mxn multi widget] Allow different time navigation controller for each individual render window, added: MITK, Next Milestone; removed MITK (v2022.10).
Oct 17 2022, 2:40 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali closed T29328: Fix different issues with re-initialization, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 17 2022, 2:19 PM · Moved to git.dkfz.de, MITK

Oct 14 2022

kalali removed a parent task for T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations: T25595: [Multi widget] Make classes work with the new render window access.
Oct 14 2022, 1:10 PM · Breaking Change, Noteworthy, MITK
kalali closed T29203: [Multi widget] Make classes work with the new render window names, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 14 2022, 10:48 AM · Moved to git.dkfz.de, MITK

Oct 13 2022

kalali triaged T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly as Normal priority.
Oct 13 2022, 3:58 PM · Request for Discussion, MITK (v2023.04)
kalali closed T29331: Use NodePredicates for the render window data node selector, a subtask of T29297: [mxn multi widget] Optimize data accessibility inside render windows, as Resolved.
Oct 13 2022, 2:02 PM · MITK (v2023.04)

Oct 10 2022

kislinsk closed T29351: Segmentation Options - "Create Smoothed Polygon as Spite.
Oct 10 2022, 5:40 PM · MITK
s349i created T29351: Segmentation Options - "Create Smoothed Polygon.
Oct 10 2022, 5:19 PM · MITK

Oct 7 2022

kalali added a revision to T29331: Use NodePredicates for the render window data node selector: Restricted Differential Revision.
Oct 7 2022, 5:47 PM · MITK (v2022.10)
kalali renamed T29331: Use NodePredicates for the render window data node selector from Use NodePreidcates for the render window data node selector to Use NodePredicates for the render window data node selector.
Oct 7 2022, 5:33 PM · MITK (v2022.10)
kalali added a comment to T29331: Use NodePredicates for the render window data node selector.

I looked into this and I was confused: the used QmitkRenderWindowDataStorageTreeModel already contains a node predicate for filtering out the helper nodes. When creating the mxnmultiwidget (or a new render window) there are no plane geometries (the crosshair) being added to the storage model.

Oct 7 2022, 5:33 PM · MITK (v2022.10)
kalali triaged T29335: [Segmentation] Show interactive warning for uninitialized render window geometry as Normal priority.
Oct 7 2022, 3:11 PM · MITK (v2023.04)
kalali triaged T29331: Use NodePredicates for the render window data node selector as Normal priority.
Oct 7 2022, 10:48 AM · MITK (v2022.10)
kalali added a comment to T29298: [mxn multi widget] Add context menu to render window specific data inspector.

A simple context-menu was added in {D726}. Needs to be reworked to allow more actions.

Oct 7 2022, 10:47 AM · Moved to git.dkfz.de, MITK

Oct 6 2022

kislinsk edited the content of Changelog.
Oct 6 2022, 6:41 AM · MITK

Oct 5 2022

kalali added a comment to T25043: Remove pixel informations from the statusbar and put it into views.

Pixel information has been removed. To add a specific view for pixel information, see T29324: Create view for pixel information.

Oct 5 2022, 10:07 PM · Cleared, MITK
kalali closed T25043: Remove pixel informations from the statusbar and put it into views, a subtask of T25042: How to handle update informations in heterogeneous time geometries and out of bound situations , as Resolved.
Oct 5 2022, 10:05 PM · Moved to git.dkfz.de, MITK
kalali closed T25043: Remove pixel informations from the statusbar and put it into views as Resolved by committing rMITKb309cff2567b: Perform simple statusbar update on mouse move / wheel event.
Oct 5 2022, 10:05 PM · Cleared, MITK
kalali closed T25043: Remove pixel informations from the statusbar and put it into views, a subtask of T25105: UpdateStatusBar duplicates business logic, as Resolved.
Oct 5 2022, 10:05 PM · MITK (v2022.10)
kalali triaged T29324: Create view for pixel information as Normal priority.
Oct 5 2022, 9:18 PM · MITK
kalali added a comment to T25043: Remove pixel informations from the statusbar and put it into views.

Pixel information has been removed with {D686}. We discussed that we will open a new task to add a simple pixel value information view as a separate task.

Oct 5 2022, 9:16 PM · Cleared, MITK
kalali added a revision to T28578: [mxn multi widget] Optimization of the mxn multi widget: Restricted Differential Revision.
Oct 5 2022, 8:15 PM · Moved to git.dkfz.de, MITK
kalali added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

{D722} also belongs to this task but might not be finished this week.

Oct 5 2022, 8:08 PM · Moved to git.dkfz.de, MITK
kalali added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

I added another fix to have a simple datanode context menu with a reinit and reset-geometry action for render-window specific initialization.

Oct 5 2022, 8:07 PM · Moved to git.dkfz.de, MITK
floca triaged T29322: [SEG] Refactor code to avoid FillSliceInSlice and FillContourInSlice as High priority.
Oct 5 2022, 8:42 AM · Moved to git.dkfz.de, MITK (v2024.12)

Oct 4 2022

floca closed T28763: [Multilabel Segmentation] Fill / Erase tool does not fully respect multiple labels, a subtask of T27807: [MultiLabel Segmentation] Inspection of module and plugin, as Resolved.
Oct 4 2022, 4:38 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali closed Restricted Maniphest Task, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 4 2022, 2:51 PM · Moved to git.dkfz.de, MITK
kalali added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

I created a first working version, based on @s434n's branch (see above). I created an integration branch, made some changes and rebased everything to the latest develop.
Now the following changes, which are already merged into develop, are included, since the integration branch is based on e4d0b1591a17054b4c6792c235aa41345b842cb7:

Oct 4 2022, 2:45 PM · Moved to git.dkfz.de, MITK

Sep 30 2022

kalali placed T29269: Check geometries in SliceNavigationController and BaseRenderer up for grabs.
Sep 30 2022, 10:12 AM · Moved to git.dkfz.de, MITK (v2024.12)
kalali added a revision to T29289: Compare responsibilities of QmitkSliceNavigationController related classes: Restricted Differential Revision.
Sep 30 2022, 10:12 AM · Moved to git.dkfz.de, MITK

Sep 28 2022

floca added a comment to T24398: Dicom plugin: Retrieve does not work.

Thank you 🙏

Sep 28 2022, 9:43 AM · MITK (v2024.12)
kislinsk added a comment to T29317: Clean up DICOM Browser plugin.

Here's the first batch of clean-up action. Needs to be continued!

Sep 28 2022, 9:40 AM · MITK (v2024.12)
kislinsk triaged T29317: Clean up DICOM Browser plugin as Normal priority.
Sep 28 2022, 9:37 AM · MITK (v2024.12)
kislinsk added a comment to T24398: Dicom plugin: Retrieve does not work.

Our side or also the CTK part.

Hm, lets put it as known issue and discuss its priority when we plan the spring release.

Sep 28 2022, 9:35 AM · MITK (v2024.12)
floca added a revision to T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures.: Restricted Differential Revision.
Sep 28 2022, 9:15 AM · MITK (v2022.10)

Sep 27 2022

floca added a comment to T24398: Dicom plugin: Retrieve does not work.

thank you for looking into that matter.

Sep 27 2022, 5:38 PM · MITK (v2024.12)
floca edited projects for T24398: Dicom plugin: Retrieve does not work, added: MITK, Next Milestone; removed MITK (v2022.10).

I noticed that the whole plugin is a complete mess BTW and urgently needs at least some clean up to see all the potentials for improvements and bug fixes. :/

Our side or also the CTK part.

Sep 27 2022, 5:38 PM · MITK (v2024.12)
kalali added a subtask for T29289: Compare responsibilities of QmitkSliceNavigationController related classes: T29316: Rename QmitkSliderNavigatorWidget and clean variable names.
Sep 27 2022, 12:43 PM · Moved to git.dkfz.de, MITK
kalali updated the task description for T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
Sep 27 2022, 12:42 PM · Moved to git.dkfz.de, MITK
kalali updated the task description for T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
Sep 27 2022, 12:17 PM · Moved to git.dkfz.de, MITK

Sep 21 2022

kalali added a revision to T29265: QmitkSelectableGLWidget is not used anymore and can be removed: Restricted Differential Revision.
Sep 21 2022, 7:35 PM · MITK (v2022.10)
kalali claimed T29265: QmitkSelectableGLWidget is not used anymore and can be removed.
Sep 21 2022, 5:34 PM · MITK (v2022.10)

Sep 19 2022

kalali claimed T29219: StatusBar / mouse scrolling is broken.
Sep 19 2022, 4:42 PM · MITK (v2022.10)
kalali added a comment to T29219: StatusBar / mouse scrolling is broken.

I added the PR (https://github.com/MITK/MITK/pull/262/) as a differential.

Sep 19 2022, 4:42 PM · MITK (v2022.10)
kalali added a revision to T29219: StatusBar / mouse scrolling is broken: Restricted Differential Revision.
Sep 19 2022, 4:41 PM · MITK (v2022.10)

Sep 16 2022

kalali closed T28762: [Interaction] Remove deprecated / unused interaction files as Resolved.
Sep 16 2022, 11:00 PM · MITK

Sep 15 2022

kalali triaged T29303: IGT classes do not work correctly with the new mxn multi widget as Low priority.
Sep 15 2022, 4:43 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali updated the task description for T29302: Movie maker plugin does not work correctly with the new mxn multi widget.
Sep 15 2022, 3:00 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali triaged T29302: Movie maker plugin does not work correctly with the new mxn multi widget as Low priority.
Sep 15 2022, 2:59 PM · Moved to git.dkfz.de, MITK (v2024.12)

Sep 14 2022

kalali added a comment to T27320: No LocalStorage for PlaneGeometryDataVtkMapper3D.

I quickly looked into this using the experimental state of the mxnMultiWidget but I get a Workbench crash. This might be unrelated so I tested something else:
I used the StdMultiWidget, loaded Pic3D but then I used the Render Window Manager to change the Mapper of the axial render window from 2D Mapper to 3D Mapper.
I get the following crash:

Sep 14 2022, 6:20 PM · MITK, Pull Request
floca added a comment to T26972: Dialog and plugin layout seems to be not shown correctly on laptops.

Could be the same issue like in T28816: [Segmentation] "New Segmentation" dialog to small

Sep 14 2022, 11:13 AM · Moved to git.dkfz.de, MITK (v2024.12), Missing Info
kislinsk triaged T29300: Improve feedback for progress of long running tasks/operations as Wishlist priority.
Sep 14 2022, 11:10 AM · Moved to git.dkfz.de, MITK (v2024.12)
isensee added a comment to T29292: Unsupported pixel types.

Stefan is right that, from the medical perspective, there is no need for these pixel types. And urgently needed not they are. We can easily convert all the files with strange pixel types to files with 'normal' ones. The issue here is simply from a usability/user experience perspective. It is uncommon to me (and probably other as well) to load an image and then get told the pixel type is not supported

Sep 14 2022, 10:26 AM · Request for Discussion, MITK
kalali closed T26496: [mxn multi widget] Re-initializations reset all render windows, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Sep 14 2022, 9:05 AM · Moved to git.dkfz.de, MITK