In T29025#243461, @kalali wrote:I stumbled upon this while working on T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module. I would like to tackle this issue and already started looking into this. Do you already have an idea how to approach it or do we want to discuss it next week?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 6 2022
Nov 6 2022
Nov 4 2022
Nov 4 2022
I stumbled upon this while working on T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module. I would like to tackle this issue and already started looking into this. Do you already have an idea how to approach it or do we want to discuss it next week?
Nov 2 2022
Nov 2 2022
Deleted branch from rMITK MITK: feature/T28578-MxN-development.
Oct 31 2022
Oct 31 2022
- The relevance of the labels list outside models? Perhaps, this entry can be used to describe all labels and their label ids used in the host app. And, models can then refer to label ids in their respective labels entries.
- Lack of consistency in models->labels entries. For some models eg. deepedit there are label ids along with names, effectively assuming a Map datatype and for others, eg. deepgrow_2d it's a list. of label names. This creates unnecessary corner cases while parsing using strongly typed languages, like C++.
- There is no indication in the JSON on which models are interactive click guided, scribble guided or automatic. Eg. Deepedit can be interactive click-guided or automatic, GMM+GraphCut is scribble guided, Segmentation Spleen is purely automatic. Hence, the JSON parameter type can be made more consistent for easy grouping.
Oct 29 2022
Oct 29 2022
kislinsk renamed T29375: Cursor offset in 2D tools with Qt 5.15 on macOS from Cursor offset in 2D tools with Qt 5.12 on macOS to Cursor offset in 2D tools with Qt 5.15 on macOS.
Oct 28 2022
Oct 28 2022
Deleted branch from rMITK MITK: release/T29377-2022-Week-43.
kislinsk closed T29324: Create view for pixel information, a subtask of T25042: How to handle update informations in heterogeneous time geometries and out of bound situations , as Resolved.
kislinsk added a revision to T29324: Create view for pixel information: Restricted Differential Revision.
Pushed new branch to rMITK MITK: release/T29377-2022-Week-43.
Oct 26 2022
Oct 26 2022
kislinsk renamed T29375: Cursor offset in 2D tools with Qt 5.15 on macOS from [Segmentation] Cursor offset in 2D tools with Qt 5.12 on macOS to Cursor offset in 2D tools with Qt 5.12 on macOS.
floca updated the task description for T29374: [SEG] Instant visual response to inverted state of tools (add, substract, paint, wipe).
floca triaged T29374: [SEG] Instant visual response to inverted state of tools (add, substract, paint, wipe) as Normal priority.
Oct 25 2022
Oct 25 2022
Hm, I disagree. :-)
kislinsk edited projects for T29371: [Registration] Improve view icons, added: MITK; removed MITK (v2022.10).
Oct 24 2022
Oct 24 2022
These variables need to point to the location where CMake's find_package() will find the packages. For example, for ITK it would need to point to the equivalent of the MITK-superbuild/ep/lib/cmake/ITK-5.2 folder, where the ITKConfig.cmake and ITKConfigVersion.cmake files are located.
With -DEXTERNAL_ITK_DIR=/usr/local it still downloads and builds ITK.
The superbuild has advanced variables for that:
- EXTERNAL_ITK_DIR
- EXTERNAL_HDF5_DIR
- EXTERNAL_BOOST_ROOT
Oct 23 2022
Oct 23 2022
Oct 21 2022
Oct 21 2022
kislinsk closed T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, a subtask of T28176: [Segmentation] Inspection of module and plugin, as Resolved.
Oct 20 2022
Oct 20 2022
kalali added a revision to T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty: Restricted Differential Revision.
kalali added a comment to T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty.
If D744 is landed, we can close this task. The issue will be addressed here: T29369: [Segmentation Utilities] Handle / select different labels independently.
kalali triaged T29369: [Segmentation Utilities] Handle / select different labels independently as Normal priority.
kalali added a comment to T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty.
With {D744} we only have a single Segmentation Utilities view. Labels operation should be added to this and then the issue of this task needs to be considered.
kalali renamed T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty from [Multilabel Segmentation] "Labels" tabs in operations of Utilities view is empty to [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty.
Oct 17 2022
Oct 17 2022
kalali renamed T29333: [mxn multi widget] Measurements / planar figure not working from [mxn multi widet] Measurements / planar figure not working to [mxn multi widget] Measurements / planar figure not working.
kalali renamed T29365: [mxn multi widget] Pointset interaction not working from [mxn multi widet] Pointset interaction not working to [mxn multi widget] Pointset interaction not working.
kalali edited projects for T29333: [mxn multi widget] Measurements / planar figure not working, added: MITK, Next Milestone; removed MITK (v2022.10).
kalali updated the task description for T29303: IGT classes do not work correctly with the new mxn multi widget.
kalali closed T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor), a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
kalali edited projects for T29240: [mxn multi widget] Allow different time navigation controller for each individual render window, added: MITK, Next Milestone; removed MITK (v2022.10).
kalali closed T29328: Fix different issues with re-initialization, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 14 2022
Oct 14 2022
kalali closed T29203: [Multi widget] Make classes work with the new render window names, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 13 2022
Oct 13 2022
kalali triaged T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly as Normal priority.
Oct 10 2022
Oct 10 2022
Oct 7 2022
Oct 7 2022
kalali added a revision to T29331: Use NodePredicates for the render window data node selector: Restricted Differential Revision.
kalali renamed T29331: Use NodePredicates for the render window data node selector from Use NodePreidcates for the render window data node selector to Use NodePredicates for the render window data node selector.
I looked into this and I was confused: the used QmitkRenderWindowDataStorageTreeModel already contains a node predicate for filtering out the helper nodes. When creating the mxnmultiwidget (or a new render window) there are no plane geometries (the crosshair) being added to the storage model.
kalali triaged T29335: [Segmentation] Show interactive warning for uninitialized render window geometry as Normal priority.
kalali triaged T29331: Use NodePredicates for the render window data node selector as Normal priority.
kalali added a comment to T29298: [mxn multi widget] Add context menu to render window specific data inspector.
A simple context-menu was added in {D726}. Needs to be reworked to allow more actions.
Oct 6 2022
Oct 6 2022
Oct 5 2022
Oct 5 2022
kalali added a comment to T25043: Remove pixel informations from the statusbar and put it into views.
Pixel information has been removed. To add a specific view for pixel information, see T29324: Create view for pixel information.
kalali closed T25043: Remove pixel informations from the statusbar and put it into views, a subtask of T25105: UpdateStatusBar duplicates business logic, as Resolved.
kalali added a comment to T25043: Remove pixel informations from the statusbar and put it into views.
Pixel information has been removed with {D686}. We discussed that we will open a new task to add a simple pixel value information view as a separate task.
kalali added a revision to T28578: [mxn multi widget] Optimization of the mxn multi widget: Restricted Differential Revision.
{D722} also belongs to this task but might not be finished this week.
I added another fix to have a simple datanode context menu with a reinit and reset-geometry action for render-window specific initialization.
floca triaged T29322: [SEG] Refactor code to avoid FillSliceInSlice and FillContourInSlice as High priority.
Oct 4 2022
Oct 4 2022
kalali closed Restricted Maniphest Task, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
I created a first working version, based on @s434n's branch (see above). I created an integration branch, made some changes and rebased everything to the latest develop.
Now the following changes, which are already merged into develop, are included, since the integration branch is based on e4d0b1591a17054b4c6792c235aa41345b842cb7:
- T27613: Improve reinit behavior / {D675}
- T26496: [mxn multi widget] Re-initializations reset all render windows / {D708}
- {T26627} / {D714}
Sep 30 2022
Sep 30 2022
kalali added a revision to T29289: Compare responsibilities of QmitkSliceNavigationController related classes: Restricted Differential Revision.
Sep 28 2022
Sep 28 2022
Thank you 🙏
Here's the first batch of clean-up action. Needs to be continued!
In T24398#241998, @floca wrote:Our side or also the CTK part.
Hm, lets put it as known issue and discuss its priority when we plan the spring release.
floca added a revision to T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures.: Restricted Differential Revision.
Sep 27 2022
Sep 27 2022
thank you for looking into that matter.
floca edited projects for T24398: Dicom plugin: Retrieve does not work, added: MITK, Next Milestone; removed MITK (v2022.10).
In T24398#241991, @kislinsk wrote:I noticed that the whole plugin is a complete mess BTW and urgently needs at least some clean up to see all the potentials for improvements and bug fixes. :/
Our side or also the CTK part.
kalali updated the task description for T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
kalali updated the task description for T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
Sep 21 2022
Sep 21 2022
kalali added a revision to T29265: QmitkSelectableGLWidget is not used anymore and can be removed: Restricted Differential Revision.
Sep 19 2022
Sep 19 2022
I added the PR (https://github.com/MITK/MITK/pull/262/) as a differential.
kalali added a revision to T29219: StatusBar / mouse scrolling is broken: Restricted Differential Revision.
Sep 16 2022
Sep 16 2022
Sep 15 2022
Sep 15 2022
kalali triaged T29303: IGT classes do not work correctly with the new mxn multi widget as Low priority.
kalali updated the task description for T29302: Movie maker plugin does not work correctly with the new mxn multi widget.
kalali triaged T29302: Movie maker plugin does not work correctly with the new mxn multi widget as Low priority.
Sep 14 2022
Sep 14 2022
I quickly looked into this using the experimental state of the mxnMultiWidget but I get a Workbench crash. This might be unrelated so I tested something else:
I used the StdMultiWidget, loaded Pic3D but then I used the Render Window Manager to change the Mapper of the axial render window from 2D Mapper to 3D Mapper.
I get the following crash:
floca added a comment to T26972: Dialog and plugin layout seems to be not shown correctly on laptops.
Could be the same issue like in T28816: [Segmentation] "New Segmentation" dialog to small
kislinsk triaged T29300: Improve feedback for progress of long running tasks/operations as Wishlist priority.
Stefan is right that, from the medical perspective, there is no need for these pixel types. And urgently needed not they are. We can easily convert all the files with strange pixel types to files with 'normal' ones. The issue here is simply from a usability/user experience perspective. It is uncommon to me (and probably other as well) to load an image and then get told the pixel type is not supported