Page MenuHomePhabricator
Feed All Stories

May 26 2021

s434n triaged T28510: [Segmentation Utilities] Switched definitions in documentation as Normal priority.
May 26 2021, 5:19 PM · MITK
k656s added a member for NLP: s539y.
May 26 2021, 2:13 PM

May 25 2021

isensee updated the task description for T28500: Multilabel Segmentation Utilities do not work for multilabel segmentations.
May 25 2021, 11:14 AM · MITK (v2024.06), Missing Info
isensee created T28500: Multilabel Segmentation Utilities do not work for multilabel segmentations.
May 25 2021, 11:13 AM · MITK (v2024.06), Missing Info
gaoh closed T28380: [MultLabel Segmentation, MITK FlowBench] Segmentation not recognized as segmentation in Release v2021.02 as Resolved.
May 25 2021, 9:26 AM · MITK

May 24 2021

floca claimed T27684: [Segmentation] Improve Region Growing 2D algorithm and interaction.
May 24 2021, 12:26 PM · MITK (v2024.06)
floca added a parent task for T27684: [Segmentation] Improve Region Growing 2D algorithm and interaction: T28499: Refactor/rewrite RegionGrowing3D tool.
May 24 2021, 10:38 AM · MITK (v2024.06)
floca added a parent task for T27872: [Segmentation] Region Growing 3D GUI does not provide a "Overwrite" checkbox: T28499: Refactor/rewrite RegionGrowing3D tool.
May 24 2021, 10:38 AM · MITK (v2022.10), Cleared
floca added subtasks for T28499: Refactor/rewrite RegionGrowing3D tool: T28275: [Segmentation] AdaptiveRegionGrowingTool must be refactored / 4D Segmentation returns error message when point is not on the correct timestep, T27872: [Segmentation] Region Growing 3D GUI does not provide a "Overwrite" checkbox, T27684: [Segmentation] Improve Region Growing 2D algorithm and interaction.
May 24 2021, 10:38 AM · MITK (v2024.06)
floca added a parent task for T28275: [Segmentation] AdaptiveRegionGrowingTool must be refactored / 4D Segmentation returns error message when point is not on the correct timestep: T28499: Refactor/rewrite RegionGrowing3D tool.
May 24 2021, 10:38 AM · MITK (v2024.06)
floca triaged T28499: Refactor/rewrite RegionGrowing3D tool as High priority.
May 24 2021, 10:37 AM · MITK (v2024.06)

May 20 2021

norajitr added a comment to T28232: Shapemodels.

Hey Marco, I had uploaded the models there back in the days:

May 20 2021, 4:21 PM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
isensee added a comment to T28493: Multilabel color map colors are not very nice.
import numpy as np
import colorsys
from skimage import io
May 20 2021, 9:43 AM · Checklist, Request for Discussion, MITK (v2022.04)
isensee created T28493: Multilabel color map colors are not very nice.
May 20 2021, 9:19 AM · Checklist, Request for Discussion, MITK (v2022.04)

May 19 2021

Lafebre created T28492: Renderer interaction hangs in PACS mode when using keyboard modifiers.
May 19 2021, 2:33 PM · MITK
kalali moved T28490: Segmentation plugin: "new" segmentation should not run reinit! from Backlog to Segmentation on the MITK (v2021.10) board.
May 19 2021, 11:51 AM · Cleared, MITK (v2021.10)
kalali triaged T28490: Segmentation plugin: "new" segmentation should not run reinit! as High priority.

I agree on that. I had some problems with that with the new mxn-multiwidget. The topic was also mentioned in T27613: Improve reinit behavior.

May 19 2021, 11:51 AM · Cleared, MITK (v2021.10)
gaoh reopened T28380: [MultLabel Segmentation, MITK FlowBench] Segmentation not recognized as segmentation in Release v2021.02 as "Open".

The same issue seems to apply to the normal workbench, so this container has also to be updated to the current master

May 19 2021, 11:36 AM · MITK
isensee updated the task description for T28491: [Segmentation] Slice interpolation 'confirm for all slices' sometimes crahes.
May 19 2021, 10:12 AM · MITK (v2023.12)
isensee created T28491: [Segmentation] Slice interpolation 'confirm for all slices' sometimes crahes.
May 19 2021, 8:11 AM · MITK (v2023.12)
isensee updated the task description for T28490: Segmentation plugin: "new" segmentation should not run reinit!.
May 19 2021, 7:51 AM · Cleared, MITK (v2021.10)
isensee created T28490: Segmentation plugin: "new" segmentation should not run reinit!.
May 19 2021, 7:51 AM · Cleared, MITK (v2021.10)
isensee created T28489: int64 not supported.
May 19 2021, 7:40 AM · MITK

May 17 2021

s434n claimed T28472: [Geldosimetry] Add editing options to calibration table.
May 17 2021, 12:21 PM · Restricted Project, Restricted Project
nolden added a comment to T28232: Shapemodels.

Thanks. I think restricted access to code and models makes a big difference in the sense of preparatory work, code cleaning. model licensing etc.. ;) So that's why we thought it would be good first step to resolve all technical issues. Moving code and models to a public location would be another thing then.

May 17 2021, 11:28 AM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
schererj added a comment to T28232: Shapemodels.

Ok, but this makes not a big difference, right?
Here's what I think would be good for us:

  • A single Dockerfile build-able without any local files
  • The needed source-code should be downloaded via a direct git clone within the Dockerfile
  • Internal usage would allow to pass credentials as build-args to git
  • Models should be downloaded via curl during the build-process as well
  • There should be two stages:
    1. Download and build source-code + download and unzip models
    2. Execution environment (incl. the models) - but without build dependencies, build tree etc
May 17 2021, 11:21 AM · Auto-closed, Kaapana (internal), Request for Discussion, MITK

May 15 2021

floca closed T28487: MitkMRSignal2Concentration MiniApp does not correctly handles exceptions in app configuration step as Resolved by committing rMITK4e0dbe476383: Fixed T28487.
May 15 2021, 12:12 PM · MITK
floca committed rMITK4e0dbe476383: Fixed T28487 (authored by floca).
Fixed T28487
May 15 2021, 12:12 PM
floca added a comment to T28487: MitkMRSignal2Concentration MiniApp does not correctly handles exceptions in app configuration step.

Pushed new branch to rMITK MITK: bugfix/T28487-MitkMRSignal2Concentration_handle_exceptions.

May 15 2021, 12:10 PM · MITK
floca triaged T28487: MitkMRSignal2Concentration MiniApp does not correctly handles exceptions in app configuration step as Normal priority.
May 15 2021, 12:05 PM · MITK

May 14 2021

nolden added a comment to T28232: Shapemodels.

Thanks @schererj , maybe one information was missing: as a first step we thought about making this build-able internally, so as part of the Kaapana/Dcipher-internal repo (option 2 in my comment above from March 25th)

May 14 2021, 12:41 PM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
floca committed rMITK540f9ce6f8f4: T28248 Refactor picking tool (authored by floca).
T28248 Refactor picking tool
May 14 2021, 12:28 PM
floca committed rMITK148d43a825c1: Updated picking tool screenshot (authored by floca).
Updated picking tool screenshot
May 14 2021, 12:28 PM
floca committed rMITK8532f8f56985: Fixed review remarks (authored by floca).
Fixed review remarks
May 14 2021, 12:27 PM
floca committed rMITK5ceb625e0fc4: Fixed T26970 (authored by floca).
Fixed T26970
May 14 2021, 12:27 PM
floca committed rMITK88c58d855c19: Changed behavior of AutoSegmentationWithPreviewTool when not overwritting the… (authored by floca).
Changed behavior of AutoSegmentationWithPreviewTool when not overwritting the…
May 14 2021, 12:27 PM
floca closed T26970: [Segmentation] Picking tool: When no region is picked, selected node just gets unselected as Resolved by committing rMITK5ceb625e0fc4: Fixed T26970.
May 14 2021, 12:27 PM · MITK (v2021.10), Cleared
floca closed T26970: [Segmentation] Picking tool: When no region is picked, selected node just gets unselected, a subtask of T28248: [Segmentation] Picking 3D Tool creates a 3D segmentation out of a 4D image, as Resolved.
May 14 2021, 12:27 PM · MITK (v2021.10)
floca committed rMITK7f5b4f962ac6: Refactored PickingTool and its UI. (authored by floca).
Refactored PickingTool and its UI.
May 14 2021, 12:27 PM
floca committed rMITKe9f414f7e792: Fixed gcc compile errors (authored by floca).
Fixed gcc compile errors
May 14 2021, 12:27 PM
floca closed T28248: [Segmentation] Picking 3D Tool creates a 3D segmentation out of a 4D image as Resolved by committing rMITK7f5b4f962ac6: Refactored PickingTool and its UI..
May 14 2021, 12:27 PM · MITK (v2021.10)
floca committed rMITKa3aa5679e0c9: BREAKING! Changed signature of mitk::AutoSegmentationWithPreviewTool… (authored by floca).
BREAKING! Changed signature of mitk::AutoSegmentationWithPreviewTool…
May 14 2021, 12:27 PM
floca committed rMITKa3e1edc80b03: BREAKING! Member mitk::Tool::m_ToolManager is now private (authored by floca).
BREAKING! Member mitk::Tool::m_ToolManager is now private
May 14 2021, 12:27 PM

May 12 2021

floca committed rOBSHYPPOPY905460839b8c: Some smaller additions and proposals to the draft. (authored by floca).
Some smaller additions and proposals to the draft.
May 12 2021, 8:36 PM
schererj added a comment to T28232: Shapemodels.

The problem is the MBI branch, which is afaik not public.
If there is a working Dockerfile, which can be publicly build, I'm happy to include it.
Additionally the models need to be put somewhere to be downloaded (also public in this case).
Hope this helps.

May 12 2021, 4:53 PM · Auto-closed, Kaapana (internal), Request for Discussion, MITK

May 11 2021

kalali added a comment to T28204: Refactor LevelWindowManagerTest.

So I modified the "Assert"-functions to directly encapsule the CPPUNIT_ASSERT_MESSAGE calls in that function as you suggested. The error still occurs and now the problem is that I can't see where the error occurs because it happens inside the "Assert"-function (which is the same for each test). So that is not an option. Any other suggestions? I could split the test to test each node individually.

May 11 2021, 2:08 PM · MITK (v2021.10)
kalali added a comment to T28204: Refactor LevelWindowManagerTest.

Ok so I found a bug for the test in line 320. This showed some complex behavior with the level window manager, which I don't want to address here.
However, the test in line 288 still randomly fails - when debugging in that line the test does not fail but fails in line 292.

May 11 2021, 12:26 PM · MITK (v2021.10)
kalali added a comment to T28204: Refactor LevelWindowManagerTest.

Yes, I agree that this is not the most straight forward way to do it. There was a reasoning behind it to do it that way.
I will think about it - but currently it seems as if something is not correct with the tests, in a way that I am actually expecting wrong test results - so I need to rethink the expected results and change the true / false arguments accordingly.

May 11 2021, 10:58 AM · MITK (v2021.10)
kislinsk added a comment to T28204: Refactor LevelWindowManagerTest.

Hm, I cannot answer this without looking into this in detail but a first step could be to improve the AssertImageForLevelWindowProperty function or maybe even encapsule the CPPUNIT_ASSERT_MESSAGE calls in that function instead the other way around since the error message one does receive currently doesn't tell much about what actually failed since it could be any or all of the three checks.

May 11 2021, 10:51 AM · MITK (v2021.10)

May 10 2021

nolden added a comment to T28232: Shapemodels.

@norajitr thanks for the follow up. Could you attach the two (?) Dockerfiles here and post the network drive path? Maybe someone else from Kaapana (internal) could have a look then, too.

May 10 2021, 5:20 PM · Auto-closed, Kaapana (internal), Request for Discussion, MITK
floca added a comment to T28455: RT struct 3D visibility is not working correctly.

like to discuss this one.Why is there even two completely separate ways of loading the same dataset? Does this make sense?

I can not tell ad hoc which code would makes more sense. But I can tell directly that it makes no sense that the loading mechanisms execute different code to populate the properties. We had a simelar problem with doses once.

May 10 2021, 5:11 PM · MITK (v2021.10)
kalali added a comment to T28204: Refactor LevelWindowManagerTest.

Since I modified and merged T28250 I wanted to continue here. I still get failed tests in line 288 and in line 320:

assertion failed
- Expression: AssertImageForLevelWindowProperty(false, true, false)
- "imageForLevelWindow" property not correctly set
assertion failed
- Expression: AssertImageForLevelWindowProperty(true, false, false)
- "imageForLevelWindow" property not correctly set
May 10 2021, 4:21 PM · MITK (v2021.10)
kleina added a project to T28455: RT struct 3D visibility is not working correctly: Request for Discussion.
May 10 2021, 3:12 PM · MITK (v2021.10)
kleina updated subscribers of T28455: RT struct 3D visibility is not working correctly.

I narrowed it down.

May 10 2021, 3:11 PM · MITK (v2021.10)
kleina added a comment to T28455: RT struct 3D visibility is not working correctly.

If you load a RTStruct via DICOMBrwoser, the node has a special "visible" property for stdmulti.widget3 (the 3D view). You can enable/disbale it via the Properties plugin. #Workaround :-P

May 10 2021, 11:51 AM · MITK (v2021.10)
kleina added a comment to T28455: RT struct 3D visibility is not working correctly.

Ok, we tested it on several machines and it is as described above: After loading via DICOM Browser we can confirm the issue.

May 10 2021, 11:32 AM · MITK (v2021.10)
kalali moved T28204: Refactor LevelWindowManagerTest from Backlog to Cycle on the MITK (v2021.10) board.
May 10 2021, 11:00 AM · MITK (v2021.10)
kalali edited projects for T28204: Refactor LevelWindowManagerTest, added: MITK (v2021.10); removed MITK.
May 10 2021, 11:00 AM · MITK (v2021.10)
kleina added a comment to T28455: RT struct 3D visibility is not working correctly.

@s434n and I tried this on Windows and Linux. It looks like, if you load the data via "classical drag'n'drop", it works as expected. If we use the DICOM browser to load the exact same dataset, we can reproduce @nolden's issue.

May 10 2021, 10:43 AM · MITK (v2021.10)
kalali closed T28250: [LevelWindowManager] Different behavior in AutoTopMost case and fallback case as Resolved.
May 10 2021, 10:36 AM · Breaking Change, MITK (v2021.10)
kalali committed rMITKbe464bfe51da: T28250 Level window manager update function not consistent (authored by kalali).
T28250 Level window manager update function not consistent
May 10 2021, 10:35 AM
kalali committed rMITKebf8757b2828: Make protected members private; remove comments (authored by kalali).
Make protected members private; remove comments
May 10 2021, 10:35 AM
kalali committed rMITK9751f1d41d9c: Use return early to simplify the code structure (authored by kalali).
Use return early to simplify the code structure
May 10 2021, 10:35 AM
kalali committed rMITK1d0306cddd48: Rename vector of data nodes (authored by kalali).
Rename vector of data nodes
May 10 2021, 10:35 AM
kalali committed rMITK1ea1daa42d05: Use "auto" to simplify the code (authored by kalali).
Use "auto" to simplify the code
May 10 2021, 10:35 AM
kalali committed rMITKc1756ccd4526: Remove "levelwindow"-property check (authored by kalali).
Remove "levelwindow"-property check
May 10 2021, 10:35 AM

Query Overheated

This query took too long, so only some results are shown. Learn More