Page MenuHomePhabricator
Feed All Stories

Jan 23 2021

floca triaged T28192: [Registration] Auto selection (and listening) in MatchPoint views as Normal priority.
Jan 23 2021, 2:56 PM · Moved to git.dkfz.de, MITK
kislinsk added a revision to T27992: Release of MITK CLIs: Unknown Object (Differential Revision).
Jan 23 2021, 8:51 AM · MITK (v2021.02), Request for Discussion
kislinsk added a comment to T27992: Release of MITK CLIs.

Pushed new branch to rMITK MITK: feature/T27992-CmdLineAppsInWorkbenchReleaseConfig.

Jan 23 2021, 8:47 AM · MITK (v2021.02), Request for Discussion
kislinsk claimed T27992: Release of MITK CLIs.

I asked in the general Slack channel for command-line apps in use. It boils down to the file converters in CoreCmdApps. Other mentions are too specific for the WorkbenchRelease configuration and are related to the Classification module. We should consider adding a phenotyping build configuration, though.

Jan 23 2021, 8:29 AM · MITK (v2021.02), Request for Discussion
kislinsk edited the content of 2021 Week 04 (Very Late January).
Jan 23 2021, 8:16 AM
kislinsk edited the content of 2021 Week 04 (Very Late January).
Jan 23 2021, 8:15 AM
kislinsk edited the content of 2021 Week 04 (Very Late January).
Jan 23 2021, 8:03 AM

Jan 22 2021

kislinsk edited the content of 2021 Week 04 (Very Late January).
Jan 22 2021, 9:49 PM
kislinsk created an object: 2021 Week 04 (Very Late January).
Jan 22 2021, 8:56 PM
eisenman added a comment to T28100: [dash] Decide on a file management strategy.

Files that cannot be read by a CSV reader should be deleted immediately to avoid that potentially malicious resources are hosted on this public server. A simple check for file extension is not enough. Arbitrary files can be uploaded by just adding the extension *.csv.

Jan 22 2021, 7:45 PM · webChallengeR
kalali triaged T28191: Refactor and extend LevelWindow unit tests as High priority.
Jan 22 2021, 5:26 PM · Auto-closed, MITK
kalali added a comment to T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification .

I looked through the checklist and updated it to be in line with the already updated checklists (see parent task T28108).
I copied the modified document to E130-Daten\Release\Checklisten\MITK Workbench Release.

Jan 22 2021, 5:21 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali reopened T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change as "Open".

The issue has already been reported here T26754 and here T22395, so I will merge the task here.

Jan 22 2021, 3:43 PM · Request for Discussion, MITK (v2021.10)
kalali reopened T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change, a subtask of T28176: [Segmentation] Inspection of module and plugin, as Open.
Jan 22 2021, 3:43 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali merged T22395: Live wire tool deactivate leads to confirm segmentation into T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change.
Jan 22 2021, 3:43 PM · Request for Discussion, MITK (v2021.10)
kalali merged task T22395: Live wire tool deactivate leads to confirm segmentation into T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change.
Jan 22 2021, 3:43 PM · MITK, Restricted Project
kalali merged task T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change into T22395: Live wire tool deactivate leads to confirm segmentation.
Jan 22 2021, 3:42 PM · Request for Discussion, MITK (v2021.10)
kalali merged T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change into T22395: Live wire tool deactivate leads to confirm segmentation.
Jan 22 2021, 3:42 PM · MITK, Restricted Project
kalali moved T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification from Backlog to Test/Checklists on the MITK (v2021.02) board.
Jan 22 2021, 12:46 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali moved T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 22 2021, 12:45 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali added a subtask for T28108: [Release Checklists] Prepare release checklists: T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification .
Jan 22 2021, 12:44 PM · MITK
kalali added a parent task for T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification : T28108: [Release Checklists] Prepare release checklists.
Jan 22 2021, 12:44 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali claimed T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification .
Jan 22 2021, 12:43 PM · Moved to git.dkfz.de, MITK (v2024.12)

Jan 21 2021

floca awarded T27460: Badge support for our CDash/CI infrastructure a Like token.
Jan 21 2021, 9:49 PM · CI, MITK
kislinsk closed T27460: Badge support for our CDash/CI infrastructure as Resolved.

Screenshot from the MITK Github page:

Jan 21 2021, 9:46 PM · CI, MITK
kislinsk added a comment to T27460: Badge support for our CDash/CI infrastructure.

Deleted branch from rMITK MITK: feature/T27460-Badges.

Jan 21 2021, 9:43 PM · CI, MITK
kislinsk committed rMITK6f13f0b05069: Add build status badges for develop branch (authored by kislinsk).
Add build status badges for develop branch
Jan 21 2021, 9:42 PM
kislinsk committed rMITKdef61b42c799: Merge branch 'feature/T27460-Badges' into develop (authored by kislinsk).
Merge branch 'feature/T27460-Badges' into develop
Jan 21 2021, 9:42 PM
kislinsk added a comment to T27460: Badge support for our CDash/CI infrastructure.

Pushed new branch to rMITK MITK: feature/T27460-Badges.

Jan 21 2021, 9:42 PM · CI, MITK
kalali added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.

Ok, I modified T27498#208164 to update the missing views. I say, for the release we leave the utilities the way they are (your option 1. keep it as is: user has to select manually). We keep an eye on it if this leads to some confusion.
SemanticRelations is not relevant for the release so I'll put this in another task.

Jan 21 2021, 5:10 PM · Restricted Project, MITK (v2021.02)
kislinsk closed T28189: [MITKDoc] Fix documentation warnings as Resolved.
Jan 21 2021, 1:15 PM · MITK (v2021.02)
kislinsk added a comment to T28189: [MITKDoc] Fix documentation warnings.

Deleted branch from rMITK MITK: bugfix/T28189-FixDoxygenWarnings.

Jan 21 2021, 1:14 PM · MITK (v2021.02)
kislinsk committed rMITK71a34b8570cf: Fix doxygen warnings (authored by kislinsk).
Fix doxygen warnings
Jan 21 2021, 1:14 PM
kislinsk committed rMITK56edf255d20b: Merge branch 'bugfix/T28189-FixDoxygenWarnings' into develop (authored by kislinsk).
Merge branch 'bugfix/T28189-FixDoxygenWarnings' into develop
Jan 21 2021, 1:14 PM
kislinsk committed rMITKf1758c202dba: Fix doxygen warnings (authored by kislinsk).
Fix doxygen warnings
Jan 21 2021, 12:43 PM
kislinsk committed rMITK91703725ae84: Merge branch 'bugfix/T28189-FixDoxygenWarnings' into develop (authored by kislinsk).
Merge branch 'bugfix/T28189-FixDoxygenWarnings' into develop
Jan 21 2021, 12:43 PM
kislinsk added a comment to T28189: [MITKDoc] Fix documentation warnings.

Pushed new branch to rMITK MITK: bugfix/T28189-FixDoxygenWarnings.

Jan 21 2021, 12:42 PM · MITK (v2021.02)
kislinsk triaged T28189: [MITKDoc] Fix documentation warnings as Normal priority.
Jan 21 2021, 12:41 PM · MITK (v2021.02)
kislinsk closed T28187: Automatically build and deploy MITK releases as Resolved.

I used the snapshot client configurations as baseline and created Jenkins jobs in MITK/Release. I also extended the Git hook to trigger these jobs. Hard to test, though, as I do not want to temporarily push test tags. Fingers crossed.

Jan 21 2021, 11:59 AM · CI, MITK (v2021.02)
t391x created T28188: Integration of PyTorch Delay and Sum into Simpa.
Jan 21 2021, 11:36 AM · Photoacoustics, IMSY
kislinsk triaged T28187: Automatically build and deploy MITK releases as High priority.
Jan 21 2021, 11:32 AM · CI, MITK (v2021.02)
schererj moved T28127: Reopen segmentation in MITK from Discussion to Backlog on the Kaapana (internal) board.
Jan 21 2021, 9:47 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)
nolden renamed T28159: Officially support MITK using system Qt from Oficially support MITK using system Qt to Officially support MITK using system Qt.
Jan 21 2021, 9:41 AM · Auto-closed, CI, Request for Discussion, MITK
s669m moved T28169: TFDA MVP v1 powered by Kaapana from Discussion to In Progress on the Kaapana (internal) board.
Jan 21 2021, 9:40 AM · Kaapana (internal)
s669m updated the task description for T28169: TFDA MVP v1 powered by Kaapana.
Jan 21 2021, 9:40 AM · Kaapana (internal)
s669m closed T28168: TFDA Code Repo Creation as Resolved.
Jan 21 2021, 9:40 AM · Kaapana (internal)
s669m moved T28168: TFDA Code Repo Creation from Discussion to Resolved on the Kaapana (internal) board.
Jan 21 2021, 9:39 AM · Kaapana (internal)
schererj moved T28159: Officially support MITK using system Qt from Discussion to Backlog on the Kaapana (internal) board.
Jan 21 2021, 9:39 AM · Auto-closed, CI, Request for Discussion, MITK
nolden added a comment to T28159: Officially support MITK using system Qt.

@kislinsk anyone from the MITK CI team who could take over?

Jan 21 2021, 9:38 AM · Auto-closed, CI, Request for Discussion, MITK
schererj moved T28159: Officially support MITK using system Qt from Backlog to Discussion on the Kaapana (internal) board.
Jan 21 2021, 9:27 AM · Auto-closed, CI, Request for Discussion, MITK
schererj moved T28127: Reopen segmentation in MITK from Backlog to Discussion on the Kaapana (internal) board.
Jan 21 2021, 9:27 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)
s669m updated the task description for T28169: TFDA MVP v1 powered by Kaapana.
Jan 21 2021, 9:19 AM · Kaapana (internal)
s669m renamed T28169: TFDA MVP v1 powered by Kaapana from TFDA MVP v1 to TFDA MVP v1 powered by Kaapana.
Jan 21 2021, 9:19 AM · Kaapana (internal)

Jan 20 2021

floca added a comment to T28127: Reopen segmentation in MITK.
In T28127#217604, @gaoh wrote:

@floca I might have found a dataset, where even the new number is not enough:
P:\Gao\mitk-testdata\

Jan 20 2021, 9:46 PM · MITK (v2021.02), Restricted Project, Kaapana (internal)
gaoh reopened T28127: Reopen segmentation in MITK as "Open".

@floca I might have found a dataset, where even the new number is not enough:
edit:
E130-Personal:\Gao\mitk-testdata\

Jan 20 2021, 9:44 PM · MITK (v2021.02), Restricted Project, Kaapana (internal)
floca added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.

Hm, interesting... I say we but it under the category experience and close that chapter. If it reoccures we see how to handle it. Thanks for investigating it.

Jan 20 2021, 8:27 PM · Restricted Project, MITK (v2021.02)
kalali added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.

Something strange happened:
I wanted to test some GUI functionality for your open diff but somehow I was not able to load data anymore: Clicking on Open File did not open a window.
Then I removed the DKFZ AppData folder to have a fresh MITK workbench. Now clicking on Open File opened a window but while I was scrolling inside this window to find the desired data, the window stopped working (did not scroll anymore - whole application was frozen).
So I did a Windows restart and opened MITK again. Now I am able to load data again and Voila: The segmentation view now automatically selects the newly added data node (patient image selector).
...
...
Tbh, I have no clue what's going on.

Jan 20 2021, 6:09 PM · Restricted Project, MITK (v2021.02)
floca committed rMITK52adb58300dd: T27689 RTDose_image_cannot_be_serialized_and_workbench_crashes_upon_loading (authored by floca).
T27689 RTDose_image_cannot_be_serialized_and_workbench_crashes_upon_loading
Jan 20 2021, 5:27 PM
floca committed rMITKadb6d06ec088: Fixed T27689 (authored by floca).
Fixed T27689
Jan 20 2021, 5:27 PM
floca closed T27689: RTDose image can not be serialized and workbench crashes upon loading as Resolved by committing rMITKadb6d06ec088: Fixed T27689.
Jan 20 2021, 5:27 PM · Request for Discussion, MITK
floca committed rMITKbac2bebfaee6: Prevent that serialization errors of single properties lead to a failed write… (authored by floca).
Prevent that serialization errors of single properties lead to a failed write…
Jan 20 2021, 5:27 PM
floca committed rMITKb0a993ea0c4b: Code clean up (dead code) (authored by floca).
Code clean up (dead code)
Jan 20 2021, 5:27 PM
floca committed rMITK9919ca949962: Changed to Point3dProperty to use existing serializer. (authored by floca).
Changed to Point3dProperty to use existing serializer.
Jan 20 2021, 5:27 PM
floca committed rMITKbb5f99527044: Changed to DoubleProperty to support existing serializers (authored by floca).
Changed to DoubleProperty to support existing serializers
Jan 20 2021, 5:27 PM
groehl removed a member for IMSY: groehl.
Jan 20 2021, 3:29 PM
groehl removed a member for Photoacoustics: groehl.
Jan 20 2021, 3:28 PM
groehl added a member for Photoacoustics: jgroehl.
Jan 20 2021, 3:28 PM
groehl removed a watcher for IMSY: groehl.
Jan 20 2021, 3:28 PM
groehl added a member for IMSY: jgroehl.
Jan 20 2021, 3:27 PM
onogur added a member for IMSY: odile.
Jan 20 2021, 11:14 AM
gaoh moved T28127: Reopen segmentation in MITK from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 20 2021, 10:32 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)

Jan 19 2021

fedorov added a comment to T28127: Reopen segmentation in MITK.

@floca thanks for the report! I added a comment to the dcmqi issue you created.

Jan 19 2021, 4:27 PM · MITK (v2021.02), Restricted Project, Kaapana (internal)
kalali triaged T28181: [Segmentation] Should warning messages be passed on to the UI? as Normal priority.
Jan 19 2021, 3:57 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.

I'm currently on the latest develop (rMITK15ecdf8d92aa). Only a small set of plugins enabled (datastorageviewertest, (ML)segmentation, imagenavigator).
I'm doing this in Debug mode.

Jan 19 2021, 3:19 PM · Restricted Project, MITK (v2021.02)
nolden committed rMITK15ecdf8d92aa: Update DCMQI to v1.2.3 (authored by nolden).
Update DCMQI to v1.2.3
Jan 19 2021, 2:54 PM
nolden committed rMITKad45666d2a3f: Update DCMQI to v1.2.3 (authored by nolden).
Update DCMQI to v1.2.3
Jan 19 2021, 2:54 PM
floca added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.

I just came across this again:
For me the following happens:

  1. I open the MITK workbench
  2. open the Segementation View
  3. below the image selectors a warning Please select an image is shown
  4. both image selectors show a red warning
  5. I open an image e.g. US4DCyl.nrrd
  6. the warning below the image selectors changes to Select or create a segmentation
  7. both image selectors still show a red warning
  8. the image is not automatically selected
Jan 19 2021, 2:44 PM · Restricted Project, MITK (v2021.02)
floca closed T27703: [Segmentation] Watershed segmentation crashes on images when high threshold is chosen as Resolved.

Is this solved?

As far as I have described above, yes.

Jan 19 2021, 2:38 PM · MITK
kalali closed T18967: Segmentation warnings replace each other as Invalid.
  1. The new selection concept automatically removes non-matching segmentation nodes if the reference image was changed. A warning is shown Select or create a segmentation (Tools disabled)
  2. The new selection concept does not allow to select a non-matching segmentation node
  3. Selecting a matching segmentation node that is invisible results in the warning: The selected segmentation is currently not visible! (Tools disabled)
  4. Showing the invisible segmentation node results in the warning: Please perform a reinit on the segmentation image! (Tools disabled)
  5. Performing a reinit on the matching segmentation node enables the tools (no warning shown)
Jan 19 2021, 2:35 PM · MITK, Bugzilla
kalali triaged T28180: [Segmentation] Showing a previously hidden reference image requires a reinit as Normal priority.
Jan 19 2021, 2:33 PM · MITK (v2022.10)
s669m renamed T28169: TFDA MVP v1 powered by Kaapana from TFDA MVP v2 to TFDA MVP v1.
Jan 19 2021, 1:16 PM · Kaapana (internal)
s669m renamed T28169: TFDA MVP v1 powered by Kaapana from TFDA (Kaapana) Multi-Provider site version (a.k.a) Central Instance to TFDA MVP v2.
Jan 19 2021, 1:02 PM · Kaapana (internal)
kalali claimed T18967: Segmentation warnings replace each other.

We are now using a different approach but this should be verified with the new widgets.

Jan 19 2021, 12:40 PM · MITK, Bugzilla
kislinsk added a revision to T28174: Fix minor C++ style issues: Unknown Object (Differential Revision).
Jan 19 2021, 12:39 PM · MITK
kalali added a subtask for T28176: [Segmentation] Inspection of module and plugin: T26969: [Segmentation] New segmentation dialog: Change color twice and aborting the second time chages color to red.
Jan 19 2021, 12:39 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali added a parent task for T26969: [Segmentation] New segmentation dialog: Change color twice and aborting the second time chages color to red: T28176: [Segmentation] Inspection of module and plugin.
Jan 19 2021, 12:39 PM · MITK
kalali added a comment to T27703: [Segmentation] Watershed segmentation crashes on images when high threshold is chosen.

Is this solved?

Jan 19 2021, 12:38 PM · MITK
kalali added a parent task for T27149: [Segmentation] Interpolation nodes / position nodes are not correctly hidden: T28176: [Segmentation] Inspection of module and plugin.
Jan 19 2021, 12:37 PM · MITK (v2024.12)
kalali added a subtask for T28176: [Segmentation] Inspection of module and plugin: T27149: [Segmentation] Interpolation nodes / position nodes are not correctly hidden.
Jan 19 2021, 12:37 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali added a parent task for T27060: [Segmentation] Rework InterpolationWidget to not depend on data manager view directly: T28176: [Segmentation] Inspection of module and plugin.
Jan 19 2021, 12:37 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali added a subtask for T28176: [Segmentation] Inspection of module and plugin: T27060: [Segmentation] Rework InterpolationWidget to not depend on data manager view directly.
Jan 19 2021, 12:37 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali added a comment to T27883: [Segmentation] Crash and interpolation issues in static segmentation on reference image with strange arbitrary time geometry (3d+t heart).

Need to recheck after T28118: Refactoring of SegTool2D is done.

Jan 19 2021, 12:36 PM · MITK (v2021.02)
kalali added a subtask for T28176: [Segmentation] Inspection of module and plugin: T27913: [Segmentation] Warnings in utilities view are inconsistent.
Jan 19 2021, 12:35 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali added a parent task for T27913: [Segmentation] Warnings in utilities view are inconsistent: T28176: [Segmentation] Inspection of module and plugin.
Jan 19 2021, 12:35 PM · MITK (v2024.06)
kalali added a subtask for T28176: [Segmentation] Inspection of module and plugin: T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change.
Jan 19 2021, 12:35 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali added a parent task for T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change: T28176: [Segmentation] Inspection of module and plugin.
Jan 19 2021, 12:35 PM · Request for Discussion, MITK (v2021.10)
kalali added a subtask for T28176: [Segmentation] Inspection of module and plugin: T27711: Rename segmentation image selection label.
Jan 19 2021, 12:33 PM · Moved to git.dkfz.de, MITK (v2024.12)
kalali added a parent task for T27711: Rename segmentation image selection label: T28176: [Segmentation] Inspection of module and plugin.
Jan 19 2021, 12:33 PM · MITK (v2021.10)
kalali added a parent task for T27713: [Segmentation] Disable "New" button when no image is selected: T28176: [Segmentation] Inspection of module and plugin.
Jan 19 2021, 12:33 PM · MITK (v2021.10), Request for Discussion
kalali added a subtask for T28176: [Segmentation] Inspection of module and plugin: T27713: [Segmentation] Disable "New" button when no image is selected.
Jan 19 2021, 12:33 PM · Moved to git.dkfz.de, MITK (v2024.12)