Page MenuHomePhabricator
Feed All Stories

Sep 9 2019

kislinsk triaged T26654: Github pull request 239 (Check filename for invalid characters before saving e.g. "a:b.obj") as Normal priority.

Requested code changes in pull request.

Sep 9 2019, 11:56 AM · MITK, Pull Request
kislinsk placed T26427: Support software rendering up for grabs.
Sep 9 2019, 11:39 AM · Auto-closed, MITK
kislinsk closed T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal) as Resolved.

Merged into releases/2018-04.

Sep 9 2019, 11:38 AM · MITK, Pull Request
kislinsk added a comment to T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal).

Pushed new branch T26655-GizmoFix.

Sep 9 2019, 11:37 AM · MITK, Pull Request
kislinsk triaged T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal) as Low priority.
Sep 9 2019, 11:37 AM · MITK, Pull Request
kislinsk triaged T26656: Gitlab pull request 238 (Avoid collapsing 'Properties' view when editing child-properties (e.g. "material.something")) as Low priority.

Not yet working. Tree doesn't collapse only the first time.

Sep 9 2019, 11:34 AM · MITK, Pull Request
bonekamp committed rPROUNETb3b2b5e8d6f3: change LGPL3 to GPL3 (authored by bonekamp).
change LGPL3 to GPL3
Sep 9 2019, 10:49 AM
kompan added a member for SIDT: c082x.
Sep 9 2019, 10:41 AM

Sep 6 2019

floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Apologies, but I am not sure I understand your first questions, but given your last statement:

No problem. A now fixed typo made it hard to understand.

Sep 6 2019, 9:26 PM · MITK
kausch added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

Yes, unfortunately the current solution only works for first level.

Sep 6 2019, 9:58 AM · Bugzilla, Pull Request, MITK

Sep 5 2019

tan14007 merged task T26666: Deprecation of QObject::trUtf8 in "Modules/AppUtil/src/QmitkSafeNotify.h" into T26643: Compilation errors (QT5): "error: 'trUtf8' is deprecated".
Sep 5 2019, 7:39 AM · MITK
tan14007 merged T26666: Deprecation of QObject::trUtf8 in "Modules/AppUtil/src/QmitkSafeNotify.h" into T26643: Compilation errors (QT5): "error: 'trUtf8' is deprecated".
Sep 5 2019, 7:39 AM · MITK
tan14007 updated the task description for T26666: Deprecation of QObject::trUtf8 in "Modules/AppUtil/src/QmitkSafeNotify.h".
Sep 5 2019, 6:28 AM · MITK
tan14007 updated the task description for T26666: Deprecation of QObject::trUtf8 in "Modules/AppUtil/src/QmitkSafeNotify.h".
Sep 5 2019, 6:27 AM · MITK
tan14007 updated the task description for T26666: Deprecation of QObject::trUtf8 in "Modules/AppUtil/src/QmitkSafeNotify.h".
Sep 5 2019, 6:24 AM · MITK
tan14007 triaged T26666: Deprecation of QObject::trUtf8 in "Modules/AppUtil/src/QmitkSafeNotify.h" as Low priority.
Sep 5 2019, 6:21 AM · MITK

Sep 4 2019

bonekamp committed rPROUNET5684aeebf714: license change to GPLv3 (authored by bonekamp).
license change to GPLv3
Sep 4 2019, 12:02 PM

Sep 3 2019

kalali added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

I experienced a problem with that approach:
I have an image with many segmentation nodes as child nodes. If I want to hide all segmentation nodes except for one (using "show only selected node") it does not hide all other segmentation nodes because they are not on the first level.

Sep 3 2019, 6:48 PM · Bugzilla, Pull Request, MITK
kalali reopened T16153: [Segmentation] Jump to center of mass of segmentation on click as "Open".

I'm currently using this inside the semantic relations plugin and I'm thinking about moving the functionality to the data manager context menu or similar.

Sep 3 2019, 12:36 PM · MITK (v2023.04), Bugzilla
kalali reopened T16153: [Segmentation] Jump to center of mass of segmentation on click, a subtask of T15696: implement a multi-label segmentation functionality, as Open.
Sep 3 2019, 12:36 PM · Bugzilla, MITK
onogur added a member for IMSY: heckmann.
Sep 3 2019, 10:17 AM
alenauus closed T26643: Compilation errors (QT5): "error: 'trUtf8' is deprecated" as Resolved.
Sep 3 2019, 10:00 AM · MITK

Sep 2 2019

kalali added a comment to T26496: [mxn multi widget] Re-initializations reset all render windows.
  • creating a new segmentation via the segmentation view

Has been disabled for the BlackSwan Demo. A "re-initialize selected nodes" button has been added, which will reinitialize the geometry of both selected nodes only inside the currently active render window.

Sep 2 2019, 5:17 PM · MITK (v2022.10), Restricted Project
kalali added a member for SIDT: graf.
Sep 2 2019, 3:57 PM
kislinsk changed the Default Edit Policy policy for application Diffusion from Administrators to Custom Policy.
Sep 2 2019, 11:02 AM

Aug 30 2019

kalali added a comment to T25583: Dynamically customize different context menus.

This is also necessary if a context menu action is defined within another plugin, which uses additional module-dependencies.

Aug 30 2019, 6:58 PM · MITK
sattler added a comment to T26588: Integration of ilib python library.

Pushed new branch T26588-cleanup.

Aug 30 2019, 5:22 PM · IMSY, Photoacoustics
eisenman closed T26629: Workbench in inconsistent state after trying to save a tool storage file with insufficient permissions as Resolved.
Aug 30 2019, 5:13 PM · IGT, MITK
eisenman committed rMITK670899eab0ac: Merge branch 'T26629-HandleIGTIOExceptionWhenSavingToolStorage' (authored by eisenman).
Merge branch 'T26629-HandleIGTIOExceptionWhenSavingToolStorage'
Aug 30 2019, 5:11 PM
eisenman added a comment to T26629: Workbench in inconsistent state after trying to save a tool storage file with insufficient permissions.

Pushed new branch T26629-HandleIGTIOExceptionWhenSavingToolStorage.

Aug 30 2019, 5:05 PM · IGT, MITK
kalali updated the task description for T26496: [mxn multi widget] Re-initializations reset all render windows.
Aug 30 2019, 4:42 PM · MITK (v2022.10), Restricted Project
eisenman claimed T26629: Workbench in inconsistent state after trying to save a tool storage file with insufficient permissions.
Aug 30 2019, 3:01 PM · IGT, MITK
sridhara closed T26611: Edit tool tip function in IGT Tracking doesn't apply the correction as Resolved.
Aug 30 2019, 2:48 PM · Restricted Project, MITK
sridhara committed rMITK599a6b77a017: Merge branch 'T26611-EditToolTip_in_IGT-TrackingToolBox_not_working' (authored by sridhara).
Merge branch 'T26611-EditToolTip_in_IGT-TrackingToolBox_not_working'
Aug 30 2019, 2:48 PM
kalali added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

Will be solved if D214 is accepted and merged.

Aug 30 2019, 2:44 PM · MITK
kalali added a revision to T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox: Unknown Object (Differential Revision).
Aug 30 2019, 2:39 PM · MITK
eisenman triaged T26661: Webcam cannot be activated in Ultrasound Support on Linux as Normal priority.
Aug 30 2019, 2:36 PM · Auto-closed, IGT, MITK
kalali added a comment to T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox.

Pushed new branch T24766-Fix-last-time-step-access.

Aug 30 2019, 2:31 PM · MITK
seitela added a comment to T26611: Edit tool tip function in IGT Tracking doesn't apply the correction.

Looks like one solution to the problem. For the other tracking devices, however it seems to be solved by adding the line

Aug 30 2019, 1:22 PM · Restricted Project, MITK
sridhara updated subscribers of T26611: Edit tool tip function in IGT Tracking doesn't apply the correction.

@eisenman @seitela Fixed this bug. Can i go ahead and merge it?

Aug 30 2019, 12:07 PM · Restricted Project, MITK
sridhara added a comment to T26611: Edit tool tip function in IGT Tracking doesn't apply the correction.

Pushed new branch T26611-EditToolTip_in_IGT-TrackingToolBox_not_working.

Aug 30 2019, 12:06 PM · Restricted Project, MITK
kleina added a member for Deep Learning: t543a.
Aug 30 2019, 9:49 AM

Aug 29 2019

sattler added a comment to T26658: Implement beamforming in MITK for curved transducers.

Pushed new branch T26658-Transducers.

Aug 29 2019, 5:56 PM · MITK, Photoacoustics
sattler closed T26060: Command-line interface for PhotoacousticsAlgorithms as Resolved.
Aug 29 2019, 5:00 PM · MITK, Photoacoustics
sattler triaged T26658: Implement beamforming in MITK for curved transducers as Normal priority.
Aug 29 2019, 4:59 PM · MITK, Photoacoustics
jsolislemus added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Apologies for the delay in response..

Aug 29 2019, 3:23 PM · MITK
steint committed rMITKda74b8a7fb07: Merge branch 'T26657-fix-picker-spacing' (authored by steint).
Merge branch 'T26657-fix-picker-spacing'
Aug 29 2019, 11:17 AM

Aug 28 2019

steint committed rMITK237478713b2b: Merge branch 'T26657-fix-picker-spacing' (authored by steint).
Merge branch 'T26657-fix-picker-spacing'
Aug 28 2019, 3:32 PM
steint closed T26657: TubeGraph Picker does not consider image spacing as Resolved.
Aug 28 2019, 3:32 PM · MITK
steint added a comment to T26657: TubeGraph Picker does not consider image spacing.

Pushed new branch T26657-fix-picker-spacing.

Aug 28 2019, 3:30 PM · MITK
steint triaged T26657: TubeGraph Picker does not consider image spacing as Normal priority.
Aug 28 2019, 3:28 PM · MITK
maleike added a project to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling): Noteworthy.
Aug 28 2019, 2:42 PM · MITK, Noteworthy, Pull Request
maleike created T26656: Gitlab pull request 238 (Avoid collapsing 'Properties' view when editing child-properties (e.g. "material.something")).
Aug 28 2019, 2:39 PM · MITK, Pull Request
maleike assigned T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal) to kislinsk.
Aug 28 2019, 2:38 PM · MITK, Pull Request
maleike created T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal).
Aug 28 2019, 2:38 PM · MITK, Pull Request
maleike created T26654: Github pull request 239 (Check filename for invalid characters before saving e.g. "a:b.obj").
Aug 28 2019, 2:37 PM · MITK, Pull Request
maleike created T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).
Aug 28 2019, 2:35 PM · MITK, Noteworthy, Pull Request
mindrocf added a member for OP 4.1: aguilera.
Aug 28 2019, 10:24 AM

Aug 27 2019

kalali added a comment to T25804: [Selection concept] Set 'selected' property when using the new selection concept.

Another idea would be to use our QmitkSelectionServiceConnector to connect the service bus with a slot of the level window manager / level window widget, such that each selection is noticed by the level window slider and the context menu can access the currently selected data nodes.
I looked into the implementation and I think this is something we can do, given the code that we have.
However, I support the idea of rethinking and redesigning the level window manager (resp. level window widget). There are a lot of conditions and checks which make the class complex and error-prone.

Aug 27 2019, 6:40 PM · MITK (v2024.06), Request for Discussion
kalali added a comment to T25804: [Selection concept] Set 'selected' property when using the new selection concept.

Pushed new branch T25804-Level-window-manager-as-selection-service-listener.

Aug 27 2019, 6:38 PM · MITK (v2024.06), Request for Discussion
metzger closed T25412: MitkDICOMQIIO is not built as Resolved.
Aug 27 2019, 4:39 PM · MITK
metzger closed T20103: Improve usability of multilabel segmentation plugin as Resolved.
Aug 27 2019, 4:38 PM · MITK
metzger closed T23362: Load DICOM PM (Parametric Maps) in MITK as Invalid.
Aug 27 2019, 4:38 PM · MITK
metzger closed T23362: Load DICOM PM (Parametric Maps) in MITK, a subtask of T23337: Load DICOM SR in MITK, as Invalid.
Aug 27 2019, 4:38 PM · MICO (Demo_MICCAI_2017), MITK
metzger closed T23337: Load DICOM SR in MITK as Invalid.
Aug 27 2019, 4:37 PM · MICO (Demo_MICCAI_2017), MITK
metzger placed T25192: Enable DICOM SEG conversion for nrrd segmentations up for grabs.
Aug 27 2019, 4:37 PM · MITK (v2024.06), MICO (Demo MICCAI 2018)
metzger closed T23340: Wiki page for DICOM QI in MITK as Wontfix.

See E130-Projekte\MITK-Docs\MITK Schulung\2017 - MICCAI\DICOM_SEG_Gitbook

Aug 27 2019, 4:33 PM · MICO (Demo MICCAI 2018)
kalali added a comment to T18403: Apply current shown level window setting to all selected images.

see T25483: different approach though: The idea is to change the level window slider while the "selected nodes" mode is enabled. This way, the level window will be applied to to all selected data nodes automatically and simultaneously.
The approach proposed here sounds more like using a node which has already a set LW and "propagating" this LW to different nodes (subsequently). I linked this task as we could discuss if this is something we want to have this feature additionally.

Aug 27 2019, 3:43 PM · Bugzilla, MITK

Aug 26 2019

hettich added a comment to T25535: DCMTK won't build if Anaconda is installed.

Speculating:
Maybe that was a bash environment side effect, i cannot reproduce this error on my GNU/Linux system where I use tcsh instead of bash.
The tcsh environment does not contain anything "conda" related, while bash does, if (ana|mini)conda is installed.

Aug 26 2019, 4:18 PM · Auto-closed, MITK
kalali added a comment to T24356: Rework mouse mode switcher.

There are several things to point out here:

  • We could split the class into a real mouse mode switcher that only changes the mouse mode .xml-config file for a new mouse mode.

A new class has been introduced that handles all basic MITK- and PACS- interaction .xml-files in T24357.

Aug 26 2019, 3:41 PM · MITK
kalali added a comment to T24357: Rework mitkMouseModeSwitcher.

Has been solved on top of T26476.
This task will be closed if everything is merged to master and tested (wait for D212).

Aug 26 2019, 3:34 PM · MITK
kalali added a comment to T24357: Rework mitkMouseModeSwitcher.

Pushed new branch T24357-Remove-MouseModeSwitcher.

Aug 26 2019, 3:34 PM · MITK
kalali added a comment to T24357: Rework mitkMouseModeSwitcher.

A new class, the InteractionSchemeSwitcher has already been introduced in 9ab09bff137b. This class is used as a replacement for the MouseModeSwitcher. It it a simplified and cleaned version which reduces the responsibilities of the class: The service registration has been removed and is now done inside QmitkAbstractMultiWidget and DisplayActionEventBroadcast.
Additionally, the scheme switcher is adjusted to match the new scheme config files (see T24368): There is no difference anymore between a mouse mode and an interaction scheme (see T24368).
The new scheme switcher is used within the QmitkInteractionScheme and is currently tested with the QmitkAbstractMultiWidget.

Aug 26 2019, 1:53 PM · MITK
kalali added a comment to T24358: Rework QmitkMouseModeSwitcher.

Has been solved on top of T26476.
This task will be closed if everything is merged to master and tested (wait for D212).

Aug 26 2019, 12:45 PM · MITK
kalali added a comment to T24358: Rework QmitkMouseModeSwitcher.

Pushed new branch T24358-Remove-QmitkMouseModeSwitcher.

Aug 26 2019, 12:44 PM · MITK
kalali added a comment to T24358: Rework QmitkMouseModeSwitcher.

A new class, the QmitkInteractionSchemeToolBar has already been introduced in 9ab09bff137b. This class is used as a replacement for the QmitkMouseModeSwitcher. It it a simplified version which does not observe the mouse mode switcher / interaction scheme switcher. There is no observer tag and no block-functionality.
Additionally, the tool bar is adjusted to match the new InteractionSchemeSwitcher (see T24357): There is no difference anymore between a mouse mode and an interaction scheme (see T24368).
The new toolbar is used for the mxnmulwiwidgeteditor and is currently tested with the stdmultiwidgeteditor (see 732f754ad203).

Aug 26 2019, 12:39 PM · MITK
kalali closed T24368: Interaction scheme has different level of interaction, a subtask of T24356: Rework mouse mode switcher, as Resolved.
Aug 26 2019, 11:39 AM · MITK
kalali closed T24368: Interaction scheme has different level of interaction as Resolved.

Has been solved on top of T26476.

Aug 26 2019, 11:39 AM · MITK
kalali added a comment to T24368: Interaction scheme has different level of interaction.

Pushed new branch T24368-Adjust-display-config-files.

Aug 26 2019, 11:34 AM · MITK
kalali added a comment to T24368: Interaction scheme has different level of interaction.

I decided to go for having an own complete .xml-file for each mode, so I added the full definition for the different PACS modes.
The reason is that we want to have a consistent interaction scheme-handling which means either having full definition for both MITK and PACS modes or having base- and additional definition (like the original PACS modes). But changing the MITK configuration files to the base- and extra-mode variant requires event_variants to be empty in order to disable certain mouse events. Additionally any implementation needs to do two calls, one for setting the base-mode and one for adding the extra mode to make sure the correct base-mode is always set (e.g. switching from MITK to PACS). This was undesirable.

Aug 26 2019, 11:16 AM · MITK
reicht closed T26308: Encrypt tranfers as Resolved.

encryption works as expected

Aug 26 2019, 10:23 AM · CSI-HD

Aug 24 2019

alenauus triaged T26643: Compilation errors (QT5): "error: 'trUtf8' is deprecated" as Unbreak Now! priority.
Aug 24 2019, 9:04 PM · MITK

Aug 23 2019

kalali closed T19643: Interaction problems occur between segmentation tools and renderwindow menu as Invalid.

I'm not sure if this is a valid issue.
I can reproduce the observable result if I don't disable the segmentation tool. I'm still in the drawing mode if the segmentation tool is enabled. If I change the display interaction mode now (by enabling Crosshair rotation (or any other mode - also No crosshair rotation), the MITK interaction scheme is enabled and both interactions happen at the same time (navigating and drawing).
Disabling and re-enabling the tool will again overwrite the navigation interaction and allow to draw the segmentation without any problems.

Aug 23 2019, 6:09 PM · MITK, Bugzilla
kalali closed T19118: Scroll mode in PACS like mouse interaction not re-enabled after using segmentation tool as Invalid.

I can not reproduce this.
After having deselected the Region Growing tool, I can use the left mouse button and move the mouse to scroll through the slices. "Normal" scrolling (does this mean scrolling using the mouse wheel?) does not work. Notice that you can always scroll by pressing the middle mouse and moving the mouse (regardless of the selected PACS mode).
However, in T26486 I changed the PACS mode such that you can always scroll through the slices using the mouse wheel (regardless of the selected PACS mode). The special PACS scroll mode still works for fast scrolling (left mouse button and mouse moving).

Aug 23 2019, 5:58 PM · Bugzilla, MITK
kalali closed T24635: PACS scroll leads to an infinite loop if no image is loaded as Resolved.

Has been solved on top of T26476.

Aug 23 2019, 5:39 PM · MITK
kalali added a comment to T24635: PACS scroll leads to an infinite loop if no image is loaded.

Pushed new branch T24635-Prevent-infinite-scroll-loop.

Aug 23 2019, 5:39 PM · MITK
kalali claimed T24635: PACS scroll leads to an infinite loop if no image is loaded.
Aug 23 2019, 5:16 PM · MITK
kalali closed T26486: PACS mouse mode does not allow scrolling with mouse wheel as Resolved.
Aug 23 2019, 5:10 PM · Breaking Change, MITK (v2021.10)
kalali added a comment to T26486: PACS mouse mode does not allow scrolling with mouse wheel.

Pushed new branch T26486-PACS-mouse-mode-with-mouse-wheel-scrolling.

Aug 23 2019, 5:09 PM · Breaking Change, MITK (v2021.10)
kalali closed T26642: [std / mxn multi widget] Restore original StdMultiWidget interactions as Resolved.
Aug 23 2019, 4:46 PM · Restricted Project, MITK
kalali added a comment to T26642: [std / mxn multi widget] Restore original StdMultiWidget interactions.

Pushed new branch T26642-Restore-original-interactions.

Aug 23 2019, 4:34 PM · Restricted Project, MITK
kalali added a parent task for T26642: [std / mxn multi widget] Restore original StdMultiWidget interactions: Unknown Object (Maniphest Task).
Aug 23 2019, 3:53 PM · Restricted Project, MITK
kalali triaged T26642: [std / mxn multi widget] Restore original StdMultiWidget interactions as Normal priority.
Aug 23 2019, 3:53 PM · Restricted Project, MITK
metzger removed a watcher for Kaapana (internal): metzger.
Aug 23 2019, 12:20 PM

Aug 22 2019

kalali added a comment to T26486: PACS mouse mode does not allow scrolling with mouse wheel.

Combine with T24356 (esp. T24368).

Aug 22 2019, 5:50 PM · Breaking Change, MITK (v2021.10)

Aug 21 2019

floca added a comment to T25804: [Selection concept] Set 'selected' property when using the new selection concept.

OK. But we definetly should talk about it before it is approached.

Aug 21 2019, 7:10 PM · MITK (v2024.06), Request for Discussion
reicht added a comment to T26308: Encrypt tranfers.
  1. encoding File/Blob object to ArrayBuffer (needed as input for AES encryption) crashes browser (tested on Chrome) if file is bigger 1GB:
    • check chunking
Aug 21 2019, 3:22 PM · CSI-HD
neher closed T26421: [CmdInterface] process special characters as Wontfix.
Aug 21 2019, 2:21 PM

Aug 20 2019

reicht updated the task description for T26308: Encrypt tranfers.
Aug 20 2019, 10:46 AM · CSI-HD
reicht changed the visibility for T26299: [Webbased DICOM parsing and file handling].
Aug 20 2019, 10:31 AM · CSI-HD