Page MenuHomePhabricator
Feed All Stories

Jun 22 2021

kalali closed T28204: Refactor LevelWindowManagerTest, a subtask of T28191: Refactor and extend LevelWindow unit tests, as Resolved.
Jun 22 2021, 12:43 PM · Auto-closed, MITK
kalali committed rMITKc7792db0ca5f: Refactor LevelWindowManagerTest (authored by kalali).
Refactor LevelWindowManagerTest
Jun 22 2021, 12:21 PM
kalali committed rMITKf865d82bbecd: Clean test class (authored by kalali).
Clean test class
Jun 22 2021, 12:21 PM
kalali committed rMITKddf77f0ce179: Modify test to retrieve the used levelwindow property (authored by kalali).
Modify test to retrieve the used levelwindow property
Jun 22 2021, 12:21 PM
kalali committed rMITKd0f433b214bb: Make the two different modes be exclusive. (authored by kalali).
Make the two different modes be exclusive.
Jun 22 2021, 12:21 PM
kalali committed rMITK29db4235ea88: Improve code comments (authored by kalali).
Improve code comments
Jun 22 2021, 12:21 PM
kalali committed rMITK1b9b3d1bde61: Improve const correctness (authored by kalali).
Improve const correctness
Jun 22 2021, 12:21 PM
kalali committed rMITK270edc5287dc: Make layer check more consistent (authored by kalali).
Make layer check more consistent
Jun 22 2021, 12:21 PM
kalali committed rMITK4bb670884b96: Add new level window manager test (authored by kalali).
Add new level window manager test
Jun 22 2021, 12:21 PM
kalali committed rMITK13b79a89b771: Fix comments and minor style issues (authored by kalali).
Fix comments and minor style issues
Jun 22 2021, 12:21 PM
kalali committed rMITKf09ff3eb81a5: Remove old tests (authored by kalali).
Remove old tests
Jun 22 2021, 12:21 PM
nolden added a member for MIC: lucaskulla.
Jun 22 2021, 11:41 AM
s669m closed T28567: Microk8s Integration of Kata and Testing as Resolved.

Successfully tested the Microk8s integration of Kata in a container env (Google Cloud Instance)

Jun 22 2021, 10:50 AM · Restricted Project
s669m closed T28567: Microk8s Integration of Kata and Testing, a subtask of T28541: Roadmap and TODO using Kata Container, as Resolved.
Jun 22 2021, 10:50 AM · Restricted Project
s669m updated the task description for T28541: Roadmap and TODO using Kata Container.
Jun 22 2021, 10:50 AM · Restricted Project
s669m triaged T28576: Cilium Integration with Kata possibilities as High priority.
Jun 22 2021, 10:49 AM · Restricted Project
s669m triaged T28575: Test Kata with Sample workloads in a Kaapana env as High priority.
Jun 22 2021, 10:49 AM · Restricted Project
s669m triaged T28574: Integrating Kata with Further MVP's as High priority.
Jun 22 2021, 10:48 AM · Restricted Project
s669m triaged T28573: Integrating with Airflow/Workflow (Kata Env) as High priority.
Jun 22 2021, 10:47 AM · Restricted Project
s669m triaged T28572: Auto-Deploy the pods via helm in a Kata Env as High priority.
Jun 22 2021, 10:47 AM · Restricted Project
s669m triaged T28571: DKFZ Open-stack Kata possibility ( Follow-up with ITCF Team) as High priority.
Jun 22 2021, 10:46 AM · Restricted Project
s669m triaged T28570: Compatibility Test with Kaapana Microk8s and Containerd Tech stack as High priority.
Jun 22 2021, 10:46 AM · Restricted Project
s669m triaged T28569: Test GPU in Kata container as High priority.
Jun 22 2021, 10:45 AM · Restricted Project
s669m triaged T28568: Create an Auto Installation and Configuration of Kata with Microk8s Script (Bash) as High priority.
Jun 22 2021, 10:45 AM · Restricted Project
s669m triaged T28567: Microk8s Integration of Kata and Testing as High priority.
Jun 22 2021, 10:45 AM · Restricted Project
s669m added a comment to T28541: Roadmap and TODO using Kata Container.

Except for the GPU installation/configuration with Kata all others as 1-2 days of work. GPU is definitely possible with Kata, but there are multiple installation and drivers and kernel configurations are recommended by them, and I am not much familiar with GPU installation and configurations before in a server system, rest everything I will change to a sub task now.

Jun 22 2021, 10:44 AM · Restricted Project
floca added a comment to T28541: Roadmap and TODO using Kata Container.

It seems to me that most of this points are at least 1-2 work days worth of time. If this right it would make sense to turn them into subtasks. Then we also have a clearer burn up, because one can explicitly marke sub tasks as done...

Jun 22 2021, 10:39 AM · Restricted Project
s669m updated the task description for T28541: Roadmap and TODO using Kata Container.
Jun 22 2021, 10:31 AM · Restricted Project
kleina closed T27711: Rename segmentation image selection label, a subtask of T28176: [Segmentation] Inspection of module and plugin, as Resolved.
Jun 22 2021, 9:44 AM · MITK (v2024.06)
kleina closed T27711: Rename segmentation image selection label as Resolved.
Jun 22 2021, 9:44 AM · MITK (v2021.10)
kleina committed rMITK752ead6f5e3d: Renamed "Patient Image" to "Selected Image" in segmentation and multilabel… (authored by kleina).
Renamed "Patient Image" to "Selected Image" in segmentation and multilabel…
Jun 22 2021, 9:43 AM
kleina committed rMITK29e507328f2d: Added label "Selected Image" to measurement view. (authored by kleina).
Added label "Selected Image" to measurement view.
Jun 22 2021, 9:43 AM
kleina committed rMITK79b8ddcbb77a: Summary: Renamed "Patient Image" to "Selected Image" in segmentation and… (authored by kleina).
Summary: Renamed "Patient Image" to "Selected Image" in segmentation and…
Jun 22 2021, 9:43 AM
kalali added a comment to T28204: Refactor LevelWindowManagerTest.

That's good to hear so I'm not missing something. However, I never paid attention to this and I'm still wondering why that's the case.
So in my tests I need to find a way to predict the correct outcome in order to make the test succeed.

Jun 22 2021, 8:54 AM · MITK (v2021.10)

Jun 21 2021

kleina claimed T27711: Rename segmentation image selection label.
Jun 21 2021, 4:18 PM · MITK (v2021.10)
kleina moved T27711: Rename segmentation image selection label from Segmentation to Cycle on the MITK (v2021.10) board.
Jun 21 2021, 4:18 PM · MITK (v2021.10)
kleina moved T27713: [Segmentation] Disable "New" button when no image is selected from Segmentation to Cycle on the MITK (v2021.10) board.
Jun 21 2021, 4:17 PM · MITK (v2021.10), Request for Discussion
kleina claimed T27713: [Segmentation] Disable "New" button when no image is selected.
Jun 21 2021, 4:17 PM · MITK (v2021.10), Request for Discussion
kleina closed T28455: RT struct 3D visibility is not working correctly as Resolved.
Jun 21 2021, 4:16 PM · MITK (v2021.10)
kleina committed rMITK67dbb16a81a2: Removed special visibility for 3D render window. It was permanently set to true. (authored by kleina).
Removed special visibility for 3D render window. It was permanently set to true.
Jun 21 2021, 4:15 PM
kleina committed rMITK44e20fed9e54: Removed all special visibility rules for RT struct. Now it behaves the same no… (authored by kleina).
Removed all special visibility rules for RT struct. Now it behaves the same no…
Jun 21 2021, 4:15 PM
kleina committed rMITKf0b8f189c530: Summary: Removed special visibility for 3D render window. It was permanently… (authored by kleina).
Summary: Removed special visibility for 3D render window. It was permanently…
Jun 21 2021, 4:15 PM
kleina committed rMITK1312ed6fdc85: Merge remote-tracking branch 'origin/develop' into bugfix/T28455-rt-struct-3d… (authored by kleina).
Merge remote-tracking branch 'origin/develop' into bugfix/T28455-rt-struct-3d…
Jun 21 2021, 4:15 PM
kleina added a comment to T27711: Rename segmentation image selection label.

Pushed new branch to rMITK MITK: bugfix/T27711-rename-image-selection-label.

Jun 21 2021, 4:07 PM · MITK (v2021.10)
nolden added a member for MIC: nolden.
Jun 21 2021, 3:44 PM
floca added a comment to T28204: Refactor LevelWindowManagerTest.

Just as a side note. As far as I know, the data storage interace gives no guarantees regarding the order (aplied sorting criteria) of returned node sets. So any implementation that relies on such an order is likely to fail.

Jun 21 2021, 3:43 PM · MITK (v2021.10)
kalali added a comment to T28204: Refactor LevelWindowManagerTest.

I used the following code snippet to test the retrieval of the data nodes

void setUp() override
{
  for (int i = 0; i < 3; ++i)
  {
    m_LevelWindowManager = mitk::LevelWindowManager::New();
    m_DataManager = mitk::StandaloneDataStorage::New();
Jun 21 2021, 3:05 PM · MITK (v2021.10)
kalali added a comment to T28204: Refactor LevelWindowManagerTest.

@kislinsk:
So I took a closer look into this and I found out the following:
Inside mitkLevelWindowTest:

  • m_DataNode1: 0x00000221c86a80f0
  • m_DataNode2: 0x00000221c86a6930
  • m_DataNode3: 0x00000221c86a7bf0
Jun 21 2021, 2:20 PM · MITK (v2021.10)
s669m updated the task description for T28541: Roadmap and TODO using Kata Container.
Jun 21 2021, 12:11 PM · Restricted Project

Jun 18 2021

kalali added a comment to T28204: Refactor LevelWindowManagerTest.

We also found out that the current LevelWindowManagerTest fails: https://cdash.mitk.org/testDetails.php?test=774190&build=12215
The problem is the modified LevelWindowManager in combination with the mentioned random tests: The random tests can lead to all nodes having an invalid rendering mode. The LevelWindowManager has been modified in T28250 which conflicts with the current level window manager test.

Jun 18 2021, 12:16 PM · MITK (v2021.10)
floca triaged T28561: Refactor/Fix mitk::SegmentationInteractor::ChangeActiveLabel as High priority.
Jun 18 2021, 8:51 AM · MITK (v2024.06)

Jun 17 2021

kleina added a project to T28557: Cannot load segmentations from KITS challenge due to unknown pixel type: Request for Discussion.
Jun 17 2021, 3:55 PM · MITK, Request for Discussion
kleina added a comment to T28557: Cannot load segmentations from KITS challenge due to unknown pixel type.

I tried to add

long long

to the list. That caused my superbuild to crash. Then I added

int64_t

The superbuild worked, but now the workbench crashes during the load attempt with:

Jun 17 2021, 3:55 PM · MITK, Request for Discussion
kleina added a project to T28544: Difference of loading RT data DicomBrowser vs. "Standard loading": Request for Discussion.

There was a discrepancy regarding how the RtStruts are displayed. When loading via DICOMBrowser, they were now visible on stdmulti.widget2 and 3. Is this the desired behavior? On there planes, one can only see "dots". We should discuss this.

Jun 17 2021, 2:30 PM · MITK (v2024.06), Request for Discussion
a178n added a comment to T28523: Evaluate MITK segmentation survey.

Hi,
Currently, we have only 3 responses (including Fabian's).
Here is the data:

Jun 17 2021, 2:18 PM · MITK (v2021.10)
floca assigned T28523: Evaluate MITK segmentation survey to a178n.

What is the status here? This is on "unbreak now", but no assignee. Is there something to evaluate yet?

Good point. @a178n I put you as asignee for now as you started the survey. How many answers do we have already. If it is a low number, then could you send a reminder. So that we can compile the result for internal read through next Wednesday?

Jun 17 2021, 2:11 PM · MITK (v2021.10)
kleina added a comment to T27711: Rename segmentation image selection label.

Same goes for MultiLabel Segmentation.

Jun 17 2021, 2:05 PM · MITK (v2021.10)
kleina added a comment to T27711: Rename segmentation image selection label.

While we are doing that: The measurement Plugin does not have a label at all. I would suggest having this consistent.

Jun 17 2021, 2:04 PM · MITK (v2021.10)
kleina added a comment to T28523: Evaluate MITK segmentation survey.

What is the status here? This is on "unbreak now", but no assignee. Is there something to evaluate yet?

Jun 17 2021, 1:59 PM · MITK (v2021.10)
thomass updated subscribers of T28267: [Visualization] Custom colormaps are not handeled correctly.

As discussed with @s434n, I will discard my diff D466 for now, because it caused some unwanted interactions with the LayoutAnnotationRenderer. The quick fix of D506 solves the problem that in Geldosimetry and OverlayManager the colorbarAnnotation is not displayed on the right at the center (placed too heigh and is cutoff in the render window).

Jun 17 2021, 12:02 PM · Auto-closed, MITK
kleina triaged T28557: Cannot load segmentations from KITS challenge due to unknown pixel type as Normal priority.
Jun 17 2021, 10:44 AM · MITK, Request for Discussion
kleina added a comment to T28544: Difference of loading RT data DicomBrowser vs. "Standard loading".

Pushed new branch to rMITK MITK: bugfix/T28544-difference-RT-data-loading.

Jun 17 2021, 10:03 AM · MITK (v2024.06), Request for Discussion
kleina triaged T28556: I/O handling of folder/subfolder structures and automatic scene creation as Low priority.
Jun 17 2021, 9:52 AM · Auto-closed, Missing Info, MITK
kleina triaged T28555: Simplified version of segmentation with only desired tools as Low priority.
Jun 17 2021, 9:47 AM · Auto-closed, MITK, Missing Info

Jun 16 2021

kalali removed a project from T28464: [Segmentation] New Add/Remove tool: Request for Discussion.
Jun 16 2021, 1:04 PM · MITK (v2022.10)
kalali updated subscribers of T27154: Define clean workflow for segmentation copying.
Jun 16 2021, 1:04 PM · MITK (v2024.06)
kalali removed a project from T27154: Define clean workflow for segmentation copying: Request for Discussion.

This is a bigger topic, connected to the refactoring of the segmentation and should be handled in multiple sub-tasks, to split the topic into smaller issues.

Jun 16 2021, 1:04 PM · MITK (v2024.06)
kalali removed a project from T28181: [Segmentation] Should warning messages be passed on to the UI?: Request for Discussion.

I will start looking into this to give some examples of important warnings / errors that the user should know about.

Jun 16 2021, 1:02 PM · MITK (v2024.06)
kalali updated subscribers of T28490: Segmentation plugin: "new" segmentation should not run reinit!.

We should look into this and focus on the mentioned related task by @kislinsk to start with separating the two processes:

  1. matching the geometry of the images for interaction
  2. resetting the view of render windows to see the new segmentation
Jun 16 2021, 12:45 PM · Cleared, MITK (v2021.10)
floca removed a project from T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem: Request for Discussion.
Jun 16 2021, 12:39 PM · MITK (v2022.04), Cleared
kalali moved T28490: Segmentation plugin: "new" segmentation should not run reinit! from Backlog to MITK Meeting on the Request for Discussion board.
Jun 16 2021, 9:46 AM · Cleared, MITK (v2021.10)
kalali added a project to T28490: Segmentation plugin: "new" segmentation should not run reinit!: Request for Discussion.
Jun 16 2021, 9:46 AM · Cleared, MITK (v2021.10)
kalali moved T28548: Allow Zooming during creation of Segmentation. from Backlog to Segmentation on the MITK (v2021.10) board.
Jun 16 2021, 9:33 AM · MITK (v2023.12), Request for Discussion
floca added a comment to T28135: [MultiLabel Segmentation] Utilities view cannot handle non-binary multilabel segmentations.

@floca Is this something worth looking into before the refactoring is done?

I would say: no.

Jun 16 2021, 9:12 AM · MITK (v2023.04)
kalali updated subscribers of T28135: [MultiLabel Segmentation] Utilities view cannot handle non-binary multilabel segmentations.

@floca Is this something worth looking into before the refactoring is done? If we stick with LabelSetImages and the basic backend of the utilities, I don't see a reason for this to be postponed.

Jun 16 2021, 9:08 AM · MITK (v2023.04)
kalali added a comment to T28315: [Selection concept] Provide preference page option to show / hide helper nodes.

Maybe an option inside the node selection dialog would work here?

Jun 16 2021, 9:05 AM · Request for Discussion, MITK (v2021.10)
kalali added a comment to T26972: Dialog and plugin layout seems to be not shown correctly on laptops.

Is this an issue we need to address? Did anyone else experience this behavior?

Jun 16 2021, 9:03 AM · MITK (v2024.06), Missing Info
floca added a project to T28315: [Selection concept] Provide preference page option to show / hide helper nodes: Request for Discussion.

I understand the reasoning behind that feature request, but I think it should be discussed. At least it contradicts one of the key assumptions of the new selection concept: relevance criteria is defined localy in the view.

Jun 16 2021, 9:02 AM · Request for Discussion, MITK (v2021.10)
kalali moved T27060: [Segmentation] Rework InterpolationWidget to not depend on data manager view directly from Backlog to MITK Meeting on the Request for Discussion board.
Jun 16 2021, 9:02 AM · MITK (v2024.06)
kalali added a project to T27060: [Segmentation] Rework InterpolationWidget to not depend on data manager view directly: Request for Discussion.
Jun 16 2021, 9:02 AM · MITK (v2024.06)
kalali moved T27060: [Segmentation] Rework InterpolationWidget to not depend on data manager view directly from Backlog to Segmentation on the MITK (v2021.10) board.
Jun 16 2021, 9:00 AM · MITK (v2024.06)
kalali edited projects for T27060: [Segmentation] Rework InterpolationWidget to not depend on data manager view directly, added: MITK (v2021.10); removed MITK.
Jun 16 2021, 9:00 AM · MITK (v2024.06)
kalali moved T27149: [Segmentation] Interpolation nodes / position nodes are not correctly hidden from Backlog to MITK Meeting on the Request for Discussion board.
Jun 16 2021, 9:00 AM · MITK (v2024.06)
kalali added a project to T27149: [Segmentation] Interpolation nodes / position nodes are not correctly hidden: Request for Discussion.
Jun 16 2021, 9:00 AM · MITK (v2024.06)
kalali moved T28181: [Segmentation] Should warning messages be passed on to the UI? from Backlog to MITK Meeting on the Request for Discussion board.
Jun 16 2021, 8:57 AM · MITK (v2024.06)
kalali moved T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change from Backlog to Segmentation on the MITK (v2021.10) board.
Jun 16 2021, 8:56 AM · Request for Discussion, MITK (v2021.10)
kalali edited projects for T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change, added: MITK (v2021.10); removed MITK.
Jun 16 2021, 8:56 AM · Request for Discussion, MITK (v2021.10)
kalali claimed T28315: [Selection concept] Provide preference page option to show / hide helper nodes.
Jun 16 2021, 8:53 AM · Request for Discussion, MITK (v2021.10)

Jun 15 2021

s434n added a comment to T28385: [Segmentation] Erosion crashes the MITK Workbench after interpolation.

I was able to reproduce the bug for all morphological operations (Dilation, Erosion, ...) and also in all orientations (axial, coronal, sagittal). Other segmentation utilities all work without problem.

Jun 15 2021, 4:13 PM · Cleared, MITK (v2021.10)
kislinsk closed T28358: Data Manager context menu items added multiple times for multi-selections as Invalid.

Wasn't able to reproduce it anymore, too.

Jun 15 2021, 12:27 PM · MITK (v2021.10)
kleina added a comment to T28358: Data Manager context menu items added multiple times for multi-selections.

I could not reproduce this.

image.png (315×416 px, 36 KB)

Jun 15 2021, 11:07 AM · MITK (v2021.10)
kleina updated the task description for T28550: MitkResampleImage and MitkResampleMask CL tools produce result with different dimensions.
Jun 15 2021, 10:03 AM · Auto-closed, Request for Discussion, MITK
kleina triaged T28550: MitkResampleImage and MitkResampleMask CL tools produce result with different dimensions as Low priority.
Jun 15 2021, 10:03 AM · Auto-closed, Request for Discussion, MITK
kislinsk added a revision to T28455: RT struct 3D visibility is not working correctly: Unknown Object (Differential Revision).
Jun 15 2021, 9:52 AM · MITK (v2021.10)
kislinsk closed T28546: Fix macOS CI builds as Resolved.

I reported the cmakebuilder-plugin issue to Jenkins: https://issues.jenkins.io/browse/JENKINS-65893

Jun 15 2021, 9:49 AM · CI, MITK
kislinsk added a comment to T28546: Fix macOS CI builds.

Deleted branch from rMITK MITK: bugfix/T28546-macOSCatalina-Boost.

Jun 15 2021, 9:48 AM · CI, MITK
kislinsk committed rMITK5e7000af2207: Use default project-config.jam file on macOS (authored by kislinsk).
Use default project-config.jam file on macOS
Jun 15 2021, 9:12 AM
kislinsk committed rMITKb1c7fb9eda5f: Merge branch 'bugfix/T28546-macOSCatalina-Boost' into develop (authored by kislinsk).
Merge branch 'bugfix/T28546-macOSCatalina-Boost' into develop
Jun 15 2021, 9:12 AM
kislinsk added a comment to T28546: Fix macOS CI builds.

Pushed new branch to rMITK MITK: bugfix/T28546-macOSCatalina-Boost.

Jun 15 2021, 9:12 AM · CI, MITK
kislinsk reopened T28546: Fix macOS CI builds as "Open".

We also need to fix the Boost binary build on macOS.

Jun 15 2021, 9:05 AM · CI, MITK