Page MenuHomePhabricator
Feed All Stories

Jan 13 2021

kislinsk committed rMITK6617af527acd: Patch (and upgrade) VTK (authored by kislinsk).
Patch (and upgrade) VTK
Jan 13 2021, 2:16 PM
kislinsk committed rMITKca75fe9867c2: Fix compiler errors with XCode 12 (authored by kislinsk).
Fix compiler errors with XCode 12
Jan 13 2021, 2:16 PM
kislinsk committed rMITKbce1eaddb837: Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop (authored by kislinsk).
Merge branch 'bugfix/T28151-FixVTKOnMacOSXCode12' into develop
Jan 13 2021, 2:16 PM
gaoh added a comment to T28127: Reopen segmentation in MITK.

Oh I forgot to mention: the segmentation is saved as dicom-seg.

Jan 13 2021, 10:09 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)
gaoh raised the priority of T28127: Reopen segmentation in MITK from High to Unbreak Now!.
Jan 13 2021, 10:06 AM · MITK (v2021.02), Restricted Project, Kaapana (internal)
kislinsk added a comment to T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12.

Pushed new branch bugfix/T28151-FixVTKOnMacOSXCode12.

Jan 13 2021, 9:45 AM · Noteworthy, MITK (v2021.02)

Jan 12 2021

gtbuzz updated the task description for T28152: Question about source code and executable example app.
Jan 12 2021, 5:17 PM
gtbuzz created T28152: Question about source code and executable example app.
Jan 12 2021, 5:16 PM

Jan 11 2021

kislinsk triaged T28151: [macOS] MITK (resp. VTK) doesn't compile with XCode 12 as Unbreak Now! priority.
Jan 11 2021, 11:18 PM · Noteworthy, MITK (v2021.02)
kislinsk closed T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start , a subtask of T27196: Rewrite packaging of MITK, as Resolved.
Jan 11 2021, 11:12 PM · Moved to git.dkfz.de, MITK, Cleared
kislinsk closed T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start as Resolved.
Jan 11 2021, 11:12 PM · MITK (v2021.02)
kislinsk added a comment to T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .

Deleted branch bugfix/T27717-FixMacOSInstallerOpenApp.

Jan 11 2021, 11:12 PM · MITK (v2021.02)
kislinsk committed rMITKff9ca2f439c0: Fix num of chars in strncmp() (authored by kislinsk).
Fix num of chars in strncmp()
Jan 11 2021, 11:12 PM
kislinsk committed rMITK35cc4be67bda: Merge branch 'bugfix/T27717-FixMacOSInstallerOpenApp' into develop (authored by kislinsk).
Merge branch 'bugfix/T27717-FixMacOSInstallerOpenApp' into develop
Jan 11 2021, 11:12 PM
kislinsk added a comment to T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .

Pushed new branch bugfix/T27717-FixMacOSInstallerOpenApp.

Jan 11 2021, 11:11 PM · MITK (v2021.02)
kislinsk added a comment to T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .

It works when any argument is passed to the workbench via the open command, e.g., open MitkWorkbench.app --args --BlueBerry.newInstance. My first guess that the additions in rMITKf54a83e2 cannot handle 0 arguments when the implicit -psn argument is sneaked into argv by macOS.

Jan 11 2021, 9:25 PM · MITK (v2021.02)
kislinsk claimed T27717: Mac OS: MITK Workbench&Flowbench crashes immediately after start .
Jan 11 2021, 8:56 PM · MITK (v2021.02)
floca triaged T28150: [RT] Refactor RT Dose reader as Normal priority.
Jan 11 2021, 7:19 PM · Moved to git.dkfz.de, MITK
floca added a comment to T27689: RTDose image can not be serialized and workbench crashes upon loading.

Ok. Found the problem. Should now be fixed with the new diff. At least it works on my PC now with the test files.

Jan 11 2021, 7:12 PM · Request for Discussion, MITK
kislinsk closed T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore as Resolved.

Was removed in rMITK66bb0d67 and forgotten to get restored in rMITK02a46548.

Jan 11 2021, 3:58 PM · MITK (v2021.02)
kislinsk added a comment to T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Deleted branch bugfix/T28137-FixMissingContextMenuEntries.

Jan 11 2021, 3:57 PM · MITK (v2021.02)
kislinsk committed rMITK1aa2efd2c474: Add missing context menu extension point line (authored by kislinsk).
Add missing context menu extension point line
Jan 11 2021, 3:57 PM
kislinsk committed rMITK2e864760744f: Merge branch 'bugfix/T28137-FixMissingContextMenuEntries' into develop (authored by kislinsk).
Merge branch 'bugfix/T28137-FixMissingContextMenuEntries' into develop
Jan 11 2021, 3:57 PM
kislinsk added a comment to T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Pushed new branch bugfix/T28137-FixMissingContextMenuEntries.

Jan 11 2021, 3:55 PM · MITK (v2021.02)
kislinsk added a comment to T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Thanks @kalali, nice find and hint. A sneaky line is missing in DataManager's plugin.xml: <extension-point id="contextMenuActions" name="Context menu actions"/>.

Jan 11 2021, 3:51 PM · MITK (v2021.02)
kislinsk claimed T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.
Jan 11 2021, 3:39 PM · MITK (v2021.02)
kislinsk raised the priority of T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore from High to Unbreak Now!.
Jan 11 2021, 12:08 PM · MITK (v2021.02)
kompan lowered the priority of T27153: Fit CRMO2-model to mean value of ROI from Normal to Low.
Jan 11 2021, 10:10 AM · Restricted Project

Jan 9 2021

floca triaged T28148: Fix/Refactor ContourElement as Unbreak Now! priority.
Jan 9 2021, 4:52 PM · MITK (v2021.02)
floca added a revision to T26975: 2D Fast Marching for 4D data intermediate state displays segmentation in other timesteps: Unknown Object (Differential Revision).
Jan 9 2021, 1:27 PM · Missing Info, MITK (v2021.02)

Jan 5 2021

floca triaged T28146: Rework how SegTool2D should add contour markers as Low priority.
Jan 5 2021, 5:06 PM · Moved to git.dkfz.de, MITK (v2024.12)
floca triaged T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures. as Normal priority.
Jan 5 2021, 4:56 PM · MITK (v2022.10)
floca created T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures..
Jan 5 2021, 4:55 PM · MITK (v2022.10)
floca triaged T28144: CorrectorTool does not properly handle unlocked lables of LabelSet Images as Normal priority.
Jan 5 2021, 4:41 PM · Request for Discussion, MITK (v2021.10)
floca added a comment to T26975: 2D Fast Marching for 4D data intermediate state displays segmentation in other timesteps.

Will be fixed (is fixed already) by the rework done in T28118.

Jan 5 2021, 4:30 PM · Missing Info, MITK (v2021.02)
floca added a revision to T27800: [Segmentation] Live Wire crashes with 4D image and static segmentation: Restricted Differential Revision.
Jan 5 2021, 11:01 AM · MITK (v2021.02)
floca added a revision to T28128: ContourModels are not correctly rendered on time steps > 0: Restricted Differential Revision.
Jan 5 2021, 11:01 AM · MITK
floca added a revision to T28129: Contour interactor do not handle time steps > 0 correctly and do not support time geometries correctly: Restricted Differential Revision.
Jan 5 2021, 11:01 AM · MITK

Jan 4 2021

schellem closed T28143: PAI Absorption spectra correction as Resolved.
Jan 4 2021, 9:59 PM · Photoacoustics, IMSY
schellem added a comment to T28143: PAI Absorption spectra correction.

Pushed new branch T28143-AbsSpectraCorrection.

Jan 4 2021, 9:57 PM · Photoacoustics, IMSY
schellem triaged T28143: PAI Absorption spectra correction as Normal priority.
Jan 4 2021, 9:51 PM · Photoacoustics, IMSY
thomass added a comment to T27689: RTDose image can not be serialized and workbench crashes upon loading.

The scene is created successfully if following (deprecated) properties are disabled in mitkDICOMImageBlockDescriptor.cpp:

Jan 4 2021, 5:10 PM · Request for Discussion, MITK
kalali triaged T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation as Normal priority.
Jan 4 2021, 12:29 PM · MITK (v2022.04), Breaking Change
kalali renamed T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem from [Segmentation] Multilable label name dialoge on label creation is a UX problem to [Segmentation] Multilabel label name dialoge on label creation is a UX problem.
Jan 4 2021, 12:21 PM · MITK (v2022.04), Cleared
kalali added a comment to T28118: Refactoring of SegTool2D.

Regarding the selection, I think you are rigt and there should ultimatly be no difference. But for the current strive for getting things cleaned up and in shape, it is of lower priority. I am happy, if we get through with the fundamental rework and time consistency stuff for this release.

Jan 4 2021, 12:07 PM · MITK (v2021.02)
floca added a comment to T28118: Refactoring of SegTool2D.

Looking through the checklists I found that the 2D tools of the segmentation view are different than the 2D tools of the Multilabel segmentation (one more: Fast Marching is missing).

What do you mean with different. Different in there behavior or a different selection of tools.

Jan 4 2021, 11:45 AM · MITK (v2021.02)

Jan 3 2021

kalali triaged T28140: [MultiLabel Segmentation] Default parameter (unsigned int layer = 0) is unnecessary and causes problems as Normal priority.
Jan 3 2021, 4:04 PM · MITK (v2024.06)
kalali triaged T28139: [LabelSetImage] Ambigious meaning of "layer" in LabelSetImage as Normal priority.
Jan 3 2021, 3:27 PM · MITK (v2023.12), Request for Discussion

Jan 2 2021

kalali renamed T28138: [MultiLabel Segmentation] Add tests for the LabelSetImage from [MultiLabel Segmentation] Add tests for the Label Set Image to [MultiLabel Segmentation] Add tests for the LabelSetImage.
Jan 2 2021, 9:19 PM · MITK (v2022.10)
kalali triaged T28138: [MultiLabel Segmentation] Add tests for the LabelSetImage as Normal priority.
Jan 2 2021, 5:48 PM · MITK (v2022.10)
kalali placed T28132: Extend "Checkliste MultiLabel Segmentierung – Interpolation" up for grabs.
Jan 2 2021, 4:31 PM · MITK (v2022.04)
kalali added a comment to T28136: Extend "Checkliste MultiLabel Segmentierung – Optionen".

There are some issues / open questions regarding the MultiLabel Segmentation options:
T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary", T27712: Preference "Show as volume rendering" does not display segmentation volume in 4-window view, T27498#216892, T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore.

Jan 2 2021, 4:27 PM · MITK (v2022.04)
kalali triaged T28137: Extension point for org.mitk.gui.qt.datamanager.contextMenuActions does not work anymore as High priority.
Jan 2 2021, 4:00 PM · MITK (v2021.02)
kalali added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.
Jan 2 2021, 2:08 PM · Restricted Project, MITK (v2021.02)
kalali added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.

I just realized that the auto-selection mode of the Data node selection mode in the preferences pages of the Segmentation and MultiLabel Segmentation does not work anymore. I did not look into it but it might be related to the new selection concept.

Jan 2 2021, 2:08 PM · Restricted Project, MITK (v2021.02)
kalali moved T19522: Segmentation not displayed in 3d-render window from Backlog to Segmentation on the MITK (v2021.02) board.
Jan 2 2021, 2:03 PM · MITK, Bugzilla
kalali edited projects for T19522: Segmentation not displayed in 3d-render window, added: MITK (v2021.02); removed MITK.
Jan 2 2021, 2:03 PM · MITK, Bugzilla
kalali updated the task description for T28136: Extend "Checkliste MultiLabel Segmentierung – Optionen".
Jan 2 2021, 1:49 PM · MITK (v2022.04)
kalali updated the task description for T28133: Extend "Checkliste MultiLabel Segmentierung – Utilities".
Jan 2 2021, 1:48 PM · MITK (v2022.04)
kalali updated the task description for T28130: Extend "Checkliste MultiLabel Segmentierung – 3D Segmentierung".
Jan 2 2021, 1:48 PM · MITK (v2022.04)
kalali updated the task description for T28111: Extend "Checkliste MultiLabel Segmentierung – 2D Segmentierung".
Jan 2 2021, 1:48 PM · MITK (v2022.04)
kalali updated the task description for T27906: Extend "Checkliste Segmentierung – Utilities".
Jan 2 2021, 1:47 PM · MITK (v2022.04), Cleared
kalali updated the task description for T27873: Extend "Checkliste Segmentierung – Interpolation".
Jan 2 2021, 1:47 PM · MITK (v2022.04), Cleared
kalali updated the task description for T27850: Extend "Checkliste Segmentierung – 3D Segmentierung".
Jan 2 2021, 1:47 PM · MITK (v2022.04), Cleared
kalali updated the task description for T27737: Extend "Checkliste Segmentierung – Optionen".
Jan 2 2021, 1:47 PM · MITK (v2022.04), Cleared
kalali updated the task description for T27716: Extend "Checkliste Segmentierung – Manuelle Segmentierung / 2D Segmentierung".
Jan 2 2021, 1:47 PM · MITK (v2022.04), Cleared
kalali removed a project from T28134: [Multilabel Segmentation] No warning triggered when using different mask geometries / dimensions in Utilities View: Restricted Project.
Jan 2 2021, 1:38 PM · MITK (v2022.10), Cleared

Jan 1 2021

kalali placed T28133: Extend "Checkliste MultiLabel Segmentierung – Utilities" up for grabs.
Jan 1 2021, 3:01 PM · MITK (v2022.04)
kalali moved T28132: Extend "Checkliste MultiLabel Segmentierung – Interpolation" from Backlog to Test/Checklists on the MITK (v2021.02) board.
Jan 1 2021, 3:00 PM · MITK (v2022.04)
kalali moved T28133: Extend "Checkliste MultiLabel Segmentierung – Utilities" from Backlog to Test/Checklists on the MITK (v2021.02) board.
Jan 1 2021, 3:00 PM · MITK (v2022.04)
kalali moved T28136: Extend "Checkliste MultiLabel Segmentierung – Optionen" from Backlog to Test/Checklists on the MITK (v2021.02) board.
Jan 1 2021, 3:00 PM · MITK (v2022.04)
kalali triaged T28136: Extend "Checkliste MultiLabel Segmentierung – Optionen" as High priority.
Jan 1 2021, 3:00 PM · MITK (v2022.04)
kalali added a comment to T28133: Extend "Checkliste MultiLabel Segmentierung – Utilities".

There are some major issues / open questions regarding the MultiLabel Segmentation View, which make it difficult to define tests and create checklists. These issues / questions should be addresses first to understand the utilities view better: T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty, T27810: [Multilabel Segmentation] Inconsistencies and unclear functionality in operations of Utilities view, T28134: [Multilabel Segmentation] No warning triggered when using different mask geometries / dimensions in Utilities View, T28135: [MultiLabel Segmentation] Utilities view cannot handle non-binary multilabel segmentations.

Jan 1 2021, 2:56 PM · MITK (v2022.04)
kalali triaged T28135: [MultiLabel Segmentation] Utilities view cannot handle non-binary multilabel segmentations as Normal priority.
Jan 1 2021, 2:37 PM · MITK (v2023.04)
kalali triaged T28134: [Multilabel Segmentation] No warning triggered when using different mask geometries / dimensions in Utilities View as Normal priority.
Jan 1 2021, 1:59 PM · MITK (v2022.10), Cleared
kalali renamed T27571: Multilabel segmentation does not work with US DICOM images from Multilable segmentation does not work with US DICOM images to Multilabel segmentation does not work with US DICOM images.
Jan 1 2021, 1:56 PM · MITK (v2021.10), Missing Info, Restricted Project
kalali triaged T28133: Extend "Checkliste MultiLabel Segmentierung – Utilities" as High priority.
Jan 1 2021, 1:33 PM · MITK (v2022.04)
kalali updated the task description for T28132: Extend "Checkliste MultiLabel Segmentierung – Interpolation".
Jan 1 2021, 1:17 PM · MITK (v2022.04)
kalali triaged T28132: Extend "Checkliste MultiLabel Segmentierung – Interpolation" as High priority.
Jan 1 2021, 12:51 PM · MITK (v2022.04)
kalali updated the task description for T28130: Extend "Checkliste MultiLabel Segmentierung – 3D Segmentierung".
Jan 1 2021, 12:49 PM · MITK (v2022.04)

Dec 23 2020

kleina added a member for Deep Learning: j902n.
Dec 23 2020, 12:44 PM
kleina added a member for MIC: j902n.
Dec 23 2020, 12:43 PM

Dec 22 2020

kalali added a comment to T28130: Extend "Checkliste MultiLabel Segmentierung – 3D Segmentierung".

Similar to T28111: Extend "Checkliste MultiLabel Segmentierung – 2D Segmentierung" I updated the document and added content to explicitly tests different image types / segmentation types, labels and layers.
I copied the modified document to E130-Daten\Release\Checklisten\MITK Workbench Release and named it Checkliste MultiLabel Segmentierung – 3D Segmentierung.

Dec 22 2020, 12:57 PM · MITK (v2022.04)
kalali triaged T28131: [MultiLabel Segmentation] 3D Threshold tool does not work with multiple labels / layers as Normal priority.
Dec 22 2020, 12:53 PM · Request for Discussion, MITK (v2022.04)
kalali added a comment to T28118: Refactoring of SegTool2D.

Looking through the checklists I found that the 2D tools of the segmentation view are different than the 2D tools of the Multilabel segmentation (one more: Fast Marching is missing). The 3D tools of the multi label segmentation even contain only the Threshold tool.
Thinking about the idea of the MultiLabel segmentation (and that our normal segmentation view also generates labelset images) it should actually not make any difference and thus the tools should be the same (2D and 3D are of course different).
Also, there seems to be a lot of redundancy UI-wise so even having multiple segmentation views and the 2D / 3D tool view for both views seems unnecessary. I would keep that in mind while refactoring the tools. But I am open for discussion on this topic.

Dec 22 2020, 11:55 AM · MITK (v2021.02)
floca added a comment to T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change.

I haven't made up my mind about the best way to go, I'm open for suggestions. I just wanted to state that even the checklists state something different. So to align the tests with what the workbench actually does, we should clarify, how the tools actually behave or should behave.

  • If the tool is deactivated (explicitly, by selecting another tool, by closing the view) all unconfirmed contours will be removed.

And this is not the case right now. Currently, a mask will be generated and drawn into the image.

Dec 22 2020, 11:21 AM · Request for Discussion, MITK (v2021.10)
kalali moved T28130: Extend "Checkliste MultiLabel Segmentierung – 3D Segmentierung" from Backlog to Test/Checklists on the MITK (v2021.02) board.
Dec 22 2020, 11:21 AM · MITK (v2022.04)
kalali triaged T28130: Extend "Checkliste MultiLabel Segmentierung – 3D Segmentierung" as High priority.
Dec 22 2020, 11:20 AM · MITK (v2022.04)
kalali added a comment to T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change.

I haven't made up my mind about the best way to go, I'm open for suggestions. I just wanted to state that even the checklists state something different. So to align the tests with what the workbench actually does, we should clarify, how the tools actually behave or should behave.

Dec 22 2020, 11:07 AM · Request for Discussion, MITK (v2021.10)
floca added a comment to T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change.

Regarding the issue itself: I think it is a fundamental question of the capability of the tool. Auto confirm when closing the contour would
Pro: be a faster UX
Contra: won't allow to alter live wires before confirmation.

Dec 22 2020, 10:47 AM · Request for Discussion, MITK (v2021.10)
floca added a comment to T28113: [Segmentation] LiveWire tool confirms segmentation upon tool or label change.

I just found out that the Checklists also states the following:

Deaktiveren des Live Wire Tools
  Tool Icon verschwindet vom Mouse Cursor
  Die gelben Konturen werden weiterhin angezeigt, können aber nicht mehr bearbeitet werden

So even the experienced behavior does not fit the checklist test. We should clarify which workflow we want to provide.

Dec 22 2020, 10:44 AM · Request for Discussion, MITK (v2021.10)
floca triaged T28129: Contour interactor do not handle time steps > 0 correctly and do not support time geometries correctly as Normal priority.
Dec 22 2020, 10:13 AM · MITK
floca triaged T28128: ContourModels are not correctly rendered on time steps > 0 as Normal priority.
Dec 22 2020, 10:09 AM · MITK
floca claimed T27800: [Segmentation] Live Wire crashes with 4D image and static segmentation.

Will be fixed (is fixed already) by the rework done in T28118.

Dec 22 2020, 9:35 AM · MITK (v2021.02)
kalali accepted rMITKfd4af29ccbb8: Add mitkImageStatisticsContainerTest.cpp.
Dec 22 2020, 9:11 AM
kalali accepted rMITK318208495e06: Adapt printTest to just check if no exception is thrown.
Dec 22 2020, 9:08 AM
kalali accepted rMITKda6b13dcd728: Add a test to check if empty container trigger an exception if….
Dec 22 2020, 9:07 AM
kalali accepted rMITK9564428ee562: Correct AllStatisticNamesForContainer() Test.
Dec 22 2020, 9:04 AM

Dec 21 2020

kalali added a subtask for T28108: [Release Checklists] Prepare release checklists: T28110: Extend checklists for multilabel segmentation view.
Dec 21 2020, 2:59 PM · MITK
kalali added a parent task for T28110: Extend checklists for multilabel segmentation view: T28108: [Release Checklists] Prepare release checklists.
Dec 21 2020, 2:59 PM · MITK (v2022.04)